robot code issue

Projects Programming
1

my servo won't activate when i run code however my motors run fine
what am i missing or not seeing...

// losi twin motor ESC with reverse, futaba SERVO sketch
// BY "a little bit of everyone"

#include <Servo.h> 
 
Servo myservo1;  // create servo object to control a esc
Servo myservo2;  // steering servo               
 
int pos = 90;    // variable to store the servo position 
 
int armValue=90; //"ZERO" position for arming ESC. As some wont arm with a '0' value from the arduino. (may need to experiment)

void arm() //Arming sequence of sending a minimum or 'joystick zero' for 10 seconds to simulate radio gear is ON and operational. 
{
myservo1.write(armValue); 
myservo2.write(pos);
delay(10000); //Delay for the ESC to activate. (may need to experiment)
}
void setup() 
{ 
  myservo1.attach(11);  // attaches the esc on pin 11 to the servo object 
  myservo2.attach(9);   // attaches the steering servo on pin 9
  arm(); // Arming sequence finished
} 
 
 
void loop() // remember 0 degrees is full speed reverse 90 degrees is neutral and 180 degrees is full speed foward 
{ 
//--------------------------ESC CONTROL--------------------------------------------------------------------------------------
  for(pos = 90; pos < 130; pos += 20)  // goes from 90 degrees "neutral" to 130 degrees "foward speed"
  {                                  // in steps of 20 degree 
    myservo1.write(pos);              // tell esc to go to position in variable 'pos' 
    delay(30000);                       // waits 30 seconds for the esc to reach the position 
  } 
  for(pos = 130; pos > 90; pos-= 20)     // goes from 130 degrees "foward speed" to 90 degrees "neutral" 
  {                                    // in steps of 20 degree
    myservo1.write(pos);              // tell esc to go to position in variable 'pos' 
    delay(30000);                       // waits 30 seconds for the esc to reach the position 
  } 
//------------------------------SERVO STEERING------------------------------------------------------------------------------  
  for(pos = 0; pos < 180; pos += 20)  // goes from 0 degrees to 180 degrees 
  {                                  // in steps of 20 degree 
    myservo2.write(pos);              // tell servo to go to position in variable 'pos' 
    delay(5000);                       // waits 5 seconds for the servo to reach the position 
  } 
  for(pos = 180; pos>=0; pos-= 20)     // goes from 180 degrees to 0 degrees 
  {                                  // in steps of 20 degree 
    myservo2.write(pos);              // tell servo to go to position in variable 'pos' 
    delay(5000);                       // waits 15ms for the servo to reach the position 
  } 
}

thanks again

2

Well, most (if not all) of the comments on the "for" loops are wrong.
That may be relevant.

Did you remember to wait long enough for the servo to move?

3

what do you mean "(for) comments are all wrong" are you referring to the explanation of the lines that start with (for) or is it the code it self

4

wait i think i understand by removing "for" the line is still true , really i don't need to be running a loop inside a loop kinda thing , right?

5

No, I'm saying what the code does, does not agree with what the comment says.
The clue is in the end condition of the loop, and what gets written to the servo or ESC object.

Example: for(pos = 90; pos < 130; pos += 20)  // goes from 90 degrees "neutral" to 130 degrees "foward speed"
You might think from the comment that the values 90, 110 and 130 are written to the servo object, but in fact, the values written are 90 and 110, simply because 110 + 20 is NOT less than 130.
As I said, this may or not be important to the correct functioning of the device, but it could confuse someone at a first reading.

6

got it
thanks so very much XD

7

almost forgot, i did run the code again and this time i waited longer as advised, and yes the servo did activate it just took it a little bit longer than i expected