RTCTime and getMinutes() programming problem

Projects Programming
1

Can someone please tell me what I am doing wrong here. This for an Arduino Uno R4 using the embedded RTC.

  RTCTime currentTime;
  RTC.getTime(currentTime);
  Serial.println(currentTime.getMinutes());
  if (currentTime.getMinutes() % LOG_INTERVAL == 0) Serial.println("hello");

I have reduced the code down to the minimum to try and work out what is wrong but it always fails on "Compilation error: expected primary-expression before '==' token"

2

Should that be

if ((currentTime.getMinutes() % LOG_INTERVAL) == 0) Serial.println("hello");
3

How is this defined? You left that detail out of your snippet...

5

No, the extra brackets are not needed, % has a higher precedence than ==

@johnboldon how is LOG_INTERVAL defined?

6

Thanks for your suggestion. Actually I have tried all combinations of brackets.
Your version fails with "Compilation error: expected primary-expression before ')' token" It seems to me that it's the "primary-expression" which is the problem.

7

Maybe not needed, but it makes the intention of the code more obvious. Albeit, it is not the problem in this case

8

Thank you so much all. That was the problem. I had
#define LOG_INTERVAL
instead of
#define LOG_INTERVAL 15
Thanks again. I just couldn't see the problem which should have hit me in the face!

9

Not sure if will work correctly, tho. The condition will be true for a full 60 seconds, which could result in multiple updates to the log, unless you use millis() or delay() ( :face_with_peeking_eye: ) to avoid that.

10

You are right of course. I had cut down the sample of code as I was focussed on why the if wasn't working. My stupid mistake!
This is how the code is going to be structured.

if (currentTime.getMinutes() % LOG_INTERVAL == 0) {
    if (!logged) {

      //Log data
      //logFile.print(currentTime);
      //logFile.print(",");
      //logFile.println(Temperature);
      //logFile.flush();
      Serial.print(currentTime);
      Serial.print(",");
      Serial.println(Temperature);
      logged = true;
    }
  } else {
    logged = false;
  }

Thanks again!

11

This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.