Welcome to the community.
As for your schematic it is fully functional. Good work !
I don't look at some of the design decisions as wrong however many feel there are better choices which usually come with experience.
For a useless box, it will function. However as noted by other posters (above) it will likely use batteries faster than need be.
For instance, R1 will work fine, however the processor has the ability to do the same function with an internal "resistor". This will eliminate R1 and the V+ wire to the switch. The switch will now be grounded or Open.