Oh I think I may have sorted it out.
It seems that the error was because I initialized the string as "" so there was no length to it. When the serial event ran the first time it sometimes has no data for some reason and its length is 0, the function then tries to take off the carriage return by subtracting one and is left with -1 which causes an error.
I think, maybe. Thanks for the help!