Good function names consist of a noun and a verb. digitalRead(), for instance. Crappy names consist of random letters. There is nothing in the name of this function that tells me what it does. The same holds true for datas() and movement().
My functions are for clean code, so when I'm in my main loop I'm not troubled by seeing all that code. It's just nicely tucked away.
But thank you, I do try when it is important to.
This is small enough code. And I know what the meanings are, and look at the code really quick you will see too.
I'd rather call a quick simple sonic() or datas() than functionForCleanCodeForGettingTheMeasurmentFromTheUltrasonicSensor() or functionForCleanCodeForAquirringTheDataIntoVariablesFromTheSensors(). Pardon my sarcasm.
And also it does. datas() ? collecting data from the sensors. sonic ? doing the calculations for the ultrasonic sensor. movement ? makes and controls the movement of the rover.
The last sample is not anything derived from millis(). The lastSampleTime is. Meaningful names are important.
I like lastSample. I use last sample. Just like in an array, I use res (resolution) for the amount of variables in the array. And again, it's shorter.
There is no excuse for this function not returning a value.
Please elaborate why it would need to return anything? And why any of it is a problem. I do not know what you mean. Why is returning it any better than just putting the value into the varible directly in the function.
digitalRead() doesn't store data in a global variable. Your function shouldn't, either. digitalRead() doesn't presume to know what pin to use. Your function shouldn't either.
Explain here too please. I thought (and see) globalVariableExample = digitalRead(meaningfulNamePin); store it into the global variable. Why is storing data into global variables inside functions bad? And what do mean "Your function shouldn't either."
Please elaborate and be clear otherwise your advise has very little meaning to me...
There is NO benefit in using one Serial.print() statement over using 13 Serial.print() statements. In fact, pissing away resources on all those String instances costs more time and memory.
And I add them all in one because that's the only way I know to determine what is what in processing, because in processing I will split it every ", " into a separate variable in an array.
If you know a better way please tell me as I do not know how, to determine one incoming value from another.