servo with encoder

hey i made a servo move by moving an encoder, havent seen a decent tutorial on how to do it so this is how i made it

/* Read Quadrature Encoder
  * Connect Encoder to Pins encoder0PinA, encoder0PinB, and +5V.
  *
  * Sketch by max wolf / www.meso.net
  * v. 0.1 - very basic functions - mw 20061220
  *
  */  

#include <Servo.h>
 Servo myservo;
 int servoPin = 13;
 //From bildr article: http://bildr.org/2012/08/rotary-encoder-arduino/

int delayPeriod = 3;
//these pins can not be changed 2/3 are special pins
int encoderPin1 = 2;
int encoderPin2 = 3;

volatile int lastEncoded = 0;
volatile long encoderValue = 0;

long lastencoderValue = 0;

int lastMSB = 0;
int lastLSB = 0;

void setup() {
  Serial.begin (9600);
  myservo.attach (13);
  pinMode(servoPin, OUTPUT);
  pinMode(encoderPin1, INPUT); 
  pinMode(encoderPin2, INPUT);

  digitalWrite(encoderPin1, HIGH); //turn pullup resistor on
  digitalWrite(encoderPin2, HIGH); //turn pullup resistor on

  //call updateEncoder() when any high/low changed seen
  //on interrupt 0 (pin 2), or interrupt 1 (pin 3) 
  attachInterrupt(0, updateEncoder, CHANGE); 
  attachInterrupt(1, updateEncoder, CHANGE);

}

void loop(){ 
  //Do stuff here

  Serial.println(encoderValue);
  
}


void updateEncoder(){
  int MSB = digitalRead(encoderPin1); //MSB = most significant bit
  int LSB = digitalRead(encoderPin2); //LSB = least significant bit

  int encoded = (MSB << 1) |LSB; //converting the 2 pin value to single number
  int sum  = (lastEncoded << 2) | encoded; //adding it to the previous encoded value

  if(sum == 0b1101 || sum == 0b0100 || sum == 0b0010 || sum == 0b1011) encoderValue ++;
  if(sum == 0b1110 || sum == 0b0111 || sum == 0b0001 || sum == 0b1000) encoderValue --;

  lastEncoded = encoded; //store this value for next time
  
  
     
   // in steps of 1 degree 
   if( encoderValue > 0){
      --encoderValue;
    myservo.write(encoderValue);              // tell servo to go to position in variable 'pos' 
    delay(delayPeriod);                      
  } 
                            
   if( encoderValue < 180){
       ++encoderValue;
    myservo.write(encoderValue);              // tell servo to go to position in variable 'pos' 
    delay(delayPeriod);        
  }
}

http://bildr.org/2012/08/rotary-encoder-arduino/

The code you posted is from the above tutorial .
Unless you are the author, you didn't make it.

raschemmel:

http://bildr.org/2012/08/rotary-encoder-arduino/

The code you posted is from the above tutorial .
Unless you are the author, you didn't make it.

The code in your link has no servo code included in it. Perhaps you need to revisit your link for another look.

The code in your link has no servo code included in it. Perhaps you need to revisit your link for another look.

My mistake. Your right . There is no servo code at that link.