Speed control not working correctly with Potentiometer

5k is fine.

As TomGeorge said, you need to adapt your code for each pot.
Each pot needs a zero point and two span ranges mapped to 0-255.

Start with simple code that reads the A/D value of the pot.
Find the A/D value of the center position.
Find the values of the two extremes.
Pick a dead-band range, e.g. +/- 8.
Map the two spans you have to 0-255.
Leo..

#include <AFMotor.h>

AF_DCMotor motor1(4); //H-Bridge Ch 4
AF_DCMotor motor4(1); //H-Bridge Ch 1
AF_DCMotor Laser(2); //H-Bridge Ch 2


const int y = A4;
const int x = A5;

int y1 = 0; //speed of y "pitch" axis
int y2 = 0; //Raw Anaogue in of y Pot
int x1 = 0; //Speed of x "yaw" axis
int x2 = 0; //Raw analogue in of x pot
int y3 = 0; //Forward Speed Map (Y axis)
int y4 = 0; //Backwards Speed Map (Y axis)
int x3 = 0; //Forward Speed Map (X axis)
int x4 = 0; //Backwards Speed Map (X axis)

void setup()
{
    pinMode(y2, INPUT);
    pinMode(x2, INPUT);
    // initialize serial communications at 9600 bps:
  Serial.begin(9600);
}

void loop()
{
  //Motor Directions as Specified in AFMotor.h
   int a = FORWARD; 
   int b = BACKWARD;
   int c = RELEASE; //Motor brake

   {
   
  y2 = analogRead(y);
  y1 = map(y2, 300, 600, 0, 255);
  y3 = map(y1, 140, 0, 0, 255);
  y4 = map(y1, 160, 0, 0, -255);
  
   //Point down
   if(y1 < 140)
   {
    motor4.setSpeed(y3);
    motor4.run(b);
   
   }
   //Point Up
    else if (y1 > 160)
    {
      motor4.setSpeed(y4);
      motor4.run(a);
 
    }
    //Brake
    else {
      motor4.setSpeed(0);
      motor4.run(c);

    }
    {
      x2 = analogRead(x);
      x1 = map(x2, 400, 700, 0, 255);
      x3 = map(x1, 130, 0, 0, 255);
      x4 = map(x1, 150, 0, 0, -255);
      
         //Point Left
   if(x1 < 130)
   {
    motor1.setSpeed(x3);
    motor1.run(b);
   
   }
   //Point Right
    else if (x1 > 150)
    {
      motor1.setSpeed(x4);
      motor1.run(a);
 
    }
    //Brake
    else {
      motor1.setSpeed(0);
      motor1.run(c);
    }
    
    {
        // read the input on analog pin 3:
  int sensorValue = analogRead(A3);
  // Convert the analog reading (which goes from 0 - 1023) to a voltage (0 - 5V):
  float voltage = sensorValue * (5.0 / 1023.0);
  {

    
  if (voltage > 3) // Activates Laser Pointer when switch is triggered
  {
  Laser.setSpeed(150);
  Laser.run(b);
  }
  else 
  {
  Laser.run(c);
    }
  }
    }
// print the results to the serial monitor:
  Serial.print("\t y 2 = ");
  Serial.print(y2);
  Serial.print("\t y 1 = ");
  Serial.println(y1);
  Serial.print("\t y3 = ");
  Serial.print(y3);
  delay(2);

    }
      
    }
}

Thankyou both for all your Help this is what your meaning yeah? it works now perfectly with your suggestions

Example.
If you mechanically adjust/rotate the pot, so that the center postion of the joystock is about A/D value 512.
And you want a +/- 8 deadband.
And the pot extremes are 100 and 923.

potRaw = analogRead(A4);
goleft = map(potRaw, 508, 100, 0, 255);
goright = map(potRaw, 520, 923, 0, 255);

Leo..

Wawa:
Example.
If you mechanically adjust/rotate the pot, so that the center postion of the joystock is about A/D value 512.
And you want a +/- 8 deadband.
And the pot extremes are 100 and 923.

potRaw = analogRead(A4);
goleft = map(potRaw, 508, 100, 0, 255);
goright = map(potRaw, 520, 923, 0, 255);

Leo..

Thanks so much for your help Leo So are you suggesting I close up the dead band from 20 down to 8 yeah? cause the Pot extremes aren't reached when its assembled so I'm having to account for this in the code..