Start and Stop Stepper with Accel Library

That's an argument against using relayState = !relayState, rather than against using that expression in the arguments to a function call.

There's nothing fundamentally wrong (IMO) in using expressions that modify variables in a function call.