Two Button Tie - Computers dont "do" Tie

Projects Programming
1

I have written code to execute a special action in the event two buttons become pressed within a defined "tie" parameter (in this case 1 second). Can this be done better?

//TWO BUTTONS - How to define and act upon a Tie


const int button1 = 2;
const int button2 = 3;


const int buttonDelay = 300;   // button bounce mitigation

unsigned long buttonTime = 0;   // button bounce mitigation

byte button1State = 0;   //variable and initial state for Tie
byte button2State = 0;

byte tieState = 0;   //variable to trigger Tie action

const int tieDelay = 1000;   // button bounce mitigation

unsigned long tieTime = 0;   // button bounce mitigation


void setup()
{
  
   pinMode(button1, INPUT_PULLUP);   // pushbutton pins are high and use built-in resistor
   pinMode(button2, INPUT_PULLUP);

}


void loop()
{

   // read buttons and set buttonStates

   if (millis() - buttonTime >= buttonDelay)   // button bounce mitigation
   {
      if (digitalRead(button1) == LOW)    // button1 is pressed
      {
      button1State = 1;       
      }
   }

   if (millis() - buttonTime >= buttonDelay)   // button bounce mitigation
   {
      if (digitalRead(button2) == LOW)    // button2 is pressed
      {
      button2State = 1;       
      }
   }
   
   if ((button1State == 1) && (button2State == 1))
   {
   tieState = 1;
   }

   
   // action if only button1 pressed after a second

   if (millis() - tieTime >= tieDelay)   // second to check for tie
   {
      if (millis() - buttonTime >= buttonDelay)   // button bounce mitigation
      {
         if ((button1State == 1) && (tieState = 0))    // button1 is pressed
         {

	   //Put button1 action here
      
         button1State = 0;
         button2State = 0;
         tieState = 0;
         buttonTime >= buttonDelay;
         tieTime >= tieDelay;
         }
      }
   }
   
 
  // action if only button2 pressed after a second
   
   if (millis() - tieTime >= tieDelay)   // second to check for tie
   {
      if (millis() - buttonTime >= buttonDelay)   // button bounce mitigation
      {
         if ((button2State == 1) && (tieState = 0))    // button2 is pressed
         {

	   //Put button2 action here
      
         button1State = 0;
         button2State = 0;
         tieState = 0;
         buttonTime >= buttonDelay;
         tieTime >= tieDelay;
         }
      }
   }


  // action in the event of a tie 
   
   if (tieState = 1)    // tie is recorded
   {

     //Put tie action here
      
    button1State = 0;
    button2State = 0;
    tieState = 0;
    buttonTime >= buttonDelay;
    tieTime >= tieDelay;
   }
}
2 
         if ((button1State == 1) && (tieState = 0))    // button1 is pressed

It's unusual to see an assignment in an if statement.

You need to completely restructure the code. Look at the state change detection example. You need to record when each switch BECOMES pressed, and then, if both are pressed, determine the interval (positive or negative) between the events.

3

Typo. Should be single = (assignment operator)

4

mchandeysson:
Typo. Should be single = (assignment operator)

Wrong. There should be two == in that statement.

5

Even better. Please don't facepalm. You're really helping.

6 
 if ((button1State == 1) && (tieState = 0))

The expression in this if() statement will never evaluate to true and the block will never get executed.