Updating the mighty-1284p core

pico:
The digital_pin_to_pcint[] array is defined in pins_arduino.h, but for only the "bobuino" variant. Because it's an array, and pins_arduino.h is potentitally pulled into multiple libs, the declaration is guarded by a #ifdef ARDUINO_MAIN, so the linker doesn't complain about multiple declarations..

Changing this so that

#ifndef ARDUINO_MAIN
extern const uint8_t digital_pin_to_pcint[];
#else
const uint8_t digital_pin_to_pcint[NUM_DIGITAL_PINS] =
:
#endif

will work just as well, and has the advantage of not needing a patched version of SoftwareSerial, so I will make that change, and then we can remove the patched SoftwareSerial lib from the repo.

Very nice. Somehow I missed that conditional.
That will remove that collision with the Teensy SoftSerial patches.

But sorry, Bill, your hand-wringing and finger-wagging here leaves me as unmoved now as it ever has. :grin:

I might be wringing my hands but definitely not wagging my fingers... :slight_smile:

I think many of the library issues can go away on 1.5x as each core can have its own libraries.
I need to verify that a core library trumps a common library the same way that a user sketchbook library
trumps a common library.
Assuming it does, that will make things really nice as the core can ship with
all the core specific/patched libraries already in place ready to go so it becomes a nice simple install.

And if it doesn't, that is something that we need to work with the Arduino team to
get changed/fixed in the 1.5x IDE before it finalizes.

--- bill