int valclub = map(analogRead(clubPin), 0, 1023, 0, 255);
The map function is overkill for dividing a value by 4.
delay(10);
Why?
The Arduino is firing off a steady stream of values, every 10 milliseconds. It seems to me that you would want to send a value only when the value signified that an event occurred, like the ball was hit or the ball hit the cup. Of course, you would then need some way for Processing to distinguish what those values meant. Perhaps, it would be better if the club sent a letter, like 'W' whenever it whacked a ball, and the cup would send a 'C' when it caught the ball (if there is only one cup, or a number (different for each cup) if there is more than one cup)).
Your Processing sketch needs some work, too.
float[] colors = float(split(inString, ","));
The string being sent by the Arduino now consists of a single int. Why are you converting this to an array of floats?