Watch on off

sbstout · November 18, 2018, 4:55pm

hello someone can help. I'm having trouble with the lines.

if (now.hour == OnHour && now.minute == OnMin){
digitalWrite(Relay,HIGH);
Serial.println("LIGHT ON");
}
else if (now.hour == OffHour && now.min == OffMin){
digitalWrite(Relay,LOW);
Serial.println("LIGHT OFF");

I must be doing something wrong. thank you

// Date and time functions using a DS3231 RTC connected via I2C and Wire lib
#include <Wire.h>
#include "RTClib.h"

RTC_DS3231 rtc;

char daysOfTheWeek[7][12] = {"Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"};

const int OnHour = 12;
const int OnMin = 24;
const int OffHour = 12;
const int OffMin = 25;
int Relay = 9;

void setup () {

#ifndef ESP8266
while (!Serial); // for Leonardo/Micro/Zero
#endif

pinMode(Relay, OUTPUT);

Serial.begin(9600);

delay(3000); // wait for console opening

if (! rtc.begin()) {
Serial.println("Couldn't find RTC");
while (1);
}

if (rtc.lostPower()) {
Serial.println("RTC lost power, lets set the time!");
// following line sets the RTC to the date & time this sketch was compiled
rtc.adjust(DateTime(F(DATE), F(TIME)));
// This line sets the RTC with an explicit date & time, for example to set
// January 21, 2014 at 3am you would call:
// rtc.adjust(DateTime(2014, 1, 21, 3, 0, 0));
}
}

void loop () {
DateTime now = rtc.now();

Serial.print(now.year(), DEC);
Serial.print('/');
Serial.print(now.month(), DEC);
Serial.print('/');
Serial.print(now.day(), DEC);
Serial.print(" (");
Serial.print(daysOfTheWeek[now.dayOfTheWeek()]);
Serial.print(") ");
Serial.print(now.hour(), DEC);
Serial.print(':');
Serial.print(now.minute(), DEC);
Serial.print(':');
Serial.print(now.second(), DEC);
Serial.println();

if (now.hour == OnHour && now.minute == OnMin){
digitalWrite(Relay,HIGH);
Serial.println("LIGHT ON");
}
else if (now.hour == OffHour && now.min == OffMin){
digitalWrite(Relay,LOW);
Serial.println("LIGHT OFF");
}
delay(3000);
}
}

el_supremo · November 18, 2018, 5:01pm

I must be doing something wrong

Yep. You didn't post your code in code tags - read How to post code properly and then use the </> icon to create [code]...[/code] tags around your code so that it is easier to read.

You also didn't explain what "having trouble" means. Could you be at least a little less vague?

Pete

jremington · November 18, 2018, 5:07pm

Please edit your post to add code tags.

UKHeliBob · November 18, 2018, 7:40pm

I'm having trouble with the lines.

Can you be more explicit about the trouble that you are having ?

sbstout · November 19, 2018, 1:05pm

Thanks for the interest and sorry the inexperience will attach the error
Thank you for your cooperation.

// Date and time functions using a DS3231 RTC connected via I2C and Wire lib
#include <Wire.h>
#include "RTClib.h"

RTC_DS3231 rtc;

char daysOfTheWeek[7][12] = {"Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"};

const int OnHour = 12;
const int OnMin = 24;
const int OffHour = 12;
const int OffMin = 25;
int Relay = 9;

void setup () {

#ifndef ESP8266
while (!Serial); // for Leonardo/Micro/Zero
#endif

pinMode(Relay, OUTPUT);

Serial.begin(9600);

delay(3000); // wait for console opening

if (! rtc.begin()) {
Serial.println("Couldn't find RTC");
while (1);
}

if (rtc.lostPower()) {
Serial.println("RTC lost power, lets set the time!");
// following line sets the RTC to the date & time this sketch was compiled
rtc.adjust(DateTime(F(DATE), F(TIME)));
// This line sets the RTC with an explicit date & time, for example to set
// January 21, 2014 at 3am you would call:
// rtc.adjust(DateTime(2014, 1, 21, 3, 0, 0));
}
}

void loop () {
DateTime now = rtc.now();

Serial.print(now.year(), DEC);
Serial.print('/');
Serial.print(now.month(), DEC);
Serial.print('/');
Serial.print(now.day(), DEC);
Serial.print(" (");
Serial.print(daysOfTheWeek[now.dayOfTheWeek()]);
Serial.print(") ");
Serial.print(now.hour(), DEC);
Serial.print(':');
Serial.print(now.minute(), DEC);
Serial.print(':');
Serial.print(now.second(), DEC);
Serial.println();

  if (now.hour == OnHour && now.minute == OnMin){
    digitalWrite(Relay,HIGH);
    Serial.println("LIGHT ON");
    }
else if (now.hour == OffHour && now.min == OffMin){
      digitalWrite(Relay,LOW);
      Serial.println("LIGHT OFF");

}
delay(3000);
}
}

system · November 19, 2018, 1:07pm

The idea is that the code tags should enclose your code.

I don't want to download an image - post the TEXT of the error message.

sbstout · November 19, 2018, 2:00pm

Sorry for any it's the first time I use the forum, hopefully now make me understand there's about the compilation error

// Date and time functions using a DS3231 RTC connected via I2C and Wire lib
#include <Wire.h>
#include "RTClib.h"

RTC_DS3231 rtc;

char daysOfTheWeek[7][12] = {"Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"};

const int OnHour = 12;
const int OnMin = 24;
const int OffHour = 12;
const int OffMin = 25;
int Relay = 9;

void setup () {

#ifndef ESP8266
while (!Serial); // for Leonardo/Micro/Zero
#endif

pinMode(Relay, OUTPUT);

Serial.begin(9600);

delay(3000); // wait for console opening

if (! rtc.begin()) {
Serial.println("Couldn't find RTC");
while (1);
}

if (rtc.lostPower()) {
Serial.println("RTC lost power, lets set the time!");
// following line sets the RTC to the date & time this sketch was compiled
rtc.adjust(DateTime(F(DATE), F(TIME)));
// This line sets the RTC with an explicit date & time, for example to set
// January 21, 2014 at 3am you would call:
// rtc.adjust(DateTime(2014, 1, 21, 3, 0, 0));
}
}

void loop () {
DateTime now = rtc.now();

Serial.print(now.year(), DEC);
Serial.print('/');
Serial.print(now.month(), DEC);
Serial.print('/');
Serial.print(now.day(), DEC);
Serial.print(" (");
Serial.print(daysOfTheWeek[now.dayOfTheWeek()]);
Serial.print(") ");
Serial.print(now.hour(), DEC);
Serial.print(':');
Serial.print(now.minute(), DEC);
Serial.print(':');
Serial.print(now.second(), DEC);
Serial.println();

 if (now.hour == OnHour && now.minute == OnMin){
    digitalWrite(Relay,HIGH);
    Serial.println("LIGHT ON");
    }
else if (now.hour == OffHour && now.minute == OffMin){
      digitalWrite(Relay,LOW);
      Serial.println("LIGHT OFF");

}
delay(3000);
}

Error

In function 'void loop()':

teste_comedouro:62:21: error: invalid use of member function (did you forget the '()' ?)

if (now.hour == OnHour && now.minute == OnMin){

^

teste_comedouro:66:22: error: invalid use of member function (did you forget the '()' ?)

else if (now.hour == OffHour && now.minute == OffMin){

^
^

exit status 1
invalid use of member function (did you forget the '()' ?)

Este relatório teria mais informação com a
opção «Mostrar mensagens detalhadas durante a
compilação» seleccionada nas Preferências.

system · November 19, 2018, 2:04pm

: invalid use of member function (did you forget the '()' ?)

Well, did you?

UKHeliBob · November 19, 2018, 2:05pm

 Serial.print(now.hour(), DEC);

This presumably prints the hour

if (now.hour == OnHour && now.minute == OnMin)

Spot the difference in calling the function to get the hour, and minute come to that

sbstout · November 19, 2018, 2:21pm

If you are printing the time, I used the "if" to make a comparison with the clock and the value declared in "OnHour" and OnMin to make the relay work

Topic		Replies	Views
RTC 3231 problem Networking, Protocols, and Devices	5	4512	May 6, 2021
RTC Programming Programming Questions	3	625	May 5, 2021
Time will not set correctly on RTC Project Guidance	13	62312	May 5, 2021
IF Statements RTC Programming Questions	7	1316	November 2, 2022
Ds3231 on time off time into next day Programming Questions	28	2355	June 26, 2022

Watch on off

Related Topics