What is wrong. Solved.

Using Arduino Programming Questions
1

What is wrong.

int sensorPinC = A2;
int sensorPinA = A0;
int sensorPinB = A1;
int sensorPinD = A3;// select the input pin for the potentiometer
int SPEACKER = 4;
int sensorValue = 0; // variable to store the value coming from the sensor

void setup() {
pinMode(SPEACKER, OUTPUT);

}

void loop()

{

noTone(4);

sensorValue = analogRead(sensorPinA);

{tone(4, 93, 58);
while (sensorValue < 500);
delay (100);}

noTone(4);

sensorValue = analogRead(sensorPinB);

{ tone(4, 523, 400);
while (sensorValue < 500);
delay (100); }

noTone(4);

sensorValue = analogRead(sensorPinC);

{tone(4, 49, 80);

while (sensorValue < 500);
delay (100);}

noTone(4);

sensorValue = analogRead(sensorPinD);

{tone(4, 104, 139);
if (sensorValue < 500);
delay (100);}

}

2

Where does the setup() function end?

3

Why did you delete your other post? You are making the same mistakes that you did before. The other post had a ton of feedback on how to fix your code, yet you delete it and start a new thread with the same mistakes...

4

I fixed that problem now what is wrong.

5

Sorry I am new to this I never have been on a forum before now not even Facebook.

6

No problem. Gotta start somewhere!

Not even sure why they let you delete your own posts.. Never seen a forum have that option for regular members..

Take a look at this page. It will get you familiar with the syntax.

7

Cant figure it out.

8

naturbot:
I fixed that problem now what is wrong.

You don't end your setup function, as was already indicated above.

9

O I was looking at my other code that I fixed I did not update this though.

10

naturbot:
O I was looking at my other code that I fixed I did not update this though.

So you have code that you have fixed, but it's still "not working" and you aren't going to post it?

If you want help, then you need to post your LATEST code in CODE tags, explain what you are wanting it to do, and explain what it is doing now.

11

I just did.

12

naturbot:
I just did.

Try doing it without the invisible ink.. err pixels, because I don't see any CODE tags or explanations anywhere.

13

I thought that adding the other curly bracket would fix it.

14

naturbot:
I thought that adding the other curly bracket would fix it.

Fix what? What problem are you having? The latest code that you edited in compiles fine for me so you're going to have to do more than saying "something is wrong"

If you're getting an error message post it. If the Arduino is not behaving how you want it, tell us how it's behaving and how you want it to behave. I can spot a few common errors in your sketch that won't throw a compiler error but will likely make it not run as desired, but I'm waiting to here what you are trying to do before I give suggestions on how to fix it.

15

I am using a anolog joystick to try to play different notes but it plays the same note over and over again. and that is the code that I just updated.

16

There is no error mesage it complies fine with me too.

17

naturbot:
I am using a anolog joystick to try to play different notes but it plays the same note over and over again. and that is the code that I just updated.

That's because of what you put here:

  sensorValue = analogRead(sensorPinA);
     
    tone(4, 93, 58);
     while (sensorValue < 500);

If the sensorValue is less than 500, then it won't get past that last line of code because you never update sensorValue.

18

I got to go or my parents will punish me severely.

19

naturbot:
I got to go or my parents will punish me severely.

Hopefully it's not for playing around with an Arduino, otherwise it's a bad indication of what society has come to.

20

No it is not for playing with the arduino. I just had to get up this morning to clean the house with my sisters.
I won't be back till Friday because I have been grounded from the arduino my parents think it is a distraction from school and chores because it is all I do in my free time.