Code problem with LED

Hello,

I've got a Adafruit wave shield attached to a PIR sensor. I got that working so I added a LED, so that when the sensor senses motion the LED lights up as well. When I added the extra code for the LED it comes up with errors.

Heres the LED code:

val = digitalRead(pirState); //read input and store it

//check whether the input is HIGH
if (val ==HIGH) {
digitalWrite(ledPin, HIGH); // Turns the LED on
if (pirState == HIGH) {

} else {
digitalWrite(ledPin, LOW); // turns the LED off
if (pirState == LOW) {

Heres the error messages:

Draft.cpp: In function 'void loop()':
Draft:147: error: a function-definition is not allowed here before '{' token
Draft:182: error: expected }' at end of input Draft:182: error: expected }' at end of input
Draft:182: error: expected `}' at end of input

Also, if you need it heres my whole sketch:

#include <FatReader.h>
#include <SdReader.h>
#include <avr/pgmspace.h>
#include "WaveUtil.h"
#include "WaveHC.h"


SdReader card;    // This object holds the information for the card
FatVolume vol;    // This holds the information for the partition on the card
FatReader root;   // This holds the information for the filesystem on the card
FatReader f;      // This holds the information for the file we're play

uint8_t dirLevel; // indent level for file/dir names    (for prettyprinting)
dir_t dirBuf;     // buffer for directory reads

WaveHC wave;      // This is the only wave (audio) object, since we will only play one at a time

// for PIR
  int ledPin = 16;                 // choose the pin for the LED
  int inputPin = 14;               // choose the input pin (for PIR sensor)
  int pirState = LOW;             // we start, assuming no motion detected
  int val = 0;                    // variable for reading the pin status
  
#define LED 16  // LED connected to
                // digital pin 16

#define DEBOUNCE 100  // button debouncer

// this handy function will return the number of bytes currently free in RAM, great for debugging!   
int freeRam(void)
{
  extern int  __bss_end; 
  extern int  *__brkval; 
  int free_memory; 
  if((int)__brkval == 0) {
    free_memory = ((int)&free_memory) - ((int)&__bss_end); 
  }
  else {
    free_memory = ((int)&free_memory) - ((int)__brkval); 
  }
  return free_memory; 
} 

void sdErrorCheck(void)
{
  if (!card.errorCode()) return;
  putstring("\n\rSD I/O error: ");
  Serial.print(card.errorCode(), HEX);
  putstring(", ");
  Serial.println(card.errorData(), HEX);
  while(1);
}

void setup() {
  // set up serial port
  Serial.begin(9600);
  putstring_nl("WaveHC with 6 buttons");
  randomSeed(analogRead(1));
  
   putstring("Free RAM: ");       // This can help with debugging, running out of RAM is bad
  Serial.println(freeRam());      // if this is under 150 bytes it may spell trouble!
  
  // Set the output pins for the DAC control. This pins are defined in the library
  pinMode(2, OUTPUT);
  pinMode(3, OUTPUT);
  pinMode(4, OUTPUT);
  pinMode(5, OUTPUT);
  
  pinMode(16, OUTPUT);
  digitalWrite(16, HIGH);
  
  pinMode(LED, OUTPUT);   // sets the digital
                            // pin at output

  //  if (!card.init(true)) { //play with 4 MHz spi if 8MHz isn't working for you
  if (!card.init()) {         //play with 8 MHz spi (default faster!)  
    putstring_nl("Card init. failed!");  // Something went wrong, lets print out why
    sdErrorCheck();
    while(1);                            // then 'halt' - do nothing!
  }
  
  // enable optimize read - some cards may timeout. Disable if you're having problems
  card.partialBlockRead(true);

// Now we will look for a FAT partition!
  uint8_t part;
  for (part = 0; part < 5; part++) {     // we have up to 5 slots to look in
    if (vol.init(card, part)) 
      break;                             // we found one, lets bail
  }
  if (part == 5) {                       // if we ended up not finding one  :(
    putstring_nl("No valid FAT partition!");
    sdErrorCheck();      // Something went wrong, lets print out why
    while(1);                            // then 'halt' - do nothing!
  }
  
  // Lets tell the user about what we found
  putstring("Using partition ");
  Serial.print(part, DEC);
  putstring(", type is FAT");
  Serial.println(vol.fatType(),DEC);     // FAT16 or FAT32?
  
  // Try to open the root directory
  if (!root.openRoot(vol)) {
    putstring_nl("Can't open root dir!"); // Something went wrong,
    while(1);                             // then 'halt' - do nothing!
  }
  
  // Whew! We got past the tough parts.
  putstring_nl("Ready!");
}

void loop() {
  //putstring(".");            // uncomment this to see if the loop isnt running
  switch (check_switches()) {
    case 1:
      playcomplete("OLDPIN.WAV");
      break;
    case 2:
      playcomplete("JCBSNG.WAV");
      break;
    case 3:
      playcomplete("INEDNS.WAV");
      break;
    case 4:
      playcomplete("LLMAFS.WAV");
      break;
    case 5:
      playcomplete("SKLEBI.WAV");
      break;
    case 6:
      playcomplete("DOTPAL.WAV");
  
val = digitalRead(pirState); //read input and store it

//check whether the input is HIGH
if (val ==HIGH) {
  digitalWrite(ledPin, HIGH);  // Turns the LED on
  if (pirState == HIGH) {
    
} else {
  digitalWrite(ledPin, LOW);   // turns the LED off
  if (pirState == LOW) {

  }
}

byte check_switches()
{
  if (digitalRead(14) == HIGH)  // check for high signal on pin 14 (analog 0)
    {
       return random(1,6);
    }
  return 0;
}


// Plays a full file from beginning to end with no pause.
void playcomplete(char *name) {
  // call our helper to find and play this name
  playfile(name);
  while (wave.isplaying) {
  // do nothing while its playing
  }
  // now its done playing
}

void playfile(char *name) {
  // see if the wave object is currently doing something
  if (wave.isplaying) {// already playing something, so stop it!
    wave.stop(); // stop it
  }
  // look in the root directory and open the file
  if (!f.open(root, name)) {
    putstring("Couldn't open file "); Serial.print(name); return;
  }
  // OK read the file and turn it into a wave object
  if (!wave.create(f)) {
    putstring_nl("Not a valid WAV"); return;
  }
  
  // ok time to play! start playback
  wave.play();
}

i'm new to coding so any help I would really appreciate it.

You have miss matched { }.
I suspect you are one } short at the end of your loop()

To check, move the pointer to just after the brace and click, you will see the matching brace in a box.
When you do you will find the last brace in the loop() function matches the last else. Therefore the compiler thinks you are trying to define a function inside the loop() function, that is what it is telling you.

Thank you, It's working!!

hmm.... But for some reason the LED is always on. I only want it to come on when the PIR sensor senses motion. I thought I coded it right :frowning:

val = digitalRead(pirState); //read input and store it

//check whether the input is HIGH
if (val ==HIGH) {
  digitalWrite(ledPin, HIGH);  // Turns the LED on
  if (pirState == HIGH) {
    
} else {
  digitalWrite(ledPin, LOW);   // turns the LED off
  if (pirState == LOW) {

  }

This part of loop() is bogus. digitalRead expects an input pin as parameter - you use pirState, which is HIGH/LOW instead of inputPin. What you want is to read the state of the sensor and then set the LED accordingly. Just write the read state of the sensor to the LED:

pirState= digitalRead(inputPin);
digitalWrite(ledPin, pirState);

You need to post the sketch again now you have corrected it - we cannot see your correction!

Also the check_switches function (unless you have changed it!) appears to return values between 0 and 6. But your switch statement is a) incomplete with } missing, and b) does not cope with 0 or have a default value.

Thanks Marek080! :smiley:

For some reason the LED is still on all the time.

i'm really new to coding and do I need to add something to this code:

pirState= digitalRead(inputPin);
digitalWrite(ledPin, pirState);

I know you said before but I'm confused. Sorry if I sound like a idiot.

Thanks for all the help.

You need to post the exact code you are having trouble with to get useful help.

val = digitalRead(pirState); //read input and store it
..........
  if (pirState == HIGH) 

{

So you are using pirState to define a pin number in the first statement, this means it has to be a number.
In the if statement you are expecting pirState to be a logic value.
It can't be both.

Thanks for the reply

So if the pirState is only HIGH or Low and not a logic value. How would I change the if statement to reflect that?

  int inputPin = 14;               // choose the input pin (for PIR sensor)
  int pirState = LOW;             // we start, assuming no motion detected

Do you have an input connected to pin 14? No, you don't, at least not according to the comments. So the variable name is misleading, which appears to be the source of your problems.

Use a meaningful name, like pirPin. Then,

val = digitalRead(pirState); //read input and store it

Will be obvious that you are reading the wrong pin. In the () should be pirPin. val is useless, to. You really want:

pirState = digitalRead(pirPin);

Sorry, my PIR sensor is connected to PIN 14 (Analog 0) on my wave shield.

Sorry, my PIR sensor is connected to PIN 14 (Analog 0) on my wave shield.

So, it is not an "input" connected to that pin. More meaningful names make your programming life easier.