Combining programs and Lcd display

Projects General Guidance
1

Hello there, i'm currently working on this program, well...this is just a part of it. I'm trying to combine two programs and make it work.
What i'm aiming to do is that whenever the buttons are pressed, they will display how many times they are pressed. My first problem is that, while this program compiles with no error, it does not work as i want it to. In fact, nothing happens when i press the buttons. I'm also having problem with the display, can i do it in such a way that it can display something like this " hourr : minutes " ?
Thanks in advance.

void setup()
{
  void setupmain();
  void setup1();
  void setup2();
}

void loop()
{
  void loopmain();
  void loop1();
  void loop2();
}

//=========================
int switchPin1 =6; // choose the input pin (for a pushbutton)
int hourr = 0; // variable for reading the pin status
int val = 0;
int currentState = 0;
int previousState = 0;

void setup1() {
pinMode(switchPin1, INPUT); // declare pushbutton as input
}
void loop1(){
val = digitalRead(switchPin1); // read input value
if (val == HIGH) { // check if the input is HIGH (button released)
currentState = 1;
}
else {
currentState = 0;                
}
if(currentState != previousState){
if(currentState == 1){
hourr = hourr + 1;
hourr = min(hourr, 25);
if(hourr == 25)
  {
    hourr = hourr - 24;
  }     
}
}
previousState = currentState;
delay(250);
}
//============================
int switchPin2 =7; // choose the input pin (for a pushbutton)
int minutes = 0; // variable for reading the pin status

void setup2() {
pinMode(switchPin2, INPUT); // declare pushbutton as input
}
void loop2(){
val = digitalRead(switchPin2); // read input value
if (val == HIGH) { // check if the input is HIGH (button released)
currentState = 1;
}
else {
currentState = 0;                
}
if(currentState != previousState){
if(currentState == 1){
minutes = minutes + 1;
minutes = min(minutes, 61);
if(minutes = 61)
  {
    minutes = minutes - 60;
  }    
}
}
previousState = currentState;
delay(250);
}
//=================================
void setupmain()
{
  Serial.begin(9600);
}
void loopmain()
{
 void setup()
{
  void setupmain();
  void setup1();
  void setup2();
}

void loop()
{
  void loopmain();
  void loop1();
  void loop2();
}

//=========================
int switchPin1 =6; // choose the input pin (for a pushbutton)
int hourr = 0; // variable for reading the pin status
int val = 0;
int currentState = 0;
int previousState = 0;

void setup1() {
pinMode(switchPin1, INPUT); // declare pushbutton as input
}
void loop1(){
val = digitalRead(switchPin1); // read input value
if (val == HIGH) { // check if the input is HIGH (button released)
currentState = 1;
}
else {
currentState = 0;                
}
if(currentState != previousState){
if(currentState == 1){
hourr = hourr + 1;
hourr = min(hourr, 25);
if(hourr == 25)
  {
    hourr = hourr - 24;
  }     
}
}
previousState = currentState;
delay(250);
}
//============================
int switchPin2 =7; // choose the input pin (for a pushbutton)
int minutes = 0; // variable for reading the pin status

void setup2() {
pinMode(switchPin2, INPUT); // declare pushbutton as input
}
void loop2(){
val = digitalRead(switchPin2); // read input value
if (val == HIGH) { // check if the input is HIGH (button released)
currentState = 1;
}
else {
currentState = 0;                
}
if(currentState != previousState){
if(currentState == 1){
minutes = minutes + 1;
minutes = min(minutes, 61);
if(minutes = 61)
  {
    minutes = minutes - 60;
  }    
}
}
previousState = currentState;
delay(250);
}
//=================================
void setupmain()
{
  Serial.begin(9600);
}
void loopmain()
{
  Serial.println(hourr, minutes);
}  

}
2

Is it really necessary to have three functions called from setup() that each contain only one line of code?

void setup()
{
  void setupmain();
  void setup1();
  void setup2();
}

void setup1() {
pinMode(switchPin1, INPUT); // declare pushbutton as input
}

void setup2() {
pinMode(switchPin2, INPUT); // declare pushbutton as input
}

void setupmain()
{
  Serial.begin(9600);
}

Pick a style for the curly braces and stick with it. Do not use multiple styles.

You have two loopmain() functions, one embedded inside the other.

That code is a real mess. Ctrl-A and delete would be the best thing to do. Start over, paying attention to what you are pasting where.

3

Hi jsleh,

I'm really having a difficult time following the logic in your code snippet without explanatory comments and good indentation.

Please add some comments and then press T to fix the indentation.

You may wish to start a new sketch. Merging two together makes things confusing...

Out of curiosity, what happens if you do this (remove the voids):

void setup()
{
setupmain();
setup1();
setup2();
}

void loop()
{
loopmain();
loop1();
loop2();
}

4

Without the voids, i get an error. I think i will start over again and will definitely follow your advices.