Edit: Okay, maybe it's because I made my "period" integer WAY to high, but I can't go back to test my code at the moment. Regardless, thank you to those who responded Hello, I'm a student. I'm supposed to do an arduino project for a final class assignment. Mine's supposed to be one of those automated soil moisture projects. However, Despite not getting error messages anymore, it still doesn't seem to work how I want it to. The values I would get from a sensor would seem too low (you'll see it in the code), and the text doesn't appear in the serial monitor. Maybe its how I built it, I don't know. First is the code I used to get the values to put in my actual test code /* */ int sensorValue; int readPin = A0; void setup() { pinMode(readPin,INPUT); Serial.begin(9600); } void loop() { sensorValue = analogRead(readPin); delay(2000); //wait for voltage to settle Serial.println(sensorValue); } Then here's the test code /* */ const int Pin_D1 = 8; const int Hydro_D1 = 7; //hydro pump connect to plant of sensor 1 //Measure Soil Moisture Levels int Value_D1; int readPin = A0; //Measure time int delayTime = 100; int period = 3600000; unsigned long time_now = 0; //Measure Water Level int waterSensorPin = A1; int waterValue; //Water parameter const int waterThreshold = 320; //value for low water //Soil parameters const int dryWall = 350; //value for dry soil const int wetWall = 335; //value for wet soil void setup() { Serial.begin(9600); //serial monitor pinMode(Pin_D1,OUTPUT); //soil moisture sensor 1 pinMode(readPin,INPUT); //analog input pin pinMode(waterSensorPin,INPUT); //monitor water level } void loop(){ time_now = millis (); nourishment(); while(millis() < time_now + period){ //wait approx. [period] ms } } void nourishment() { //PLANT ONE digitalWrite(Pin_D1,HIGH); //soil moisture sensor 1 ON delay(2000); //wait for voltage to settle Value_D1 = analogRead(readPin); //Read analog pin as sensor 1 Serial.println("D1 ="); Serial.print(Value_D1); waterCheck(); if (Value_D1 wetWall) { digitalWrite(Hydro_D1,LOW); } waterCheck(); delay(1000); } void waterCheck() { waterValue = analogRead(waterSensorPin); Serial.println("Water ="); Serial.print(waterValue); if (waterValue < waterThreshold) { lowWater(); } } void lowWater() { digitalWrite(Pin_D1,LOW); digitalWrite(Hydro_D1,LOW); } Please tell me what I can do, and thank you.

[image] 2pham4: I can half the timer since that appears to be the issue That would be incorrect. Pop quiz: what is the range of the int type on an Uno R3? Which is what I'm assuming by default you are using since you didn't specify otherwise.

Honestly, I don't know. I'm assuming its around 30,000 to -30,000

But yeah, it's an uno r3 (I don't think it being an elegro makes a difference)

[image] 2pham4: int period = 3600000; Numeric range of int is? Suggest you try unsigned long int, let us know how it works then. That's just a first observation, there may be more. Oh, yeah, you've failed the millis() test - to guarantee calculation success, use a test of the form millis() - period >= last because the following fails the rollover: [image] 2pham4: while(millis() < time_now + period){ There are tutorials on this forum about that.

alright, thank you. Though are there some tutorials you could provide?

Start here, but ask questions here(not there). [image] Using millis() for timing. A beginners guide Tutorials Part 1 It is not usually long before new Arduino users discover that although the delay() function is easy to use it has side effects, the main one of which is that its stops all activity on the Arduino until the delay is finished (not quite true, I know, but that is usually how the problem presents itself). When this occurs the new user is usually directed to the BlinkWithoutDelay example sketch (BWoD) and/or the excellent thread entitled Several things at the same time. Several things at the…

[image] 2pham4: Can I do this on cloud? It as a "CLI" command for verbose output, so maybe there is a GUI setting... arduino-cloud-cli device create --name mydevice -v

[image] 2pham4: I'm assuming its around 30,000 to -30,000 Close. 32767 to -32768 to be exact. So 3600000 isn't going to fit. And neither is half of that, 1800000. The solution to getting rid of the warning is to use the correct type, which you already did for time_now, namely unsigned long. This int period = 3600000; should be unsigned long period = 3600000; And because subtracting unsigned works through wrap around whereas adding them doesn't, this while(millis() < time_now + period){ //wait approx. [period] ms } should be this while(millis() - time_now < period){ //wait approx. [period] ms } or more simply in your application, which isn't doing anything inside the while loop: delay(period);

This sounds comprehensible, so thank you. Since 1 hour is too big, does that mean I should change it to 30 seconds (30,000) instead? Want to make sure

The time delay is entirely up to you.

Does my code work? Please help

Projects General Guidance

camsysca June 4, 2026, 9:02pm 16

Start here, but ask questions here(not there).

Topic		Replies	Views
Help please adding code to Smart Plant Watering system Programming	47	479	October 4, 2026
Bewässerungssystem Deutsch	63	860	September 22, 2026
Code issues, greenhouse project Programming	24	1299	September 30, 2023
I'm trying to make an automatic watering system with a 1602 I2C LCD, a relay for toggling the pump and a capacitive soil moisture sensor General Guidance	28	473	May 3, 2026
Hilfe zum automatischen Bewässerungscode Deutsch	13	379	January 24, 2026

Does my code work? Please help

Related topics