Hello folks. I am attempting to generate random numbers. I have a randomSeed statement in Setup. In Loop, if I put the statement "newrnumber = random (255);" then print newrnumber, I truly get a random number. However, if I put the "newrnumber = random (255);" statement in a function, the random number always comes back zero. I don't know why. I've tried putting the ramdomSeed statement in the function, the random number still comes back zero. I've put the code here - keep in mind that a lot of the statements are never executed, they are just here from trying different things. Your knowledge is appreciated.
FYI, I am using a Nano Super-Mini from AliExpress. So far the hardware has worked just fine.
//Pin assignments
const int DATA0 = 3;
const int DATA1 = 4;
const int DATA2 = 5;
const int DATA3 = 6;
const int DATA4 = 7;
const int DATA5 = 8;
const int DATA6 = 9;
const int DATA7 = 10;
const int NOTG1 = A0;
const int ADDRESS1A = A1;
const int ADDRESS1B = A2;
const int NOTG2 = A3;
const int ADDRESS2A = A4;
const int ADDRESS2B = 11;
//Variables defined
String(LOWSTRING)="LOW";
String(HIGHSTRING)="HIGH";
int newrnumber=0;
int x = 0;
int y = 0;
int z=0;
int bit0 = 0;
int bit1 = 0;
int bit2 = 0;
int bit3 = 0;
int bit4 = 0;
int bit5 = 0;
int bit6 = 0;
int bit7 = 0;
//Setup/////////////////////////////////////////////////////////////////////////////////////////////////////////
void setup()
{
// initialize pins as output.
pinMode(DATA0,OUTPUT);
pinMode(DATA1,OUTPUT);
pinMode(DATA2,OUTPUT);
pinMode(DATA3,OUTPUT);
pinMode(DATA4,OUTPUT);
pinMode(DATA5,OUTPUT);
pinMode(DATA6,OUTPUT);
pinMode(DATA7,OUTPUT);
pinMode(NOTG1,OUTPUT);
pinMode(ADDRESS1A,OUTPUT);
pinMode(ADDRESS1B,OUTPUT);
pinMode(NOTG2,OUTPUT);
pinMode(ADDRESS2A,OUTPUT);
pinMode(ADDRESS2B,OUTPUT);
//Set up LED array
byte LED[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
//Turn off all LEDs
void leds_off();
//Generate a random seed
randomSeed(analogRead(0));
Serial.begin(9600);
}
//END SETUP ////////////////////////////////////////////////////////////////////////////////////////////////////
//Main loop/////////////////////////////////////////////////////////////////////////////////////////////////////
void loop()
{
int bit[] = {0,0,0,0,0,0,0,0};
//Generate a random number
//Call genrnumber function
int genrnumber ();
Serial.print ("newrnumber= ");
Serial.print (newrnumber);
loop:
goto loop;
genbitsofbyte (newrnumber); //Call function that generates bit0 through bit7 variable values (1 or 0)
// to be used to turn LEDs on or off
Serial.print (bit[0]);
Serial.print (bit[1]);
Serial.print (bit[2]);
Serial.print (bit[3]);
Serial.print (bit[4]);
Serial.print (bit[5]);
Serial.print (bit[6]);
Serial.println (bit[7]);
delay (500);
}
//End of main loop /////////////////////////////////////////////////////////////////////////////////////////////
//Function to generate a random number (newrnumber)/////////////////////////////////////////////////////////////
int genrnumber()
{
newrnumber = random (0-255);
//return newrnumber;
Serial.println (newrnumber);
}
//Function to generates bit0 through bit7 variable values (1 or 0) to be used to turn LEDs on or off////////////
void genbitsofbyte(int newrnumber)
{
int bit[] = {0,0,0,0,0,0,0,0};
bit[0] = bitRead (newrnumber,0);
bit[1] = bitRead (newrnumber,1);
bit[2] = bitRead (newrnumber,2);
bit[3] = bitRead (newrnumber,3);
bit[4] = bitRead (newrnumber,4);
bit[5] = bitRead (newrnumber,5);
bit[6] = bitRead (newrnumber,6);
bit[7] = bitRead (newrnumber,7);
Serial.print ("In bit function");
Serial.print (bit[0]);
Serial.print (bit[1]);
Serial.print (bit[2]);
Serial.print (bit[3]);
Serial.print (bit[4]);
Serial.print (bit[5]);
Serial.print (bit[6]);
Serial.println (bit[7]);}
void leds_on ()
{
//Set data all high for LEDs on
digitalWrite (DATA0, HIGH);
digitalWrite (DATA1, HIGH);
digitalWrite (DATA2, HIGH);
digitalWrite (DATA3, HIGH);
digitalWrite (DATA4, HIGH);
digitalWrite (DATA5, HIGH);
digitalWrite (DATA6, HIGH);
digitalWrite (DATA7, HIGH);
//Set up the '139 for the address you want (latches 1-6)
//Byte 1
digitalWrite (NOTG1, HIGH); //set 1G high
digitalWrite (ADDRESS1A, LOW); //set 1A, 1B, 2A, 2B for the latches you want to clock
digitalWrite (ADDRESS1B, LOW);
digitalWrite (ADDRESS2A, LOW);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH); //data bits are now clocked into the '273.
//Byte 2
digitalWrite (NOTG1, HIGH); //set 1G high
digitalWrite (ADDRESS1A, HIGH); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, LOW);
digitalWrite (ADDRESS2A, LOW);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
//Byte 3
digitalWrite (NOTG1, HIGH); //set 1G high
digitalWrite (ADDRESS1A, LOW); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, HIGH);
digitalWrite (ADDRESS2A, LOW);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
//Byte 4
digitalWrite (NOTG1, HIGH); //set 1G high
digitalWrite (ADDRESS1A, HIGH); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, HIGH);
digitalWrite (ADDRESS2A, LOW);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
//Byte 5
digitalWrite (NOTG1, HIGH); //set 1G high
digitalWrite (ADDRESS1A, LOW); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, LOW);
digitalWrite (ADDRESS2A, HIGH);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
//Byte 6
digitalWrite (NOTG1, HIGH); //set enables high
digitalWrite (ADDRESS1A, HIGH); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, LOW);
digitalWrite (ADDRESS2A, HIGH);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
}
void LEDs_OFF()
{
//Set data all low for LEDs off
digitalWrite (DATA0, LOW);
digitalWrite (DATA1, LOW);
digitalWrite (DATA2, LOW);
digitalWrite (DATA3, LOW);
digitalWrite (DATA4, LOW);
digitalWrite (DATA5, LOW);
digitalWrite (DATA6, LOW);
digitalWrite (DATA7, LOW);
//Set up the '139 for the address you want (latches 1-6)
//Byte 1
digitalWrite (NOTG1, HIGH); //set enables high
digitalWrite (NOTG2, HIGH);
digitalWrite (ADDRESS1A, LOW); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, LOW);
digitalWrite (ADDRESS2A, LOW);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
digitalWrite (NOTG2, LOW);
digitalWrite (NOTG2, HIGH); //data bits are now clocked into the '273.
//Byte 2
digitalWrite (NOTG1, HIGH); //set enables high
digitalWrite (NOTG2, HIGH);
digitalWrite (ADDRESS1A, HIGH); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, LOW);
digitalWrite (ADDRESS2A, LOW);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
digitalWrite (NOTG2, LOW);
digitalWrite (NOTG2, HIGH); //data bits are now clocked into the '273.
//Byte 3
digitalWrite (NOTG1, HIGH); //set enables high
digitalWrite (NOTG2, HIGH);
digitalWrite (ADDRESS1A, LOW); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, HIGH);
digitalWrite (ADDRESS2A, LOW);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
digitalWrite (NOTG2, LOW);
digitalWrite (NOTG2, HIGH); //data bits are now clocked into the '273.
//Byte 4
digitalWrite (NOTG1, HIGH); //set enables high
digitalWrite (NOTG2, HIGH);
digitalWrite (ADDRESS1A, HIGH); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, HIGH);
digitalWrite (ADDRESS2A, LOW);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
digitalWrite (NOTG2, LOW);
digitalWrite (NOTG2, HIGH); //data bits are now clocked into the '273.
//Byte 5
digitalWrite (NOTG1, HIGH); //set enables high
digitalWrite (NOTG2, HIGH);
digitalWrite (ADDRESS1A, LOW); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, LOW);
digitalWrite (ADDRESS2A, HIGH);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
digitalWrite (NOTG2, LOW);
digitalWrite (NOTG2, HIGH); //data bits are now clocked into the '273.
//Byte 6
digitalWrite (NOTG1, HIGH); //set enables high
digitalWrite (NOTG2, HIGH);
digitalWrite (ADDRESS1A, HIGH); //set 1A, 1B, 2A, 2B for the address you want to write to
digitalWrite (ADDRESS1B, LOW);
digitalWrite (ADDRESS2A, HIGH);
digitalWrite (ADDRESS2B, LOW);
// clock the '139 so the output goes low then high
digitalWrite (NOTG1, LOW);
digitalWrite (NOTG1, HIGH);
digitalWrite (NOTG2, LOW);
digitalWrite (NOTG2, HIGH); //data bits are now clocked into the '273.
}