Having problems programming buttons to move from one loop to another. Traffic light configuration for button one and then when button 2 is pressed the lights should flash (1 set on, the other off). I cannot seem to work out how to make the lights flash when button 2 is pressed and then when pressed again, the sequence goes back to normal.
Sorry to hear of your issues with coding. I can only guess which line or lines of code may be at fault because. Well. You see, I cannot see your code that you want help fixing.
So first thing is you post code but its not in code tags so we spend 5 to 10 messages getting your code in code tags and then we begin to work on your issue. Or, right off the bat you could post your code in code tags and we can get right to work solving your issue. What do you say to posting your code in code tags? Gonna help us help you?
Code posted in code tags.
#include <ESP32Time.h>
#include <WiFi.h>
#include <PubSubClient.h>
#include "certs.h" // include the connection info for WiFi and MQTT
#include "sdkconfig.h" // used for log printing
#include "esp_system.h"
#include "freertos/FreeRTOS.h" //freeRTOS items to be used
#include "freertos/task.h"
#include <driver/adc.h>
#include <SimpleKalmanFilter.h>
////
WiFiClient wifiClient; // do the WiFi instantiation thing
PubSubClient MQTTclient( mqtt_server, mqtt_port, wifiClient ); //do the MQTT instantiation thing
ESP32Time rtc;
////
#define evtDoParticleRead ( 1 << 0 ) // declare an event
#define evtADCreading ( 1 << 3 )
EventGroupHandle_t eg; // variable for the event group handle
////
SemaphoreHandle_t sema_MQTT_KeepAlive;
SemaphoreHandle_t sema_mqttOK;
////
QueueHandle_t xQ_RemainingMoistureMQTT;
QueueHandle_t xQ_RM;
QueueHandle_t xQ_Message;
////
struct stu_message
{
char payload [150] = {'\0'};
String topic;
} x_message;
////
int mqttOK = 0;
bool TimeSet = false;
bool manualPumpOn = false;
////
// interrupt service routine for WiFi events put into IRAM
void IRAM_ATTR WiFiEvent(WiFiEvent_t event)
{
switch (event) {
case SYSTEM_EVENT_STA_CONNECTED:
break;
case SYSTEM_EVENT_STA_DISCONNECTED:
log_i("Disconnected from WiFi access point");
break;
case SYSTEM_EVENT_AP_STADISCONNECTED:
log_i("WiFi client disconnected");
break;
default: break;
}
} // void IRAM_ATTR WiFiEvent(WiFiEvent_t event)
////
void IRAM_ATTR mqttCallback(char* topic, byte * payload, unsigned int length)
{
// clear locations
memset( x_message.payload, '\0', 150 );
x_message.topic = ""; //clear string buffer
x_message.topic = topic;
int i = 0;
for ( i; i < length; i++)
{
x_message.payload[i] = ((char)payload[i]);
}
x_message.payload[i] = '\0';
xQueueOverwrite( xQ_Message, (void *) &x_message );// send data
} // void mqttCallback(char* topic, byte* payload, unsigned int length)
////
void setup()
{
x_message.topic.reserve(150);
//
xQ_Message = xQueueCreate( 1, sizeof(stu_message) );
xQ_RemainingMoistureMQTT = xQueueCreate( 1, sizeof(float) ); // sends a queue copy
xQ_RM = xQueueCreate( 1, sizeof(float) );
//
eg = xEventGroupCreate(); // get an event group handle
//
sema_mqttOK = xSemaphoreCreateBinary();
xSemaphoreGive( sema_mqttOK );
//
gpio_config_t io_cfg = {}; // initialize the gpio configuration structure
io_cfg.mode = GPIO_MODE_INPUT; // set gpio mode. GPIO_NUM_0 input from water level sensor
io_cfg.pull_down_en = GPIO_PULLDOWN_ENABLE; // enable pull down
io_cfg.pin_bit_mask = ( (1ULL << GPIO_NUM_0) ); //bit mask of the pins to set, assign gpio number to be configured
gpio_config(&io_cfg); // configure the gpio based upon the parameters as set in the configuration structure
//
io_cfg = {}; //set configuration structure back to default values
io_cfg.mode = GPIO_MODE_OUTPUT;
io_cfg.pin_bit_mask = ( (1ULL << GPIO_NUM_4) | (1ULL << GPIO_NUM_5) ); //bit mask of the pins to set, assign gpio number to be configured
gpio_config(&io_cfg);
gpio_set_level( GPIO_NUM_4, LOW); // deenergize relay module
gpio_set_level( GPIO_NUM_5, LOW); // deenergize valve
// set up A:D channels https://dl.espressif.com/doc/esp-idf/latest/api-reference/peripherals/adc.html
adc1_config_width(ADC_WIDTH_12Bit);
adc1_config_channel_atten(ADC1_CHANNEL_3, ADC_ATTEN_DB_11);// using GPIO 39
//
xTaskCreatePinnedToCore( MQTTkeepalive, "MQTTkeepalive", 10000, NULL, 6, NULL, 1 );
xTaskCreatePinnedToCore( fparseMQTT, "fparseMQTT", 10000, NULL, 5, NULL, 1 ); // assign all to core 1, WiFi in use.
xTaskCreatePinnedToCore( fPublish, "fPublish", 9000, NULL, 3, NULL, 1 );
xTaskCreatePinnedToCore( fReadAD, "fReadAD", 9000, NULL, 3, NULL, 1 );
xTaskCreatePinnedToCore( fDoMoistureDetector, "fDoMoistureDetector", 70000, NULL, 4, NULL, 1 );
xTaskCreatePinnedToCore( fmqttWatchDog, "fmqttWatchDog", 3000, NULL, 2, NULL, 1 );
} //void setup()
////
void fReadAD( void * parameter )
{
float ADbits = 4096.0f;
float uPvolts = 3.3f;
float adcValue_b = 0.0f; //plant in yellow pot
uint64_t TimePastKalman = esp_timer_get_time(); // used by the Kalman filter UpdateProcessNoise, time since last kalman calculation
float WetValue = 1.07f; // value found by putting sensor in water
float DryValue = 2.732f; // value of probe when held in air
float Range = DryValue - WetValue;
float RemainingMoisture = 100.0f;
SimpleKalmanFilter KF_ADC_b( 1.0f, 1.0f, .01f );
for (;;)
{
xEventGroupWaitBits (eg, evtADCreading, pdTRUE, pdTRUE, portMAX_DELAY ); //
adcValue_b = float( adc1_get_raw(ADC1_CHANNEL_3) ); //take a raw ADC reading
adcValue_b = ( adcValue_b * uPvolts ) / ADbits; //calculate voltage
KF_ADC_b.setProcessNoise( (esp_timer_get_time() - TimePastKalman) / 1000000.0f ); //get time, in microsecods, since last readings
adcValue_b = KF_ADC_b.updateEstimate( adcValue_b ); // apply simple Kalman filter
TimePastKalman = esp_timer_get_time(); // time of update complete
RemainingMoisture = 100.0f * (1 - ((adcValue_b - WetValue) / (DryValue - WetValue))); //remaining moisture = 1-(xTarget - xMin) / (xMax - xMin) as a percentage of the sensor wet dry volatges
xQueueOverwrite( xQ_RM, (void *) &RemainingMoisture );
//log_i( "adcValue_b = %f remaining moisture %f%", adcValue_b, RemainingMoisture );
}
vTaskDelete( NULL );
}
////
void fPublish( void * parameter )
{
float RemainingMoisture = 100.0f;
for (;;)
{
if ( xQueueReceive(xQ_RemainingMoistureMQTT, &RemainingMoisture, portMAX_DELAY) == pdTRUE )
{
xSemaphoreTake( sema_MQTT_KeepAlive, portMAX_DELAY ); // whiles MQTTlient.loop() is running no other mqtt operations should be in process
MQTTclient.publish( topicRemainingMoisture_0, String(RemainingMoisture).c_str() );
xSemaphoreGive( sema_MQTT_KeepAlive );
}
} // for (;;)
vTaskDelete( NULL );
} //void fPublish( void * parameter )
////
void WaterPump0_off()
{
gpio_set_level( GPIO_NUM_4, LOW); //denergize relay module
vTaskDelay( 1 );
gpio_set_level( GPIO_NUM_5, LOW); //denergize/close valve
}
////
void WaterPump0_on()
{
gpio_set_level( GPIO_NUM_5, HIGH); //energize/open valve
vTaskDelay( 1 );
gpio_set_level( GPIO_NUM_4, HIGH); //energize relay module
}
////
void fmqttWatchDog( void * paramater )
{
int UpdateImeTrigger = 86400; //seconds in a day
int UpdateTimeInterval = 85000; // get another reading when = UpdateTimeTrigger
int maxNonMQTTresponse = 12;
TickType_t xLastWakeTime = xTaskGetTickCount();
const TickType_t xFrequency = 5000; //delay for mS
for (;;)
{
xLastWakeTime = xTaskGetTickCount();
vTaskDelayUntil( &xLastWakeTime, xFrequency );
xSemaphoreTake( sema_mqttOK, portMAX_DELAY ); // update mqttOK
mqttOK++;
xSemaphoreGive( sema_mqttOK );
if ( mqttOK >= maxNonMQTTresponse )
{
ESP.restart();
}
UpdateTimeInterval++; // trigger new time get
if ( UpdateTimeInterval >= UpdateImeTrigger )
{
TimeSet = false; // sets doneTime to false to get an updated time after a days count of seconds
UpdateTimeInterval = 0;
}
}
vTaskDelete( NULL );
} //void fmqttWatchDog( void * paramater )
////
void fDoMoistureDetector( void * parameter )
{
//wait for a mqtt connection
while ( !MQTTclient.connected() )
{
vTaskDelay( 250 );
}
int TimeToPublish = 5000000; //5000000uS
int TimeForADreading = 100 * 1000; // 100mS
uint64_t TimePastPublish = esp_timer_get_time(); // used by publish
uint64_t TimeADreading = esp_timer_get_time();
TickType_t xLastWakeTime = xTaskGetTickCount();
const TickType_t xFrequency = 10; //delay for 10mS
float RemainingMoisture = 100.0f; //prevents pump turn on during start up
bool pumpOn = false;
uint64_t PumpOnTime = esp_timer_get_time();
int PumpRunTime = 11000000;
uint64_t PumpOffWait = esp_timer_get_time();
uint64_t PumpOffWaitFor = 60000000; //one minute
float lowMoisture = 23.0f;
float highMoisture = 40.0f;
for (;;)
{
//read AD values every 100mS.
if ( (esp_timer_get_time() - TimeADreading) >= TimeForADreading )
{
xEventGroupSetBits( eg, evtADCreading );
TimeADreading = esp_timer_get_time();
}
xQueueReceive(xQ_RM, &RemainingMoisture, 0 ); //receive queue stuff no waiting
//read gpio 0 is water level good. Yes: OK to run pump : no pump off. remaining moisture good, denergize water pump otherwise energize water pump.
if ( RemainingMoisture >= highMoisture )
{
WaterPump0_off();
}
if ( !pumpOn )
{
log_i( "not pump on ");
if ( gpio_get_level( GPIO_NUM_0 ) )
{
if ( RemainingMoisture <= lowMoisture )
{
//has one minute passed since last pump energize, if so then allow motor to run
if ( (esp_timer_get_time() - PumpOffWait) >= PumpOffWaitFor )
{
WaterPump0_on();
log_i( "pump on " );
pumpOn = !pumpOn;
PumpOnTime = esp_timer_get_time();
}
}
//xSemaphoreGive( sema_RemainingMoisture );
} else {
log_i( "water level bad " );
WaterPump0_off();
PumpOffWait = esp_timer_get_time();
}
} else {
/*
pump goes on runs for X seconds then turn off, then wait PumpOffWaitTime before being allowed to energize again
*/
if ( (esp_timer_get_time() - PumpOnTime) >= PumpRunTime )
{
log_i( "pump off " );
WaterPump0_off(); // after PumpRunTime seconds turn pump off
pumpOn = !pumpOn;
PumpOffWait = esp_timer_get_time();
}
}
// publish to MQTT every 5000000uS
if ( (esp_timer_get_time() - TimePastPublish) >= TimeToPublish )
{
xQueueOverwrite( xQ_RemainingMoistureMQTT, (void *) &RemainingMoisture );// data for mqtt publish
TimePastPublish = esp_timer_get_time(); // get next publish time
}
xLastWakeTime = xTaskGetTickCount();
vTaskDelayUntil( &xLastWakeTime, xFrequency );
}
vTaskDelete( NULL );
}// end fDoMoistureDetector()
////
void MQTTkeepalive( void *pvParameters )
{
sema_MQTT_KeepAlive = xSemaphoreCreateBinary();
xSemaphoreGive( sema_MQTT_KeepAlive ); // found keep alive can mess with a publish, stop keep alive during publish
MQTTclient.setKeepAlive( 90 ); // setting keep alive to 90 seconds makes for a very reliable connection, must be set before the 1st connection is made.
TickType_t xLastWakeTime = xTaskGetTickCount();
const TickType_t xFrequency = 250; // 250mS
for (;;)
{
//check for a is-connected and if the WiFi 'thinks' its connected, found checking on both is more realible than just a single check
if ( (wifiClient.connected()) && (WiFi.status() == WL_CONNECTED) )
{
xSemaphoreTake( sema_MQTT_KeepAlive, portMAX_DELAY ); // whiles MQTTlient.loop() is running no other mqtt operations should be in process
MQTTclient.loop();
xSemaphoreGive( sema_MQTT_KeepAlive );
}
else {
log_i( "MQTT keep alive found MQTT status %s WiFi status %s", String(wifiClient.connected()), String(WiFi.status()) );
if ( !(wifiClient.connected()) || !(WiFi.status() == WL_CONNECTED) )
{
connectToWiFi();
}
connectToMQTT();
}
xLastWakeTime = xTaskGetTickCount();
vTaskDelayUntil( &xLastWakeTime, xFrequency );
}
vTaskDelete ( NULL );
}
////
void connectToMQTT()
{
// create client ID from mac address
byte mac[5];
int count = 0;
WiFi.macAddress(mac); // get mac address
String clientID = String(mac[0]) + String(mac[4]);
log_i( "connect to mqtt as client %s", clientID );
while ( !MQTTclient.connected() )
{
MQTTclient.disconnect();
MQTTclient.connect( clientID.c_str(), mqtt_username, mqtt_password );
vTaskDelay( 250 );
count++;
if ( count == 5 )
{
ESP.restart();
}
}
MQTTclient.setCallback( mqttCallback );
MQTTclient.subscribe( topicOK );
}
////
void connectToWiFi()
{
int TryCount = 0;
while ( WiFi.status() != WL_CONNECTED )
{
TryCount++;
WiFi.disconnect();
WiFi.begin( SSID, PASSWORD );
vTaskDelay( 4000 );
if ( TryCount == 10 )
{
ESP.restart();
}
}
WiFi.onEvent( WiFiEvent );
} // void connectToWiFi()
//////
void fparseMQTT( void *pvParameters )
{
struct stu_message px_message;
for (;;)
{
if ( xQueueReceive(xQ_Message, &px_message, portMAX_DELAY) == pdTRUE )
{
if ( px_message.topic == topicOK )
{
xSemaphoreTake( sema_mqttOK, portMAX_DELAY );
mqttOK = 0; // clear mqtt ok count
xSemaphoreGive( sema_mqttOK );
}
if ( !TimeSet )
{
String temp = "";
temp = px_message.payload[0];
temp += px_message.payload[1];
temp += px_message.payload[2];
temp += px_message.payload[3];
int year = temp.toInt();
temp = "";
temp = px_message.payload[5];
temp += px_message.payload[6];
int month = temp.toInt();
temp = "";
temp = px_message.payload[8];
temp += px_message.payload[9];
int day = temp.toInt();
temp = "";
temp = px_message.payload[11];
temp += px_message.payload[12];
int hour = temp.toInt();
temp = "";
temp = px_message.payload[14];
temp += px_message.payload[15];
int min = temp.toInt();
rtc.setTime( 0, min, hour, day, month, year );
log_i( "%s ", rtc.getTime() );
TimeSet = true;
}
// manual pump control
if ( str_eTopic == topicPumpState )
{
if ( String(strPayload) == "off" )
{
WaterPump0_off();
manualPumpOn = false;
}
if ( String(strPayload) == "on" )
{
WaterPump0_on();
manualPumpOn = true;
}
}
}
} //for(;;)
vTaskDelete ( NULL );
} // void fparseMQTT( void *pvParameters )
////
void loop() {}
So now we spend 10 or 15 messages getting your code properlly posted. Oh school assignment. Well good luck to you.
OK, I gots to know… how did you do that?
a7
I found this thing,
to be helpful.
Words such as "posting code" gets results.
haha, yes.
TBC I thought you had somehow managed to post the OP's code in tags… that's how little attention I paid to her long series of screen shotz.
a7
const int PIN_BUTTON1 = 7; // Pin number for push button 1
const int PIN_BUTTON2 = 6;
// Traffic Light 1
const int PIN_LED_RED1 = 13; // Pin number for red 1
const int PIN_LED_AMBER1 = 12; // Pin number for amber 1
const int PIN_LED_GREEN1 = 11; // Pin number for green 1
// Traffic Light 2
const int PIN_LED_RED2 = 10; // Pin number for red 2
const int PIN_LED_AMBER2 = 9; //Pin number for amber 2
const int PIN_LED_GREEN2 = 8; //Pin number for green 2
const int DEBOUNCE_DELAY = 10;
const int MAX_STATE = 7; // Maxium amount of states
int oldButtonState; // Keeping track of the button
int ledState; // What LED pattern is showing
void setup()
{
Serial.begin(9600);
pinMode(PIN_BUTTON1, INPUT_PULLUP ); // Button needs an imput
pinMode(PIN_BUTTON2, INPUT_PULLUP );
// Traffic Light 1
pinMode(PIN_LED_RED1, OUTPUT ); // LED needs an output
pinMode(PIN_LED_AMBER1, OUTPUT ); // LED needs an output
pinMode(PIN_LED_GREEN1, OUTPUT ); // LED needs an output
// Traffic Light 2
pinMode(PIN_LED_RED2, OUTPUT ); // LED needs an output
pinMode(PIN_LED_AMBER2, OUTPUT ); // LED needs an output
pinMode(PIN_LED_GREEN2, OUTPUT ); // LED needs an output
oldButtonState = HIGH;
ledState = 0;
}
void loop()
{
Serial.println(ledState);
// Read the state of the button state
int buttonState = digitalRead(PIN_BUTTON1);
// Has anything changed?
if (oldButtonState != buttonState)
{
Serial.println("button changed");
// Yes, update old button state
oldButtonState = buttonState;
// Hasthe buttonjust been pressed?
if (buttonState == HIGH)
{
Serial.println("Button down");
ledState++; //Next state
if (ledState > MAX_STATE) //Overshoot ...
{
ledState = 0; //Reset
}
}
else
{
Serial.println("Button up");
}
delay(DEBOUNCE_DELAY);
}
switch (ledState)
{
case 0:
digitalWrite(PIN_LED_RED1, HIGH); // traffic light 1 red ON
digitalWrite(PIN_LED_AMBER1, LOW); // traffic light 1 amber OFF
digitalWrite(PIN_LED_GREEN1, LOW); // traffic light 1 green OFF
digitalWrite(PIN_LED_RED2, HIGH); // traffic light 2 red ON
digitalWrite(PIN_LED_AMBER2, LOW); // traffic light 2 amber OFF
digitalWrite(PIN_LED_GREEN2, LOW); // traffic light 2 green OFF
break;
case 1:
digitalWrite(PIN_LED_RED1, HIGH); //traffic light 1 red ON
digitalWrite(PIN_LED_AMBER1, HIGH); //traffic light 1 amber ON
digitalWrite(PIN_LED_GREEN1, LOW); //traffic light 1 green OFF
digitalWrite(PIN_LED_RED2, HIGH); //traffic light 2 red ON
digitalWrite(PIN_LED_AMBER2, LOW); //traffic light 2 amber OFF
digitalWrite(PIN_LED_GREEN2, LOW); //traffic light 2 green OFF
break;
case 2:
digitalWrite(PIN_LED_RED1, LOW); //traffic light 1 red OFF
digitalWrite(PIN_LED_AMBER1, LOW); //traffic light 1 amber OFF
digitalWrite(PIN_LED_GREEN1, HIGH); //traffic light 1 green ON
digitalWrite(PIN_LED_RED2, HIGH); //traffic light 2 red ON
digitalWrite(PIN_LED_AMBER2, LOW); //traffic light 2 amber OFF
digitalWrite(PIN_LED_GREEN2, LOW); //traffic light 2 green OFF
break;
case 3:
digitalWrite(PIN_LED_RED1, LOW); //traffic light 1 red OFF
digitalWrite(PIN_LED_AMBER1, HIGH); //traffic light 1 amber ON
digitalWrite(PIN_LED_GREEN1, LOW); //traffic light 1 green OFF
digitalWrite(PIN_LED_RED2, HIGH); //traffic light 2 red ON
digitalWrite(PIN_LED_AMBER2, LOW); //traffic light 2 amber OFF
digitalWrite(PIN_LED_GREEN2, LOW); //traffic light 2 green OFF
break;
case 4:
digitalWrite(PIN_LED_RED1, HIGH); //traffic light 1 red ON
digitalWrite(PIN_LED_AMBER1, LOW); //traffic light 1 amber OFF
digitalWrite(PIN_LED_GREEN1, LOW); //traffic light 1 green OFF
digitalWrite(PIN_LED_RED2, HIGH); //traffic light 2 red ON
digitalWrite(PIN_LED_AMBER2, LOW); //traffic light 2 amber OFF
digitalWrite(PIN_LED_GREEN2, LOW); //traffic light 2 green OFF
break;
case 5:
digitalWrite(PIN_LED_RED1, HIGH); //traffic light 1 red ON
digitalWrite(PIN_LED_AMBER1, LOW); //traffic light 1 amber OFF
digitalWrite(PIN_LED_GREEN1, LOW); //traffic light 1 green OFF
digitalWrite(PIN_LED_RED2, HIGH); //traffic light 2 red ON
digitalWrite(PIN_LED_AMBER2, HIGH); //traffic light 2 amber ON
digitalWrite(PIN_LED_GREEN2, LOW); //traffic light 2 green OFF
break;
case 6:
digitalWrite(PIN_LED_RED1, HIGH); //traffic light 1 red ON
digitalWrite(PIN_LED_AMBER1, LOW); //traffic light 1 amber OFF
digitalWrite(PIN_LED_GREEN1, LOW); //traffic light 1 green OFF
digitalWrite(PIN_LED_RED2, LOW); //traffic light 2 red OFF
digitalWrite(PIN_LED_AMBER2, LOW); //traffic light 2 amber OFF
digitalWrite(PIN_LED_GREEN2, HIGH); //traffic light 2 green ON
break;
case 7:
digitalWrite(PIN_LED_RED1, HIGH); //traffic light 1 red ON
digitalWrite(PIN_LED_AMBER1, LOW); //traffic light 1 amber OFF
digitalWrite(PIN_LED_GREEN1, LOW); //traffic light 1 green OFF
digitalWrite(PIN_LED_RED2, LOW); //traffic light 2 red OFF
digitalWrite(PIN_LED_AMBER2, HIGH); //traffic light 2 amber ON
digitalWrite(PIN_LED_GREEN2, LOW); //traffic light 2 green OFF
break;
}
}
- When button 2 is pressed then toggle a test blink mode flag, reset the state to 0, and record the current millis()
- If you are in test blink mode then check to see if 1000ms have passed by reading millis() and comparing to the time you stored in step 1
- If 1000ms have passed then alternate which set of traffic lights are on and record the current millis() again
The following tutorials may help:
This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.