Melody on Arduino using millis()

Projects Programming
1

I want my arduino to play a melody without using the delay() function (multitasking). this is the code I have so far:

        int tempo = 200;

	int buzzer = 13;

	int melody[]={
 	 NOTE_E5,8, NOTE_E5,8, REST,8, NOTE_E5,8, REST,8, NOTE_C5,8, NOTE_E5,8, //1
 	 NOTE_G5,4, REST,4, NOTE_G4,8, REST,4, 
 	 NOTE_C5,-4, NOTE_G4,8, REST,4, NOTE_E4,-4, // 3
  	 NOTE_A4,4, NOTE_B4,4, NOTE_AS4,8, NOTE_A4,4,
  	 NOTE_G4,-8, NOTE_E5,-8, NOTE_G5,-8, NOTE_A5,4, NOTE_F5,8, NOTE_G5,8,
 	 REST,8, NOTE_E5,4,NOTE_C5,8, NOTE_D5,8, NOTE_B4,-4,
 	 NOTE_C5,-4, NOTE_G4,8, REST,4, NOTE_E4,-4, // repeats from 3
 	 NOTE_A4,4, NOTE_B4,4, NOTE_AS4,8, NOTE_A4,4,
 	 NOTE_G4,-8, NOTE_E5,-8, NOTE_G5,-8, NOTE_A5,4, NOTE_F5,8, NOTE_G5,8,
 	 REST,8, NOTE_E5,4,NOTE_C5,8, NOTE_D5,8, NOTE_B4,-4,
	};

	int notes = sizeof(lied1) / sizeof(lied1[0]) / 2;

	// this calculates the duration of a whole note in ms
	int wholenote = (60000 * 4) / tempo;

	int divider = 0, noteDuration = 0;
   	
    boolean outputTone = false;
    unsigned long previousMillis = millis();
    int thisNote = 0;
    
    while (thisNote < notes * 2) {
		
    	// calculates the duration of each note
    	divider = lied1[thisNote + 1];
    	if (divider > 0) {
     		// regular note, just proceed
     		noteDuration = (wholenote) / divider;
   	 	} else if (divider < 0) {
      		// dotted notes are represented with negative durations!!
      		noteDuration = (wholenote) / abs(divider);
     		noteDuration *= 1.5; // increases the duration in half for dotted notes
    	}
		
      	if (millis() - previousMillis >= noteDuration) {
 		    previousMillis = millis();
    		if (outputTone) {
        		noTone(buzzer);
        		outputTone==false;              
    		} else {
        		tone(buzzer, melody[thisNote], noteDuration*0.9);
        		outputTone==true;
                 	thisNote = thisNote + 2; 
    		}
	}
   }

It does not work, the first notes do, but the other notes do not work properly.

2

Thanks for using code tags in your first post but please post the full code

3 
#define NOTE_B0  31
#define NOTE_C1  33
#define NOTE_CS1 35
#define NOTE_D1  37
#define NOTE_DS1 39
#define NOTE_E1  41
#define NOTE_F1  44
#define NOTE_FS1 46
#define NOTE_G1  49
#define NOTE_GS1 52
#define NOTE_A1  55
#define NOTE_AS1 58
#define NOTE_B1  62
#define NOTE_C2  65
#define NOTE_CS2 69
#define NOTE_D2  73
#define NOTE_DS2 78
#define NOTE_E2  82
#define NOTE_F2  87
#define NOTE_FS2 93
#define NOTE_G2  98
#define NOTE_GS2 104
#define NOTE_A2  110
#define NOTE_AS2 117
#define NOTE_B2  123
#define NOTE_C3  131
#define NOTE_CS3 139
#define NOTE_D3  147
#define NOTE_DS3 156
#define NOTE_E3  165
#define NOTE_F3  175
#define NOTE_FS3 185
#define NOTE_G3  196
#define NOTE_GS3 208
#define NOTE_A3  220
#define NOTE_AS3 233
#define NOTE_B3  247
#define NOTE_C4  262
#define NOTE_CS4 277
#define NOTE_D4  294
#define NOTE_DS4 311
#define NOTE_E4  330
#define NOTE_F4  349
#define NOTE_FS4 370
#define NOTE_G4  392
#define NOTE_GS4 415
#define NOTE_A4  440
#define NOTE_AS4 466
#define NOTE_B4  494
#define NOTE_C5  523
#define NOTE_CS5 554
#define NOTE_D5  587
#define NOTE_DS5 622
#define NOTE_E5  659
#define NOTE_F5  698
#define NOTE_FS5 740
#define NOTE_G5  784
#define NOTE_GS5 831
#define NOTE_A5  880
#define NOTE_AS5 932
#define NOTE_B5  988
#define NOTE_C6  1047
#define NOTE_CS6 1109
#define NOTE_D6  1175
#define NOTE_DS6 1245
#define NOTE_E6  1319
#define NOTE_F6  1397
#define NOTE_FS6 1480
#define NOTE_G6  1568
#define NOTE_GS6 1661
#define NOTE_A6  1760
#define NOTE_AS6 1865
#define NOTE_B6  1976
#define NOTE_C7  2093
#define NOTE_CS7 2217
#define NOTE_D7  2349
#define NOTE_DS7 2489
#define NOTE_E7  2637
#define NOTE_F7  2794
#define NOTE_FS7 2960
#define NOTE_G7  3136
#define NOTE_GS7 3322
#define NOTE_A7  3520
#define NOTE_AS7 3729
#define NOTE_B7  3951
#define NOTE_C8  4186
#define NOTE_CS8 4435
#define NOTE_D8  4699
#define NOTE_DS8 4978
#define REST      0



void setup()
{
  pinMode(2, OUTPUT);
  pinMode(3, OUTPUT);
  pinMode(4, OUTPUT);
  pinMode(5, OUTPUT);
  pinMode(6, OUTPUT);
  pinMode(7, OUTPUT);
  pinMode(8, OUTPUT);
  pinMode(9, OUTPUT);
  pinMode(10, OUTPUT);
  pinMode(11, OUTPUT);
  pinMode(12, OUTPUT);
  pinMode(13, OUTPUT);
}

void loop()
{
  check();
  if(nummer==1)
  {
    uit();
    een();
    digitalWrite(12, HIGH);
        int tempo = 200;

	int buzzer = 13;

	int melody[]={
 	 NOTE_E5,8, NOTE_E5,8, REST,8, NOTE_E5,8, REST,8, NOTE_C5,8, NOTE_E5,8, //1
 	 NOTE_G5,4, REST,4, NOTE_G4,8, REST,4, 
 	 NOTE_C5,-4, NOTE_G4,8, REST,4, NOTE_E4,-4, // 3
  	 NOTE_A4,4, NOTE_B4,4, NOTE_AS4,8, NOTE_A4,4,
  	 NOTE_G4,-8, NOTE_E5,-8, NOTE_G5,-8, NOTE_A5,4, NOTE_F5,8, NOTE_G5,8,
 	 REST,8, NOTE_E5,4,NOTE_C5,8, NOTE_D5,8, NOTE_B4,-4,
 	 NOTE_C5,-4, NOTE_G4,8, REST,4, NOTE_E4,-4, // repeats from 3
 	 NOTE_A4,4, NOTE_B4,4, NOTE_AS4,8, NOTE_A4,4,
 	 NOTE_G4,-8, NOTE_E5,-8, NOTE_G5,-8, NOTE_A5,4, NOTE_F5,8, NOTE_G5,8,
 	 REST,8, NOTE_E5,4,NOTE_C5,8, NOTE_D5,8, NOTE_B4,-4,
	};

	int notes = sizeof(lied1) / sizeof(lied1[0]) / 2;

	// this calculates the duration of a whole note in ms
	int wholenote = (60000 * 4) / tempo;

	int divider = 0, noteDuration = 0;
   	
    boolean outputTone = false;
    unsigned long previousMillis = millis();
    int thisNote = 0;
    
    while (thisNote < notes * 2) {
		
    	// calculates the duration of each note
    	divider = melody[thisNote + 1];
    	if (divider > 0) {
     		// regular note, just proceed
     		noteDuration = (wholenote) / divider;
   	 	} else if (divider < 0) {
      		// dotted notes are represented with negative durations!!
      		noteDuration = (wholenote) / abs(divider);
     		noteDuration *= 1.5; // increases the duration in half for dotted notes
    	}
		
      	if (millis() - previousMillis >= noteDuration) {
 		    previousMillis = millis();
    		if (outputTone) {
        		noTone(buzzer);
        		outputTone==false;              
    		} else {
        		tone(buzzer, melody[thisNote], noteDuration*0.9);
        		outputTone==true;
              	thisNote = thisNote + 2; 
    		}
	}
        
        check();// the multitasking part
   	if (nummer ==2){
            thisNote=notes*2;
        }  
    }
    nummer=2;
  }

ps code looks probably a bit off, because I copy pasted it

4 
'check' was not declared in this scope
5 
if (outputTone) {
         noTone(buzzer);
         outputTone==false;             
     } else {
         tone(buzzer, melody[thisNote], noteDuration*0.9);
         outputTone==true;
                 thisNote = thisNote + 2;
     }

I think you mean

outputTone = false;

(or true) == is used for comparison.
From experience with melody player programming : tone() is not very accurate ! Calculating a note's frequency and then converting it to a wavelength all in integer will not as pleasing as creating a table that has the wavelength in uS and using timer1 (as tone() also does) directly.

6

Also you should really use PROGMEM to store your melodies. Have a look at Attiny13 melody player for ideas. This is a blocking sketch, but who would think you can squeeze that much out of an Attiny13 (and then still want it to do more..)

7

Deva_Rishi:

if (outputTone) {

noTone(buzzer);
        outputTone==false;            
    } else {
        tone(buzzer, melody[thisNote], noteDuration*0.9);
        outputTone==true;
                thisNote = thisNote + 2;
    }



I think you mean

outputTone = false;



(or true) == is used for comparison.
From experience with melody player programming : tone() is not very accurate ! Calculating a note's frequency and then converting it to a wavelength all in integer will not as pleasing as creating a table that has the wavelength in uS and using timer1 (as tone() also does) directly.

Thanks! I did not see I accidentally used "==" this helped!

8

Can you show the new full sketch ? Maybe with using PROGMEM and be able to select multiple melodies ?

I prefer that a "update" function is used in the loop() which takes care of the melody.
Have you seen Noodle-Synth and NonBlockingRTTTL ?