not looping correctly

Projects Programming
21

This is the bit I was describing. Not complete and not compiled, so not tested.

//Globals
bool buzzing=false;
int buzzcount=0;
usigned long lastbuzz=0;

// part of loop, at the end
if ((millis() - lastlcd > setvaluelcd) && ktc.readFahrenheit() >= SetTemp)
  {
  buzzing=true;
  buzzcount=16    
  digitalWrite(buzzer, HIGH);
  lastbuzz=millis();
  }
  
if(buzzing && millis()-lastbuzz > buzzduration)
  {
  digitalWrite(buzzer,digitalRead(buzzer)== HIGH ? LOW : HIGH);
  lastbuzz=millis();
  buzzcount--;
  if(buzzcount <=0)
    {
    buzzing=false;
    }  
  }
22

Thanks but unfortunately it still doesn't stop beeping.

23

wildbill:
This is the bit I was describing. Not complete and not compiled, so not tested.

//Globals

bool buzzing=false;
int buzzcount=0;
usigned long lastbuzz=0;

// part of loop, at the end
if ((millis() - lastlcd > setvaluelcd) && ktc.readFahrenheit() >= SetTemp)
  {
  buzzing=true;
  buzzcount=16   
  digitalWrite(buzzer, HIGH);
  lastbuzz=millis();
  }
 
if(buzzing && millis()-lastbuzz > buzzduration)
  {
  digitalWrite(buzzer,digitalRead(buzzer)== HIGH ? LOW : HIGH);
  lastbuzz=millis();
  buzzcount--;
  if(buzzcount <=0)
    {
    buzzing=false;
    } 
  }

I used Serial Monitor to get a better look and it keeps on counting 2-1-0, 2-1-0, according to the time delay from

if ((millis() - lastlcd > setvaluelcd) && ktc.readFahrenheit() >= SetTemp)

24

It's because you still have over temp, so as soon as the beeps stop, that section restarts it. When you stop beeping, note the time and don't allow a restart until a minute (or whatever) has passed.

25

wildbill:
It's because you still have over temp, so as soon as the beeps stop, that section restarts it. When you stop beeping, note the time and don't allow a restart until a minute (or whatever) has passed.

What do you mean? How do I make it not allow a restart until a minute has passed.

This is a more simplified version of the code using the Boolean and count. I just wanna test the concept.
Thanks.

  if ((millis() - lastlcd > setvaluelcd) && ktc.readFahrenheit() >= SetTemp)
  {
    buzzing = true;
    buzzcount = 2;
    Serial.print(buzzcount);
    lastlcd = millis();
  }

  if (buzzing && millis() - lastbuzz > 300)
  {
    digitalWrite(buzzer, HIGH);
    buzzcount--;
    Serial.print(buzzcount);
    lastbuzz = millis();

    if (buzzcount <= 0)
    {
      buzzing = false;
      digitalWrite(buzzer,
26

For a simple way to see it working, add a new time interval that controls how often you check for over temp. Right now you're using setvaluelcd, add a new one. set it to thirty seconds.

27

wildbill:
For a simple way to see it working, add a new time interval that controls how often you check for over temp. Right now you're using setvaluelcd, add a new one. set it to thirty seconds.

I changed setvaluelcd and set it to 30 sec. Now it beeps every 30 seconds while the temp updates correctly.
The buzzer is initially off and it starts beeping only after 30 seconds have passed and then it continues to beep every 30 seconds.

28

You could consider to restructure this code as a proper state machine