hi there this my first project with arduino here is the problem i have project which arduino take data from python by serial and the communication is good i write a function to write digital pin because i the program will turn on/off 12 output the same way but with different condition so i write a function and call the function in loop the problem is the function work and the output is on but after about 1 minute the output is off even is there is no change in the condition a nother this i called another function inside this function to detect rise edge for input but it isn't work here is the code int SerialData[10]; int H1_7 =0; int H8_12=0; int V_SPD=0; int C_SPD=0; int a=0; int b=0; int c=0; int flag=0; int unload=0; int start=0 ; int vib_1=2; int vib_2_3=3; int vib_4=4; int vib_5=5; int vib_6=6; int vib_7=7; int vib_8=8; int vib_9=9; int vib_10=10; int vib_11=11; int vib_12=12; int C_vib=13; int m_high_1=22; int m_low_1=24; int m_high_2=26; int m_low_2=28; int m_high_3=30; int m_low_3=32; int m_high_4=34; int m_low_4=36; int m_high_5=38; int m_low_5=40; int m_high_6=42; int m_low_6=44; int m_high_7=46; int m_low_7=48; int m_high_8=50; int m_low_8=52; int m_high_9=23; int m_low_9=25; int m_high_10=27; int m_low_10=29; int m_high_11=31; int m_low_11=33; int m_high_12=35; int m_low_12=37; int prx_H_1=39; int prx_L_1=41; int prx_H_2=43; int prx_L_2=45; int prx_H_3=47; int prx_L_3=49; int prx_H_4=51; int prx_L_4=53; int prx_H_5=54; int prx_L_5=55; int prx_H_6=56; int prx_L_6=57; int prx_H_7=58; int prx_L_7=59; int prx_H_8=60; int prx_L_8=61; int prx_H_9=62; int prx_L_9=63; int prx_H_10=64; int prx_L_10=65; int prx_H_11=66; int prx_L_11=67; int prx_H_12=68; int prx_L_12=69; int last_state_1=1; int last_state_2=1; int last_state_3=1; int last_state_4=1; int last_state_5=1; int last_state_6=1; int last_state_7=1; int last_state_8=1; int last_state_9=1; int last_state_10=1; int last_state_11=1; int last_state_12=1; int last_state_13=1; int last_state_14=1; int last_state_15=1; int last_state_16=1; int last_state_17=1; int last_state_18=1; int last_state_19=1; int last_state_20=1; int last_state_21=1; int last_state_22=1; int last_state_23=1; int last_state_24=1; int state_B_1; bool en_1=false; void setup() { pinMode(vib_1, OUTPUT); pinMode(vib_2_3, OUTPUT); pinMode(vib_4, OUTPUT); pinMode(vib_5, OUTPUT); pinMode(vib_6, OUTPUT); pinMode(vib_7, OUTPUT); pinMode(vib_8, OUTPUT); pinMode(vib_9, OUTPUT); pinMode(vib_10, OUTPUT); pinMode(vib_11, OUTPUT); pinMode(vib_12, OUTPUT); pinMode(C_vib, OUTPUT); pinMode(m_high_1, OUTPUT); pinMode(m_low_1, OUTPUT); pinMode(m_high_2, OUTPUT); pinMode(m_low_2, OUTPUT); pinMode(m_high_3, OUTPUT); pinMode(m_low_3, OUTPUT); pinMode(m_high_4, OUTPUT); pinMode(m_low_4, OUTPUT); pinMode(m_high_5, OUTPUT); pinMode(m_low_5, OUTPUT); pinMode(m_high_6, OUTPUT); pinMode(m_low_6, OUTPUT); pinMode(m_high_7, OUTPUT); pinMode(m_low_7, OUTPUT); pinMode(m_high_8, OUTPUT); pinMode(m_low_8, OUTPUT); pinMode(m_high_9, OUTPUT); pinMode(m_low_9, OUTPUT); pinMode(m_high_10, OUTPUT); pinMode(m_low_10, OUTPUT); pinMode(m_high_11, OUTPUT); pinMode(m_low_11, OUTPUT); pinMode(m_high_12, OUTPUT); pinMode(m_low_12, OUTPUT); pinMode(prx_H_1, INPUT_PULLUP); pinMode(prx_L_1, INPUT_PULLUP); pinMode(prx_H_2, INPUT_PULLUP); pinMode(prx_L_2, INPUT_PULLUP); pinMode(prx_H_3, INPUT_PULLUP); pinMode(prx_L_3, INPUT_PULLUP); pinMode(prx_H_4, INPUT_PULLUP); pinMode(prx_L_4, INPUT_PULLUP); pinMode(prx_H_5, INPUT_PULLUP); pinMode(prx_L_5, INPUT_PULLUP); pinMode(prx_H_6, INPUT_PULLUP); pinMode(prx_L_6, INPUT_PULLUP); pinMode(prx_H_7, INPUT_PULLUP); pinMode(prx_L_7, INPUT_PULLUP); pinMode(prx_H_8, INPUT_PULLUP); pinMode(prx_L_8, INPUT_PULLUP); pinMode(prx_H_9, INPUT_PULLUP); pinMode(prx_L_9, INPUT_PULLUP); pinMode(prx_H_10, INPUT_PULLUP); pinMode(prx_L_10, INPUT_PULLUP); pinMode(prx_H_11, INPUT_PULLUP); pinMode(prx_L_11, INPUT_PULLUP); pinMode(prx_H_12, INPUT_PULLUP); pinMode(prx_L_12, INPUT_PULLUP); Serial.begin(115200); while(!Serial){} } void vibrators_speed(int pin_no, int speed, int head_en, int flag_en,int start_en,int bitno){ if (speed==0 && flag_en==0 && bitRead(head_en,bitno)==1 && start_en==1){digitalWrite(pin_no,HIGH);} if (speed==1 && flag_en==0 && bitRead(head_en,bitno)==1 && start_en==1){ digitalWrite(pin_no,HIGH); delay(1500); digitalWrite(pin_no,LOW); delay(500); } if (speed==2 && flag_en==0 && bitRead(head_en,bitno)==1 && start_en==1){ digitalWrite(pin_no,HIGH); delay(100); digitalWrite(pin_no,LOW); delay(100); } if (bitRead(head_en,bitno)==0 || start_en==0 || flag_en==1){digitalWrite(pin_no,LOW);} } bool p_trig(int bitstate,int last_state, int pin_no ){ bool out=false; bitstate=digitalRead(pin_no); if (bitstate != last_state && digitalRead(pin_no)==LOW){out= true;} last_state=bitstate; return out; } void basket_M(int start,int head_en,int flag_en, int bit_no,int motor_pin, int pin_no){ int bit_state,last_state; bool runf,en; //if(start==0 || flag_en==0){en=false;} en=p_trig(bit_state,last_state, pin_no ); if (en){runf=true;}else{runf=false;} if (runf==false && start==1 && bitRead(head_en,bit_no)==1 && flag_en==1){digitalWrite(motor_pin,HIGH);} else{digitalWrite(motor_pin,LOW);} } void loop() { if (Serial.available()>=10){ for (int i=0; i<10; i++){ SerialData[i] = Serial.read(); } H1_7 = SerialData[0]; H8_12 = SerialData[1]; V_SPD = SerialData[2]; C_SPD = SerialData[3]; a = SerialData[4]; b = SerialData[5]; c = SerialData[6]; flag = SerialData[7]; unload=SerialData[8]; start=SerialData[9]; Serial.end(); Serial.begin(115200); vibrators_speed(vib_1,V_SPD,H1_7,flag,start,0); vibrators_speed(vib_2_3,V_SPD,H1_7,flag,start,1); vibrators_speed(vib_4,V_SPD,H1_7,flag,start,2); vibrators_speed(vib_5,V_SPD,H1_7,flag,start,3); vibrators_speed(vib_6,V_SPD,H1_7,flag,start,4); vibrators_speed(vib_7,V_SPD,H1_7,flag,start,5); vibrators_speed(vib_8,V_SPD,H8_12,flag,start,6); vibrators_speed(vib_9,V_SPD,H8_12,flag,start,7); vibrators_speed(vib_10,V_SPD,H8_12,flag,start,0); vibrators_speed(vib_11,V_SPD,H8_12,flag,start,1); vibrators_speed(vib_12,V_SPD,H8_12,flag,start,2); vibrators_speed(C_vib,C_SPD,1,flag,start,0); basket_M(start,H1_7,1, 0,m_high_1, prx_H_1); } }

[image] Read this before posting a programming question ... Programming 1. Arduino programming language The Arduino basically uses the industry-standard C++ language, implemented by the GNU g++ compiler. For information on basic things like loops, strings, functions, data types, and so on try consulting one of the many online C++ references. Hint: Google "C++ tutorial". The main sketch is C++, however the IDE does do a certain amount of pre-processing (in particular, generating function prototypes for you) before submitting the code to the main C++ compiler (see …

You’re loosely heading in the right direction, but handling things the way you are, I’d suggest reading up on arrays, pointers and arduino serial comms.

Too much code, too few comments.

Oh my... please read this. array - Arduino Reference The Arduino programming language Reference, organized into Functions, Variable and Constant, and Structure keywords.

look i have 24 motor and 24 proximity switch one for every motor what is the wrong with this code forgive this my 1st project with arduino im PLC programmer

[image] mohamed_elbardiny: 24 motor and 24 proximity Make an object to handle their activites via a service simply.

Do you have experience with programming in C++? The task can easily be realised with an object. A structured array contains all the information, such as the pin addresses for the I/O devices, as well as the information for the timing. A single service takes care of this information and initiates the intended action. The structured array makes the sketch scalable until all I/O pins are used up without having to adapt the code for the service. It is cool stuff, isn´t it?

thank you i get it like data block in plc , but this will solve the problem with the function

[image] mohamed_elbardiny: get it like data block in plc , but this will solve the problem with the function Yes, microcontrollers are quite different beasts than PLCs. A PLC typically has a uC inside, hidden by the PLC’s programming language. Start with the IDE examples, then as mentioned above, there are a lot of methods to help simplify and structure your program. The good news is that a C program will usually run an order of magnitude faster… or more. Use that advantage wisely! (no delay( etc!)

Problem with calling function

Projects Programming

paulpaulson February 17, 2023, 6:56am 2

Topic		Replies	Views
Arduino Sketch Gets Hung up in Function Call Programming	26	483	March 26, 2026
Two void functions with same code, one works, the other one doesnt Programming	28	1669	May 3, 2022
I do not read analog input with millis function Science and Measurement	33	661	October 29, 2024
Function exiting for unknown reason Programming	9	462	January 20, 2024
Functin ends itself when called arduino Displays	23	809	February 5, 2023

Problem with calling function

Related topics