Problem with code relay control

Using Arduino Programming Questions
1

helo world,
Im new in arduino and I do not understand problem with code
i want conrol 2 relays with 2 pushbuttons with state change memory
when press ones relay goes on and press agan relay goes off
one button for one relay

it work but not perfectly

// definira koji pin znaci sta

int r1 = 31;             // pin na arduino za signal releja 1
int r2 = 36;            // pin na arduino za signal releja 2
boolean latch = false;
       
# define pb1 31    // signal prekidaca za relej 1
# define pb2 35     // signal prekidaca za relej 2
# define r1 32
# define r2 36

void setup() {
  // put your setup code here, to run once:


  Serial.begin(9600); // used for debugging

  pinMode (32, OUTPUT);      // definira pin kao izlazni iz arduina
  digitalWrite (32, HIGH);    // definira inicijalno stanje pina
  pinMode (36, OUTPUT);
  digitalWrite (36, HIGH);
  pinMode (pb1, INPUT);    // definira pin kao ulazni u arduino
  pinMode (pb2, INPUT);

  Serial.println("Spreman!!!");     // pise poruku na serial monitor
}

void loop() {
  // put your main code here, to run repeatedly:

  // prvi relej

  if ((digitalRead(pb1) == HIGH) && (latch == false)) {
    digitalWrite(32, HIGH);
    Serial.println("r1 - ON");
    latch = true;
    while ((digitalRead(pb1) == HIGH)) {
      delay(50);
    }
  }
  if ((digitalRead(pb1) == HIGH) && (latch == true)) {
    digitalWrite(32, LOW);
    Serial.println("r1 - OFF");
    latch = false;
    while ((digitalRead(pb1) == HIGH)) {
      delay(50);
    }
  }

  // drugi relej

  if ((digitalRead(pb2) == HIGH) && (latch == false)) {
    digitalWrite(36, HIGH);
    Serial.println("r2 - ON");
    latch = true;
    while ((digitalRead(pb2) == HIGH)) {
      delay(50);
    }
  }
  if ((digitalRead(pb2) == HIGH) && (latch == true)) {
    digitalWrite(36, LOW);
    Serial.println("r2 - OFF");
    latch = false;
    while ((digitalRead(pb2) == HIGH)) {
      delay(50);
    }
  }

}

can you help me to fine code to work perfectly

2

error report is vague! what does it do?
what Arduino are you using?
post a schematic of the circuit showing power supplies etc

1 Like
3

What processor are you using? Look at Blink without delay and see how they turn the led on and off. Instead of time you will use a button.

2 Likes
4

hi
schematics is same like this but 2 relays and 2 buttons with resistors

1536×981 94.8 KB

arduino mega 2560

5

it is not working on every push of the button it need to be preset more times for on or off relay

6

Try with a separate latch control variable for each push button.

boolean latch_pb1 = false;
boolean latch_pb2 = false;
7

problem solved with build in exampels - digital - debounce

tnx for help

1 Like
8

Please post the code that solved your problem.

a7

9 
/*
  Debounce

  Each time the input pin goes from LOW to HIGH (e.g. because of a push-button
  press), the output pin is toggled from LOW to HIGH or HIGH to LOW. There's a
  minimum delay between toggles to debounce the circuit (i.e. to ignore noise).

  The circuit:
  - LED attached from pin 13 to ground through 220 ohm resistor
  - pushbutton attached from pin 2 to +5V
  - 10 kilohm resistor attached from pin 2 to ground

  - Note: On most Arduino boards, there is already an LED on the board connected
    to pin 13, so you don't need any extra components for this example.

  created 21 Nov 2006
  by David A. Mellis
  modified 30 Aug 2011
  by Limor Fried
  modified 28 Dec 2012
  by Mike Walters
  modified 30 Aug 2016
  by Arturo Guadalupi

  This example code is in the public domain.

  https://www.arduino.cc/en/Tutorial/BuiltInExamples/Debounce
*/

// constants won't change. They're used here to set pin numbers:
const int buttonPin = 2;    // the number of the pushbutton pin
const int ledPin = 13;      // the number of the LED pin

// Variables will change:
int ledState = HIGH;         // the current state of the output pin
int buttonState;             // the current reading from the input pin
int lastButtonState = LOW;   // the previous reading from the input pin

// the following variables are unsigned longs because the time, measured in
// milliseconds, will quickly become a bigger number than can be stored in an int.
unsigned long lastDebounceTime = 0;  // the last time the output pin was toggled
unsigned long debounceDelay = 50;    // the debounce time; increase if the output flickers

void setup() {
  pinMode(buttonPin, INPUT);
  pinMode(ledPin, OUTPUT);

  // set initial LED state
  digitalWrite(ledPin, ledState);
}

void loop() {
  // read the state of the switch into a local variable:
  int reading = digitalRead(buttonPin);

  // check to see if you just pressed the button
  // (i.e. the input went from LOW to HIGH), and you've waited long enough
  // since the last press to ignore any noise:

  // If the switch changed, due to noise or pressing:
  if (reading != lastButtonState) {
    // reset the debouncing timer
    lastDebounceTime = millis();
  }

  if ((millis() - lastDebounceTime) > debounceDelay) {
    // whatever the reading is at, it's been there for longer than the debounce
    // delay, so take it as the actual current state:

    // if the button state has changed:
    if (reading != buttonState) {
      buttonState = reading;

      // only toggle the LED if the new button state is HIGH
      if (buttonState == HIGH) {
        ledState = !ledState;
      }
    }
  }

  // set the LED:
  digitalWrite(ledPin, ledState);

  // save the reading. Next time through the loop, it'll be the lastButtonState:
  lastButtonState = reading;
}
10

THX.

I should have asked you to post the code you ended up with, that does two relays and everything.

So if you could, thanks.

a7