Short story - been using this code in wireless sensors for years - but today it failed to work after I made some additions to the 'sensor reading section' - compiled fine. It seems my choice of the 'pipe' as a delimiter (made years ago) is now the only character that strcat() is failing to do??? A…

Your msg[48] is an uninitialised variable; the terminating nul character that is needed by the str functions can be anywhere in RAM. Below will more than likely solve that problem char msg[48]; msg[0]='\0'; If it does not solve the problem, please post a representable example.

[image] sterretje: Your msg[48] is an uninitialised variable The code (pictured instead of posted, so hard to read), uses strcpy() to put an initial "1" into msg, which will properly terminate the char array. The code is not auto-formatted, so a bit hard to see that all the strcpy() and strc…

OOPS, missed that one. A good reason to post code as text.

Whatever the problem actually is, I don't think it's in the snippet you've shown. void packet_SEND1(int sbn, const char *id, double bv, const char *data) { Serial.println(F("packet_SEND1")); Serial.flush(); char n2a[10]; char msg[48]; char dlm[4]; strcpy(dlm, "|"); if( dat…

[image] Make experienced users help: two ways to quickly post code as a code-section Tutorials Hi newcomer, This thread wants to show you how you can speed-up getting helpful answers with small effort. If you manage at least to post this way. You have the sym…

it is very difficult to read the screen image of code in post 1 - as @sterretje recommends post code as text using code tags </> why not initialize your local variables when you define them, e.g. char msg[48]={0}; char dlm[4]="|";

Will try - I guess I thought that first strCPY("1") would do that.

Not going to ask why - just happy that @horace made me do it - because it's worked! And while I may speculate about what weird character may have been in the un-init'd msg[] that caused that - I'm also reminded that I used to code properly like that and I've just gotten sloppy. Kick in butt apprec…

You might have a bug somewhere in your code that causes the behaviour.

It really seems like an out-of-bounds write to an array somewhere else in the code, a stack overflow, etc, that is overwriting ram. Any change in the code moves the variables around and the problem will appear to go away.

Strcat() not doing the '|' pipe character ?

Projects Programming

StefanL38 November 18, 2024, 5:01am 6

Topic		Replies	Views
Serial read strncmp fails shortly after code runs Programming	11	105	May 18, 2026
Strcat changing the wrong variable Programming	3	679	October 27, 2021
Serial monitor problem when using strcat Programming	5	387	July 20, 2022
Problem using strcat function. Programming	3	636	April 10, 2020
Strcat (with MRE) Programming	6	180	May 2, 2024

Strcat() not doing the '|' pipe character ?

Related topics