Adding Millis to program in youtube

[1TonyM]

I have want to install the millis command in this program from youtube for button number one - the program is set up so when the first button is pressed the led comes on then to turn off I press the first button again - I want to only press the first button once then keep the led on only for 3 point 6 seconds -

This uses two arduino uno and two HC12 and it operates ok on this original program - Both arduinos use the same code for TX and rx - the only difference is that A4 is grounded on the rx arduino

here is the code

/*By Roee Bloch - Version 4

• This includes: Latch Mode, Momentary Mode (selected by A5 input), and also feedback to Transmitter that the Receiver got transmission OK - by LED on Transmitter
• Controls 4 logic output at 2 modes: Latch (each press change output ON/OFF), Momentary (output on just when button is pressed)
  *HC-12 Moule Transciever Same code is for Transmitter and Receiver, setup through A4 Input
  *Tested on Arduino Nano
• This SW is for Transmitter & Receiver, the choise is done by reading A4 & A5 inputs (analog inputs)
• A4=1=> TX, A4=0=>RX
• A5=1=>LATCH (Default mode), A5=0=>Momentary the stting now is via variable latch_logic if 1=> latch if 0=> momentary
• NANO connections to HC-12 As follows:
• ARDUINO NANO HC-12-MODULE

• ---

• 5V -> 1N4148 Anode, 1N4148 catode -> HC-12/Pin-1 (VCC)
• GND -------> GND
• D11 -------> RXD
• D10 -------> TXD
• NANO (TX MODULE) NANO (RX MODULE)

• ---

• D2 --> SW --> GND (SW1) A4 --> GND
• D3 --> SW --> GND (SW2) D2 --> OUTPUT 1
• D4 --> SW --> GND (SW3) D3 --> OUTPUT 2
• D5 --> SW --> GND (SW4) D4 --> OUTPUT 3

•                                       D5 --> OUTPUT 4
  

• FEEDBACK back will light Led on Trnasmitter for 100mS
• See connection Diagram here:
• https://goo.gl/photos/qog8gWPKpSDPgZen7

*/
#define P1 2
#define P2 3
#define P3 4
#define P4 5
#define F1 6 // feedback back to transmitter
//#define latch_logic 1 // if 1 then latch if 0 momentary

#include <SoftwareSerial.h>
SoftwareSerial mySerial(10, 11); // RX, TX
char latch; // , if latch=1 then Latch
int read_A4, read_A5, i, read_P1, read_P2, read_P3, read_P4;
int TX_CODE, RX_READ, mode, TX_CODE_OLD; //if mode= 1 then TX
int RP1, RP2, RP3, RP4;
volatile byte SW1 = 0, SW2 = 0, SW3 = 0, SW4 = 0;
boolean S1, S2, S3, S4;
byte TEST;
char TXTOSEND,feedback;
int FLAG=1,latch_logic;
void setup() {
Serial.begin(9600);
mySerial.begin(9600);
Serial.println("Hello HC-12 TX and RX SW, A4-Low=TX A4-HIGH=RX A5-LOW=Momemtary A5-HIGH=LATCH");
// mySerial.println("Hello HC-12 TX and RX SW, A4-Low=TX A4-HIGH=RX A5-LOW=Momemtary A5-HIGH=LATCH");
// This is for internal pull ups resistors on A4 and A5 Inputs

delay(500);
pinMode(A4, INPUT_PULLUP);
pinMode(A5, INPUT_PULLUP);
read_A4 = analogRead(A4);
read_A5 = analogRead(A5);
if ((read_A4) > 500) {
mode = 1;
Serial.println("TX Mode");
}
else
{
mode = 0;
Serial.println("RX Mode");
}

if ((read_A5) > 500) {
latch = 1;
latch_logic=latch;
Serial.println("LATCH Mode");
}
else
{
latch = 0;
latch_logic=latch;
Serial.println("Momentary Mode");
}

if (mode == 1) // TX
{
pinMode(P1, INPUT); // set pin to input
digitalWrite(P1, HIGH); // turn on pullup resistors
pinMode(P2, INPUT); // set pin to input
digitalWrite(P2, HIGH); // turn on pullup resistors
pinMode(P3, INPUT); // set pin to input
digitalWrite(P3, HIGH); // turn on pullup resistors
pinMode(P4, INPUT); // set pin to input
digitalWrite(P4, HIGH); // turn on pullup resistors
pinMode(F1, OUTPUT); // set pin to input
digitalWrite(F1, LOW);
}
else
{
pinMode(P1, OUTPUT); // set pin to input
digitalWrite(P1, LOW); // turn on pullup resistors
pinMode(P2, OUTPUT); // set pin to input
digitalWrite(P2, LOW); // turn on pullup resistors
pinMode(P3, OUTPUT); // set pin to input
digitalWrite(P3, LOW); // turn on pullup resistors
pinMode(P4, OUTPUT); // set pin to input
digitalWrite(P4, LOW); // turn on pullup resistors

}

}

void loop() {
if (mode == 1) //TX Mode
{
TX_MODE();
}
else
{
RX_MODE();
}

}

void TX_MODE()
{
while (1)
{
{
read_P1 = digitalRead(P1);
read_P2 = digitalRead(P2);
read_P3 = digitalRead(P3);
read_P4 = digitalRead(P4);

  TX_CODE = 64 + (read_P1 * 1) + (read_P2 * 2) + (read_P3 * 4) + (read_P4 * 8); // converting TX to one char
  TXTOSEND = TX_CODE; // conver to char for sending OK
  if (FLAG==0) // skip first time on FLAG=1
      {
      if (latch==1)
          {  
          if ((TX_CODE != TX_CODE_OLD)&&(latch_logic==1))  // transmit only on change
          {
            Serial.print(TX_CODE, BIN);
            mySerial.print(TXTOSEND);
          }
          delay(100);
          TX_CODE_OLD = TX_CODE;
          }
          else
          {
            Serial.print(TX_CODE, BIN);
            mySerial.print(TXTOSEND);
            delay(100);
          }
          
      }
  else FLAG=0;
}
feedback=mySerial.read();
if (feedback=='R')
{
Serial.println("Data_Sent_OK"); // feedback to serial port
digitalWrite(F1, HIGH);    // Ligjt Led Back on Transmitter
delay(80);
digitalWrite(F1, LOW);  
}

}
}

void RX_MODE()
{
while (1)
{
if (mySerial.available()) {
// read the incoming byte:

  RX_READ = mySerial.read();
  TEST = RX_READ;
  
  RP1 = (TEST) & (1);
  RP2 = (TEST) & (2);
  RP3 = (TEST) & (4);
  RP4 = (TEST) & (8);
 
  mySerial.flush();

  // When button is pressed (logic 0) toggling the apropriate LED Latch mode only
  if ((latch==1)&&(latch_logic==1))
  {
    if (RP1 == 0) SW1 = ~(SW1);  
    if (RP2 == 0) SW2 = ~(SW2); 
    if (RP3 == 0) SW3 = ~(SW3);      
    if (RP4 == 0) SW4 = ~(SW4);
     mySerial.print("R"); // This is feedback back to transmitter
  } 
      else // Momentary mode ON only when button is pressed continously
  {
    if (RP1 == 0) 
    {
      SW1 = 1;  
      mySerial.print("R"); // This is feedback back to transmitter
    } else SW1=0;
    if (RP2 == 0) 
    {
      SW2 = 1; 
      mySerial.print("R"); // This is feedback back to transmitter
    }  else SW2=0;
    if (RP3 == 0)
    {
      SW3 = 1;  
      mySerial.print("R"); // This is feedback back to transmitter
    } else SW3=0;    
    if (RP4 == 0)
    {
      SW4 = 1; 
      mySerial.print("R"); // This is feedback back to transmitter
    }  else SW4=0;
    
  }

//convert to bit for Digital-Out from Arduino
S1= SW1 & 1;
S2= SW2 & 1;
S3= SW3 & 1;
S4= SW4 & 1;

   digitalWrite(P1, S1);
   digitalWrite(P2, S2);
   digitalWrite(P3, S3);
   digitalWrite(P4, S4);
                 
  delay(100);
  Serial.print("S1=");
  Serial.print(SW1);
  Serial.print("  S2=");
  Serial.print(SW2);
  Serial.print("  S3=");
  Serial.print(SW3);
  Serial.print("  S4=");
  Serial.println(SW4);

}   

}
}

I would only need D2 to be set up with millis for 3.6 seconds for the present times and I would thing that the millis would only needed to be setup on the tx side - but I am not sure on how to add it into this program

In the future I would like to be able to use button number one and two (D2 and D3 to be able to be pressed for a different time seperately

Here is the url which may help

HC 12 Uart Transciever Part-3 Improved code – Sharing Code

HC 12 Uart Transciever Part-3 Improved code Video

Thanks in advance

Tony Magon - Sydney

[UKHeliBob]

@1TonyM

here is the code

Please follow the advice given in the link below when posting code. Use [color = red]code tags[/color] (the </> icon above the compose window) to make it easier to read and copy for examination

How to get the best out of this forum

See also FAQ - Arduino Forum for general rules on forum behavior and etiquette. Hello, Welcome to the Arduino Forum. This guide explains how to get the best out of this forum. Please read and follow the instructions below. Being new here you might think this is having rules for the sake of rules, but that is not the case. If you don’t follow the guidelines all that happens is there is a long exchange of posts while we try to get you to tell us what we need in order to help you, which is frus…

[6v6gt]

@1TonyM

I would only need D2 to be set up with millis for 3.6 seconds for the present times and I would thing that the millis would only needed to be setup on the tx side - but I am not sure on how to add it into this program

Maybe something like:

Replace this statement “read_P1 = digitalRead(P1);” in function void TX_MODE() with code which :

A) detects the button transitioning from “not pressed” to “pressed”.

B) sets a timer on the above status change. (Record current value of millis() )

C) also sets read_P1 to 1 on the status change.

D) checks if read_P1 has the value 1 and checks if the timer has expired (3.6 seconds). If so, read_P1 is set back to 0.

[1TonyM]

Hi 6V6GT

You must be a valve man like me (in my early days)

Thanks for the info - will have a good look at this tomorrow

Tony VK2IC