Can some one help me with my code

Using Arduino Programming Questions
#1

i was trying to make a guessing game and I got all the code in but it gave me an error error: expected initializer before 'if'
exit status 1
void loop()

if(Serial.available()>0){
guess = Serial.read();
Serial.print("Your guess ");
Serial.println(guess);

guess=guess-48;
#2

You might be missing a semicolon somewhere, but without seeing more of the code it'll be hard to pinpoint the error.

Try looking at the error message for a line indicator (something like programName:x:y: error: ..., then go to line x and look around for missing punctuation or other synthax errors.

#3

You seem to be missing the '{' that marks the start of the body of loop().

#4

il try that

#5

here is the full code

char guess;
int secret_num=random(0, 9);

void setup(){
Serial.begin(9600);
pinMode(13, OUTPUT);
pinMode(11, OUTPUT);
pinMode(9, OUTPUT);
Serial.println("Istructions: Guess numbers form 0to9");
Serial.println();
}

void loop(){

if(Serial.available()>0){
guess = Serial.read();
Serial.print("Your guess ");
Serial.println(guess);

guess=guess-48;

if(guess > secret_num){
Serial.println("too high!");
digitalWrite(13,high);
Serial.println("Guess again:");
delay(300);
digitalWrite(13,LOW);
}

else if (guess < secret_num){
Serial.println("Too low!");
digitalWrite(11,high);
Serial.println("Guess again:");
delay(300);
digitalWrite(11,LOW);
}
else{
Serial.println("Correct!");
digitalWrite(9,high);
delay(300);
digitalWrite(9,LOW);

}
}

#6

after adding the { i got more errors
In function 'void loop()':
27:21: error: 'high' was not declared in this scope
27:21: note: suggested alternative: 'sinh'
35:21: error: 'high' was not declared in this scope
35:21: note: suggested alternative: 'sinh'
42:20: error: 'high' was not declared in this scope
42:20: note: suggested alternative: 'sinh'
47:2: error: expected '}' at end of input
exit status 1

#7

This gives you a value from 0 to 8. The high limit is not included. Since you don't give the random number generator a new seed, it will always produce the same sequence of numbers.

#8

so how do i fix it do i right num=random(0, 10)

#9

Yes. Exactly.

#10

Did you change high in these digitalWrite()s to HIGH?

#11

ok il try

#12

this is the only error that is apering
In function 'void loop()':
47:2: error: expected '}' at end of input
exit status 1

#13

There's a few errors in the code

  1. The HIGH value used in digitalWrite() should be in all caps, otherwise the compiler will look for a variable named high.
  2. You're missing a closing bracket ( } ) after
else {
      Serial.println("Correct!");
      digitalWrite(9, HIGH);
      delay(300);
      digitalWrite(9, LOW);
  1. The quotation marks used in most print() functions (“ and ”) should be ".

With these changes the code does compile, but I haven't tested it for functionality.

#14

i did wnat you said but i still get one error
In function 'void loop()':
46:2: error: expected '}' at end of input
exit status 1

#15

Post the code you have now.

#16 
char guess;
int secret_num=random(0, 10);
  
void setup(){
  Serial.begin(9600);
  pinMode(13, OUTPUT);
  pinMode(11, OUTPUT);
  pinMode(9, OUTPUT);
  Serial.println("Istructions: Guess numbers form 0to9");
  Serial.println();
}

void loop(){

  if(Serial.available()>0){    <<<< this needs a mating }
  	guess = Serial.read();
  	Serial.print("Your guess ");
  	Serial.println(guess);

  	guess=guess-48;

  if(guess > secret_num){
    Serial.println("too high!");
    digitalWrite(13,HIGH);
    Serial.println("Guess again:");
    delay(300);
    digitalWrite(13,LOW);
  }
  
  else if (guess < secret_num){
    Serial.println("Too low!");
    digitalWrite(11,HIGH);
    Serial.println("Guess again:");
    delay(300);
    digitalWrite(11,LOW);
  }
  else{
    Serial.println("Correct!");
    digitalWrite(9,HIGH);
    delay(300);
    digitalWrite(9,LOW);
   }
 }
#17

See the note I added in the code

#18

this code should work right

#19

Here is a version that only allows 4 guesses and starts a new game when the game ends. (Hint: If you do a binary search you will always win in 4 moves or fewer.)

int SecretNumber = random(0, 10);

const byte TooHighLEDPin = 13;
const byte TooLowLEDPin = 11;
const byte CorrectLEDPin = 9;

void setup()
{
  Serial.begin(9600);
  pinMode(TooHighLEDPin, OUTPUT);
  pinMode(TooLowLEDPin, OUTPUT);
  pinMode(CorrectLEDPin, OUTPUT);
  Serial.println("Instructions: Guess numbers form 0 to 9");
  Serial.println();
}

void loop()
{
  static int errorCount = 0;

  if (Serial.available() > 0)
  {
    int guess = Serial.read() - '0';
    Serial.print("Your guess ");
    Serial.println(guess);

    if (guess > SecretNumber)
    {
      errorCount++;
      Serial.println("too high!");
      digitalWrite(TooHighLEDPin, HIGH);
      Serial.println("Guess again:");
      delay(300);
      digitalWrite(TooHighLEDPin, LOW);
    }
    else if (guess < SecretNumber)
    {
      errorCount++;
      Serial.println("Too low!");
      digitalWrite(TooLowLEDPin, HIGH);
      Serial.println("Guess again:");
      delay(300);
      digitalWrite(TooLowLEDPin, LOW);
    }
    else
    {
      Serial.println("Correct!");
      digitalWrite(CorrectLEDPin, HIGH);
      delay(300);
      digitalWrite(CorrectLEDPin, LOW);

      // Start a new game
      Serial.println();
      Serial.println("Instructions: Guess numbers form 0 to 9");
      Serial.println();
      errorCount = 0;
      SecretNumber = random(0, 10);
    }

    if (errorCount > 4)
    {
      Serial.println("Too many guesses.  You lose.");
      digitalWrite(TooHighLEDPin, HIGH);
      digitalWrite(TooLowLEDPin, HIGH);
      delay(300);
      digitalWrite(TooHighLEDPin, LOW);
      digitalWrite(TooLowLEDPin, LOW);

      // Start a new game
      Serial.println();
      Serial.println("Instructions: Guess numbers form 0 to 9");
      Serial.println();
      errorCount = 0;
      SecretNumber = random(0, 10);
    }
  }
}
#20