CurieTimer1Interrupt sketch example bugs

packetmax · January 3, 2017, 9:15pm

I just got round to getting a couple of 101's going and noticed that the named example sketch uses type int to express microsecond multiples. Change both vars oneSecInUsec and time (bad naming choice) to long int and you're good to go.

facchinm · January 4, 2017, 9:07am

Hi @packetmax,
would you mind opening an issue (or a pull request) on the development repo? This would ensure that the issue doesn't get lost in this thread forever

The example is here:

github.com

arduino/ArduinoCore-arc32/blob/master/libraries/CurieTimerOne/examples/CurieTimer1Interrupt/CurieTimer1Interrupt.ino

/*
  Sketch: Timer1Interrupt.ino

  This sketch demonstrates the usage of the Curie Timer One Library.
  It uses timer-1 to blink the onboard LED, pin 13, at different
  intervals (speed) in four steps.

  You can see the time interval and the number of interrupt counted
  in 10 seconds if you keep serial logging active, but this may require
  a MASTER_RESET to reprogram the board. 

  Blinking of the LED will start only when you open the  Serial Monitor
  unless you comment the "#define SERIAL_PORT_LOG_ENABLE 1"; don't
  forget to uncomment "CurieTimerOne.restart(time);"

  created by Intel
  Modified 14 March 2016
  by Simone Majocchi

  This example code is in the public domain.

This file has been truncated. show original

Thanks!

packetmax · January 4, 2017, 9:14pm

Glad to oblige--done.

enyquist · January 4, 2017, 11:52pm

FYI the corresponding issue on Github is here CurieTimer1Interrupt example sketch bugs · Issue #390 · arduino/ArduinoCore-arc32 · GitHub

Not strictly a bug, by which I mean the example sketch works as expected, since an 'int' is 4 bytes in this case.
However, packetmax is right to mention it, we probably should be using a long here regardless. I've closed the issue but I'll be making the change as well.

system · May 6, 2021, 6:04pm