Help me with that elevator

Selahattin092 · August 30, 2023, 3:47pm

I have to make a simple elevator with arduino but i cant find a good source for get help to make it. I got an github address that a guy make the elevator and shared the circuit diagram and codes. I made that project, than the elevator didn't work perfectly. Please help me what is wrong with codes or circuit
GitHub - AlieksieievYurii/Elevator: The project "Elevator" is constructed on platform Arduino

sterretje · August 30, 2023, 3:51pm

Please describe what "didn't work perfectly" means.

Are you referring to just the elevator sketch or to just the panel sketch or the combination of the two.

Selahattin092 · August 30, 2023, 3:53pm

There is a code for make elevator calibrate first. Cabin of elevator goes to floor 1 for calibrate. Only it works than nothing happens. Only floor leds light ups when i press buttons of floors

Railroader · August 30, 2023, 4:02pm

"Tbere is a code for calibration"... How do You expect us to have an idea from Your post? We are not mindreaders.

Selahattin092 · August 30, 2023, 4:12pm

#include<Stepper.h>
#include <Wire.h> 
#include <LiquidCrystal_I2C.h>

/////INIT hardware part////
#define CALL_BUTTONS A1    //--------Here is connection buttons of colling elevator
#define FLOOR_SENSORS A0   //--------Here is connection sensors which are localed on floors
#define CALIBRATION_SENSOR 2 //------Here is connected button for instalation the elevator on first floor
///////////////////////////
#define DEFAULT_SPEED 300 // Default speed of elevator
#define SLOW_SPEED 150  // Default speed of elevator when it is landing
#define N 4 //Number of floor

////////Flags of moving the elevator//////////
#define MOVING_UP 1 //This flag means that the elevator is moving up
#define MOVING_DOWN -1 //This flag means that the elevator is moving down
#define NOT_MOVING 0
/////////////////////////////////////////////

#define NOT -1

///////COMANDS FOR PANEL_CONTROL ///////
#define ELEVATOR_IS_ERIVED 1

////////////////Init motor///////////////////////
unsigned short stepsPerRevolution = 64;
Stepper myStepper(stepsPerRevolution, 8,10,9,11); // Conected Step motor
/////////////////////////////////////////////////

LiquidCrystal_I2C lcd(0x27,16,2);//Connected LDC display

short registeredFloor;
short arrayFloor[N] = {-1,-1,-1,-1};
short ledFloor[N] = {7,6,5,4};
short executableFloor = NOT; // -1 it means not called floors
boolean canWork = false;
boolean landed = false;
boolean waitForNext = true;
short flagMoving = NOT_MOVING;
short calledFloorFromCabine = NOT;


boolean flagPressSameBtn = true;

void setup() {
   Serial.begin(9600);
  pinMode(CALL_BUTTONS,INPUT);
  pinMode(FLOOR_SENSORS,INPUT);
  pinMode(CALIBRATION_SENSOR, INPUT);
  
  for(byte i = 0; i < N; i++)
    pinMode(ledFloor[i],OUTPUT);
  
  myStepper.setSpeed(DEFAULT_SPEED);

  lcd.begin();                            
  lcd.backlight();                     
  printInf();
  calibration();
}
void loop() 
{
  readComFromPanelControl();   
  
  registerFloor();
  writeTurn();

  if(waitForNext && canWork)
    nextFloor(); 
 
  if(executableFloor != NOT && canWork)
    moveElevator();
    
  delay(10);
}

void nextFloor()
{ 
  
  if(calledFloorFromCabine != NOT && calledFloorFromCabine != registeredFloor )
  {
    executableFloor = calledFloorFromCabine;
    landed = false;
    waitForNext = false;
    return;
  }

  if(arrayFloor[0] == NOT)
  {
    for(byte i = 0; i < N; i++)
    {
      swipeArray(arrayFloor);
      if(arrayFloor[0] != NOT)
        break;
    }
  }
    executableFloor = arrayFloor[0];

    if(executableFloor != NOT)
    {
      swipeArray(arrayFloor);
      landed = false;
      waitForNext = false;
    }

}

void swipeArray(short * arrayFloor){
  for(byte i = 0; i < N - 1; i++)
    arrayFloor[i] = arrayFloor[i+1];
  arrayFloor[N-1] = NOT;  
}

void moveElevator()
{

   if(executableFloor == registeredFloor && !landed)
  {
    if(flagMoving == MOVING_UP)
      moveUpMiddle();
    else if(flagMoving == MOVING_DOWN)
       moveDownMiddle();
       
    ElevatorErrived(executableFloor);
    return;    
  }
    
  if(executableFloor > registeredFloor)
  {
    moveUp();
    flagMoving = MOVING_UP;
  }else if(executableFloor < registeredFloor)
  {
    moveDown();
    flagMoving = MOVING_DOWN;
  }
}

void ElevatorErrived(short errivedOnFloor)
{

  for(byte i = 0; i < N; i++)
    if(arrayFloor[i] == errivedOnFloor)
        arrayFloor[i] = NOT;

  executableFloor = NOT;
  turnOffLedOnFloor(errivedOnFloor);
  sendCommandToPanelControl(ELEVATOR_IS_ERIVED);
  flagMoving = NOT_MOVING;
  waitForNext = true;
  
  if(calledFloorFromCabine == registeredFloor)
    calledFloorFromCabine = NOT;
    
  landed = true;
  canWork = false;
}

void turnOffLedOnFloor(short errivedOnFloor)
{
  digitalWrite(ledFloor[errivedOnFloor-1],LOW);
}

void writeTurn()
{ 
  short localCalledFloorExpected = calledFloor();
 
  ///////if we call the elevator on floor wheme we are, elevator will just send command to the cabin for opening door
  if( (localCalledFloorExpected == registeredFloor && flagPressSameBtn && executableFloor == NOT) || 
      (calledFloorFromCabine == registeredFloor && executableFloor == NOT && flagPressSameBtn ))
  {
    digitalWrite(ledFloor[localCalledFloorExpected - 1],HIGH);
    delay(10);
    digitalWrite(ledFloor[localCalledFloorExpected - 1],LOW);
    sendCommandToPanelControl(ELEVATOR_IS_ERIVED);
    calledFloorFromCabine = NOT;
    flagPressSameBtn = false;
    return;
  }

  ///here we create queue calling the elevator
  if(localCalledFloorExpected != NOT)
  {
    if(executableFloor == NOT && localCalledFloorExpected == registeredFloor)
      return;

    //if called floor is in queue, it will not add to queue again
    for (byte i = 0; i < 4;i++)
      if (localCalledFloorExpected == arrayFloor[i])
          return;
          
      for (byte i = 0; i < 4; i++)
        if (arrayFloor[i] == -1)
        {
          arrayFloor[i] = localCalledFloorExpected;
          digitalWrite(ledFloor[abs(localCalledFloorExpected)-1],HIGH);// Turn on led on floor which called
          return;
        }
  }
}
void calibration()
{
  for (byte i = 0; i < N; i++)
    digitalWrite(ledFloor[i], HIGH);
  lcd.setCursor(0,0); 
  lcd.print("  CALIBRATION...");
  
  while(!digitalRead(CALIBRATION_SENSOR))
    myStepper.step(-10);
    
  for (byte i = 0; i < N; i++)
    digitalWrite(ledFloor[i], LOW);
    
  registeredFloor = 1;  
  lcd.clear();
  lcd.print("Floor:1");
}

void moveUp()
{
  myStepper.step(50);
}

void moveUpMiddle()
{
  myStepper.setSpeed(SLOW_SPEED);

  switch(registeredFloor)
  {
    case 2:
      myStepper.step(950);
      break;
    case 3:
      myStepper.step(900);
      break;
    case 4:
      myStepper.step(900);
      break;
  }
  myStepper.setSpeed(DEFAULT_SPEED);
}

void moveDownMiddle()
{
  myStepper.setSpeed(SLOW_SPEED);
  switch(registeredFloor)
  {
    case 1:
      myStepper.step(-700);
      break;
    case 2:
      myStepper.step(-950);
      break;
    case 3:
      myStepper.step(-950);
      break;
    case 4:
      myStepper.step(-650);
      break;
  }
  myStepper.setSpeed(DEFAULT_SPEED);
}

void moveDown()
{
  myStepper.step(-50);
}

void registerFloor()
{
  unsigned short value = analogRead(FLOOR_SENSORS);
  short bufRegisteredFloor = 0;
  if(value >= 221 && value <= 231) bufRegisteredFloor = 4;
  else if(value >= 300 && value <= 310) bufRegisteredFloor = 3;
  else if(value >= 395 && value <= 405) bufRegisteredFloor = 2;
  else if(value >= 691 && value <= 701) bufRegisteredFloor = 1;
  
  if(bufRegisteredFloor != 0 && bufRegisteredFloor != registeredFloor)
  {
    registeredFloor = bufRegisteredFloor;
    printFloor();
  }
}

short calledFloor()
{
  short value = analogRead(CALL_BUTTONS);

  if(value >= 85 && value <= 95) return 4;
  else if(value >= 333 && value <= 345) return 3;
  else if(value >= 175 && value <= 185) return 3;
  else if(value >= 505 && value <= 515) return 2;
  else if(value >= 402 && value <= 412) return 2;  
  else if(value >= 670 && value <= 705) return 1;
  else return NOT;
  
}

void printFloor()
{
  lcd.clear();
  lcd.setCursor(0,0);
  lcd.print("Floor:");
  lcd.print(registeredFloor);
}

void printInf()
{
  lcd.print("    Elevalor");
  lcd.setCursor(0,1);
  lcd.print("Y.Alieksieiev");
  delay(3000);
  //lcd.setCursor(0,1);
  //lcd.println("S.Michalewski   ");
  //delay(2000);
  lcd.clear();
}

void sendCommandToPanelControl(short command)
{
  char str[2] = {'0','0'};
  switch(command)
  {
    case ELEVATOR_IS_ERIVED:
      str[0] = 'e';
      str[1] = 'f';
        break;    
  }

  Serial.write(str,2);
}

void readComFromPanelControl()
{
  if(!Serial.available())
    return;

    byte i = 0;
    char str[2] = {'0','0'};
    delay(100);
    while(Serial.available())
      str[i++] = Serial.read();  

   if(str[0] == 'd' && str[1] == 'o')
    canWork = false;
   else if(str[0] == 'd' && str[1] == 'c')
   {
    canWork = true;
    flagPressSameBtn = true;
   }else if(str[0] == 'c')
   {
      calledFloorFromCabine = str[1] - '0';
   }
}

here is all the code

Railroader · August 30, 2023, 4:30pm

What is that code doing and what should it do?
That calbration reads nothing and stores/notes noting.

Paul_KD7HB · August 30, 2023, 5:52pm

Does that code compile with no errors?

Selahattin092 · August 31, 2023, 3:47pm

you can open the github link to see what should it do
GitHub - AlieksieievYurii/Elevator: The project "Elevator" is constructed on platform Arduino

jremington · August 31, 2023, 3:50pm

I imagine the point of your assignment is to do the work yourself, and learn something in the process.

Railroader · August 31, 2023, 4:20pm

You do that and give the short story!
I'm sure the link doesn't tell what Your setup actually does.

Selahattin092 · August 31, 2023, 4:44pm

i did that project but it doesnt works. And im 14 if you wanna know i dont go to university yet.

gilshultz · August 31, 2023, 4:52pm

If you do not understand these basic courses and do the work you will fail before you finish. HINT: Generate a flow diagram first then code to that. Update as needed.

jremington · August 31, 2023, 5:07pm

Please describe the project goals.

Selahattin092 · August 31, 2023, 5:53pm

i want to make that elevator to present it on youtube for how to make it

paulpaulson · August 31, 2023, 6:04pm

Hello Selahattin092

Welcome to the worldbest forum.

This is a nice project to get started.

Take a piece of paper, a pencil and design, based on the IPO model, a program structure plan before start coding.
Identify functions and their depencies. Now start with coding and testing, function by function.
At the end merge all tested function together to get the final sketch.
The basics for coding the project are to be found in the IDE as examples.

Have a nice day and enjoy coding in C++.

xfpd · September 2, 2023, 5:15pm

Show (draw pictures - use original schematic) and tell (describe your observations) the parts that ARE working and the parts NOT working.

The link/source/project you show is too complex for now. Here is a "plan" to follow for a simple elevator:

When you turn on the project, it "homes" the elevator (a motor) to floor zero, stopping only when the floor-stop switch is pressed.
When the first button is pressed on any floor, a blue "call" LED lights and the elevator (motor) goes to that floor until the floor-stop switch is pressed.
At every called floor, light an LED and open the door (servo).
After that works, expand to storing the sequence of many buttons pressed, for example, 0, 3, 1.

system · February 29, 2024, 5:15pm

This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
simple elevator with arduino Programming Questions	3	1353	May 5, 2021
making a three floor elevator need help please Project Guidance	5	1152	May 5, 2021
Elevator code - will it work? Programming Questions	10	712	May 6, 2021
I can`t code! Programming Questions	6	885	May 6, 2021
New Project Project Guidance	9	1898	May 5, 2021

Help me with that elevator

Related Topics