is something wrong with my code

Development Tools IDE 1.x
1

I'm programming a tachometer for a race car and I'm using a nano board. I downloaded the program onto the board with no issues. When I plug it into the circuit all of my digital outputs are high no matter what my input at A1 is. Can anyone help me??

const int RPM = A1;
const int RTHRESH1=96;
const int RTHRESH2=192;
const int RTHRESH3=288;
const int RTHRESH4=384;
const int RTHRESH5=480;
const int RTHRESH6=576;
const int RTHRESH7=672;
const int RTHRESH8=768;
const int RTHRESH9=864;
const int RTHRESH10=960;
const int RTHRESH11=999;

const int RLED1=4;
const int RLED2=5;
const int RLED3=6;
const int RLED4=7;
const int RLED5=8;
const int RLED6=9;
const int RLED7=10;
const int RLED8=11;
const int RLED9=12;
const int RLED10=13;

int timer=100;

void setup(){
pinMode(RLED1, OUTPUT);
pinMode(RLED2, OUTPUT);
pinMode(RLED3, OUTPUT);
pinMode(RLED4, OUTPUT);
pinMode(RLED5, OUTPUT);
pinMode(RLED6, OUTPUT);
pinMode(RLED7, OUTPUT);
pinMode(RLED8, OUTPUT);
pinMode(RLED9, OUTPUT);
pinMode(RLED10, OUTPUT);

Serial.begin(1000);
}

void loop(){

for(int t=100; t>=0; t--){
int RPMVALUE = analogRead(RPM);
if (RPMVALUE<=RTHRESH1){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, LOW);
digitalWrite(RLED3, LOW);
digitalWrite(RLED4, LOW);
digitalWrite(RLED5, LOW);
digitalWrite(RLED6, LOW);
digitalWrite(RLED7, LOW);
digitalWrite(RLED8, LOW);
digitalWrite(RLED9, LOW);
digitalWrite(RLED10, LOW);
}
if (RTHRESH1<RPMVALUE<=RTHRESH2){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, HIGH);
digitalWrite(RLED3, LOW);
digitalWrite(RLED4, LOW);
digitalWrite(RLED5, LOW);
digitalWrite(RLED6, LOW);
digitalWrite(RLED7, LOW);
digitalWrite(RLED8, LOW);
digitalWrite(RLED9, LOW);
digitalWrite(RLED10, LOW);
}
if (RTHRESH2<RPMVALUE<=RTHRESH3){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, HIGH);
digitalWrite(RLED3, HIGH);
digitalWrite(RLED4, LOW);
digitalWrite(RLED5, LOW);
digitalWrite(RLED6, LOW);
digitalWrite(RLED7, LOW);
digitalWrite(RLED8, LOW);
digitalWrite(RLED9, LOW);
digitalWrite(RLED10, LOW);
}
if (RTHRESH3<RPMVALUE<=RTHRESH4){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, HIGH);
digitalWrite(RLED3, HIGH);
digitalWrite(RLED4, HIGH);
digitalWrite(RLED5, LOW);
digitalWrite(RLED6, LOW);
digitalWrite(RLED7, LOW);
digitalWrite(RLED8, LOW);
digitalWrite(RLED9, LOW);
digitalWrite(RLED10, LOW);
}
if (RTHRESH4<RPMVALUE<=RTHRESH5){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, HIGH);
digitalWrite(RLED3, HIGH);
digitalWrite(RLED4, HIGH);
digitalWrite(RLED5, HIGH);
digitalWrite(RLED6, LOW);
digitalWrite(RLED7, LOW);
digitalWrite(RLED8, LOW);
digitalWrite(RLED9, LOW);
digitalWrite(RLED10, LOW);
}
if (RTHRESH5<RPMVALUE<=RTHRESH6){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, HIGH);
digitalWrite(RLED3, HIGH);
digitalWrite(RLED4, HIGH);
digitalWrite(RLED5, HIGH);
digitalWrite(RLED6, HIGH);
digitalWrite(RLED7, LOW);
digitalWrite(RLED8, LOW);
digitalWrite(RLED9, LOW);
digitalWrite(RLED10, LOW);
}
if (RTHRESH6<RPMVALUE<=RTHRESH7){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, HIGH);
digitalWrite(RLED3, HIGH);
digitalWrite(RLED4, HIGH);
digitalWrite(RLED5, HIGH);
digitalWrite(RLED6, HIGH);
digitalWrite(RLED7, HIGH);
digitalWrite(RLED8, LOW);
digitalWrite(RLED9, LOW);
digitalWrite(RLED10, LOW);
}
if (RTHRESH7<RPMVALUE<=RTHRESH8){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, HIGH);
digitalWrite(RLED3, HIGH);
digitalWrite(RLED4, HIGH);
digitalWrite(RLED5, HIGH);
digitalWrite(RLED6, HIGH);
digitalWrite(RLED7, HIGH);
digitalWrite(RLED8, HIGH);
digitalWrite(RLED9, LOW);
digitalWrite(RLED10, LOW);
}
if (RTHRESH8<RPMVALUE<=RTHRESH9){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, HIGH);
digitalWrite(RLED3, HIGH);
digitalWrite(RLED4, HIGH);
digitalWrite(RLED5, HIGH);
digitalWrite(RLED6, HIGH);
digitalWrite(RLED7, HIGH);
digitalWrite(RLED8, HIGH);
digitalWrite(RLED9, HIGH);
digitalWrite(RLED10, LOW);
}
if (RTHRESH9<RPMVALUE<=RTHRESH10){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, HIGH);
digitalWrite(RLED3, HIGH);
digitalWrite(RLED4, HIGH);
digitalWrite(RLED5, HIGH);
digitalWrite(RLED6, HIGH);
digitalWrite(RLED7, HIGH);
digitalWrite(RLED8, HIGH);
digitalWrite(RLED9, HIGH);
digitalWrite(RLED10, HIGH);
}
if (RPMVALUE>RTHRESH10){
if(RLED1==LOW){
digitalWrite(RLED1, HIGH);
digitalWrite(RLED2, HIGH);
digitalWrite(RLED3, HIGH);
digitalWrite(RLED4, HIGH);
digitalWrite(RLED5, HIGH);
digitalWrite(RLED6, HIGH);
digitalWrite(RLED7, HIGH);
digitalWrite(RLED8, HIGH);
digitalWrite(RLED9, HIGH);
digitalWrite(RLED10, HIGH);
}
else{
digitalWrite(RLED1, LOW);
digitalWrite(RLED2, LOW);
digitalWrite(RLED3, LOW);
digitalWrite(RLED4, LOW);
digitalWrite(RLED5, LOW);
digitalWrite(RLED6, LOW);
digitalWrite(RLED7, LOW);
digitalWrite(RLED8, LOW);
digitalWrite(RLED9, LOW);
digitalWrite(RLED10, LOW);
}
}
}
}

2

Why did you put a title of "troubling uploading program" when you said it uploads with no problem?

Anyway, your problem is this:

RTHRESH1<RPMVALUE<=RTHRESH2

RTHRESH1 < RPMVALUE returns either a true or a false - a 1 or a 0. RTHRESH2 is likely to be greater than or equal to that isn't it?

You have to do something like this:

if (RTHRESH1 < RPMVALUE && RPMVALUE <= RTHRESH2)

Also, it sounds like you need to learn about arrays. And variable names in ALL CAPITALS generally mean they're #define'd constants. Good coding standards usually say you shouldn't use them for actual variables.