Version: 2.0.0-rc4-nightly.20220218-nightly-20220218
Date: 2022-02-18T03:03:41.643Z
CLI Version: 0.21.0 [10107d24]
Copyright © 2022 Arduino SVersion: 2.0.0-rc4-nightly.20220218-nightly-20220218
Date: 2022-02-18T03:03:41.643Z
CLI Version: 0.21.0 [10107d24]
Windows 10
Auto save turned off in Preferences
File/New
Revise the sketch
File/Quit
No prompt to save the revised sketch
This may be related to the fix to the inverted logic of the unsaved file dialogue as previously reported. See Unsaved file dialogue on exit
1 Like
Thanks @UKHeliBob !
I am able to reproduce the bug. I see it was introduced here:
committed 02:25PM - 11 Feb 22 UTC
Would you like to submit the formal bug report to the issue tracker ?
I'm not aware of any work that has been done on that issue . Sometimes it is difficult to track the development because some of it is happening in the VS Code code base , and some of it in the Eclipse Theia code base , which are huge very active projects. The changes made there are introduced all at once when the version of Theia in use by Arduino IDE is bumped, which is the change change that caused this bug you reported, as well as several others.
I can't tell whether the dialog has changed because it appears to now be impossible to trigger that dialog.
Hi @UKHeliBob . Since I didn't hear back from you, and wanted to make sure this is properly tracked, I went ahead and submitted a formal bug report to the IDE developers:
opened 04:23AM - 24 Feb 22 UTC
closed 08:55AM - 01 Jun 22 UTC
conclusion: resolved
topic: code
type: imperfection
criticality: highest
## Describe the bug
Unsaved changes to the sketch will be lost when closing t… he window. For this reason, the IDE must request confirmation from the user before proceeding, as is the standard convention for any application.
🐛 The IDE closes without confirmation even when the sketch has unsaved changes. This may cause loss of data for users who expect the standard "save and quit" behavior.
## To Reproduce
1. Open any sketch.
1. Select **File > Preferences...** from the Arduino IDE menus.
1. Uncheck the box next to "**🗹 Auto save**".
1. Click the <kbd>OK</kbd> button.
1. Make any change to the sketch.
❗ Do not save the sketch.
1. Select **File > Close** from the Arduino IDE menus.
🐛 The window closes immediately and all unsaved changes are lost.
## Expected behavior
Confirmation dialog when closing IDE window with unsaved changes.
## Desktop
### Original
- OS: Windows 10, Ubuntu 20.04
- Version: 2.0.0-rc4-snapshot-0207778
Date: 2022-02-23T15:40:32.443Z
CLI Version: 0.21.0 [10107d24]
### Last verified with
- OS: Windows 10, Ubuntu 20.04
- Version: 2.0.0-rc4-snapshot-70f1c5f
Date: 2022-03-09T10:47:19.505Z
CLI Version: 0.21.0 [10107d24]
## Additional context
I bisected the bug to https://github.com/arduino/arduino-ide/commit/112153fb965f63d952d126c8244cd3f84f0a1a1b (it does not occur when using the build from the previous commit https://github.com/arduino/arduino-ide/commit/69ac1f4779589d0d21ce3d37c180b3393ad6156c).
---
The bug occurs no matter which method you use to close the window:
- **File > Close**
- **File > Quit**
- Native window close control
---
The bug also occurs with new sketches that have unsaved changes when the sketch is closed by these methods:
- **File > Quit**
- Native window close control
(There is a dialog on **File > Close** with a new dirty sketch)
---
Originally reported by @UKHeliBob at https://forum.arduino.cc/t/no-prompt-to-save-a-modified-file-when-closing-the-ide/962323
Thanks for doing that Per. I had forgotten all about it
system
Closed
August 23, 2022, 7:43am
5
This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.