Programming RTC

Hello. I am programming my DS1307 with my Arduino. I have used the following source code:

// Written by John Boxall from http://tronixstuff.com

#include “Wire.h”
#define DS3231_I2C_ADDRESS 0x68
// Convert normal decimal numbers to binary coded decimal
byte decToBcd(byte val){
return( (val/1016) + (val%10) );
}
// Convert binary coded decimal to normal decimal numbers
byte bcdToDec(byte val){
return( (val/16
10) + (val%16) );
}
void setup(){
Wire.begin();
Serial.begin(9600);
// set the initial time here:
// DS3231 seconds, minutes, hours, day, date, month, year
setDS3231time(00,00,01,1,01,1,19);
}
void setDS3231time(byte second, byte minute, byte hour, byte dayOfWeek, byte
dayOfMonth, byte month, byte year){
// sets time and date data to DS3231
Wire.beginTransmission(DS3231_I2C_ADDRESS);
Wire.write(0); // set next input to start at the seconds register
Wire.write(decToBcd(second)); // set seconds
Wire.write(decToBcd(minute)); // set minutes
Wire.write(decToBcd(hour)); // set hours
Wire.write(decToBcd(dayOfWeek)); // set day of week (1=Sunday, 7=Saturday)
Wire.write(decToBcd(dayOfMonth)); // set date (1 to 31)
Wire.write(decToBcd(month)); // set month
Wire.write(decToBcd(year)); // set year (0 to 99)
Wire.endTransmission();
}
void readDS3231time(byte *second,
byte *minute,
byte *hour,
byte *dayOfWeek,
byte *dayOfMonth,
byte *month,
byte *year){
Wire.beginTransmission(DS3231_I2C_ADDRESS);
Wire.write(0); // set DS3231 register pointer to 00h
Wire.endTransmission();
Wire.requestFrom(DS3231_I2C_ADDRESS, 7);
// request seven bytes of data from DS3231 starting from register 00h
*second = bcdToDec(Wire.read() & 0x7f);
*minute = bcdToDec(Wire.read());
*hour = bcdToDec(Wire.read() & 0x3f);
*dayOfWeek = bcdToDec(Wire.read());
*dayOfMonth = bcdToDec(Wire.read());
*month = bcdToDec(Wire.read());
*year = bcdToDec(Wire.read());
}
void displayTime(){
byte second, minute, hour, dayOfWeek, dayOfMonth, month, year;
// retrieve data from DS3231
readDS3231time(&second, &minute, &hour, &dayOfWeek, &dayOfMonth, &month,
&year);
// send it to the serial monitor
Serial.print(hour, DEC);
// convert the byte variable to a decimal number when displayed
Serial.print(":");
if (minute<10){
Serial.print(“0”);
}
Serial.print(minute, DEC);
Serial.print(":");
if (second<10){
Serial.print(“0”);
}
Serial.print(second, DEC);
Serial.print(" “);
Serial.print(dayOfMonth, DEC);
Serial.print(”/");
Serial.print(month, DEC);
Serial.print("/");
Serial.print(year, DEC);
Serial.print(" Day of week: ");
switch(dayOfWeek){
case 1:
Serial.println(“Sunday”);
break;
case 2:
Serial.println(“Monday”);
break;
case 3:
Serial.println(“Tuesday”);
break;
case 4:
Serial.println(“Wednesday”);
break;
case 5:
Serial.println(“Thursday”);
break;
case 6:
Serial.println(“Friday”);
break;
case 7:
Serial.println(“Saturday”);
break;
}
}
void loop(){
displayTime(); // display the real-time clock data on the Serial Monitor,
delay(1000); // every second
}

It works perfectly fine with my DS1307.

Now, I would like to make a trigger-point with an if-statement. I want to (as an example) make an LED turn on everytime the second-pointer is at 20. Everytime the second-counter reaches 20, i would like to make the LED turn on.

I tried implementing it by writing:

int redPin = 2;

void setupLight(){

pinMode(redPin, HIGH)

}

So now I have the pin-number for the LED and made it high everytime the function will be called. But I’m having trouble making it work. I was thinking about writing something like this:

void loop(){

if (*second == 20){

setupLight();

}

Is this possible? It doesn’t work when I try to verify the code in the Arduino IDE.

Everytime the second-counter reaches 20, i would like to make the LED turn on.

This is an incomplete requirement, in that it doesn't define when the LED should turn off. Incomplete requirements are a bitch to write code for.

I was thinking about writing something like this


Don't. Think, instead, first about WHERE to add code.

Start with the working code. Understand what it does. loop() calls displayTime() which does a LOT more than its name implies. displayTime() gets the time and it displays the time.

Break that into two functions, with meaningful names. getTime() and displayTime() are good, but loop() needs to then call them both AND the variables that getTime() populates need to be accessible to displayTime().

Then, you can see that you can use those same variables to determine if it is time to turn the LED on.

if (*second == 20){I can't remember seeing that syntax before. What do you expect that line of code to do ?

UKHeliBob:
if (*second == 20){I can't remember seeing that syntax before. What do you expect that line of code to do ?

The function to read the time was (foolishly) defined to take pointers, not references. So, the way to say to store the data where the pointer points, instead of changing where the pointer points, is *pointer = newValue;.

Had the function be properly declared, using references, the usual variable = newValue; syntax would have applied.

Checks to see if the byte pointed to by pointer variable ‘second’ is equal to 20?

gfvalvo:
Checks to see if the byte pointed to by pointer variable 'second' is equal to 20?

Nasty !

UKHeliBob:
Nasty !

Not really, if you're still a pre C++ programmer :wink:

As an old-time C programmer (learned in college, mid 80s), I’m still a fan of pointers. References were added to C++ to solve specific issues that pointers couldn’t handle -- operator overloading, method chaining, etc. But, when I can get the job done with a good old pointer, I’ll choose that over a reference.

YMMV