sanity check before I remake my PCB(used multiplexer for absolutely no reason lmao) it looks good I was wondering if I should use resistors(nd I think 5v+) on the columns or just use input_pullup(I think is the command dont quote haha)
Components:
--38x Discount TL1240G illuminated tactile switch w/1N4148W Diodes
--1xRS16 Rotary switch[adafruit 2925](bottom right) ROTARY SYMBOL IS MODIFIED removing two pins lying outside the PCB area as they are not used and will be clipped off in the end use(image below)
--38x 140R 0805 Resistors for the LEDs
--Solderpads (in between pro micro and schem)
--Pro Micro added for easy reference(removed in update(pins are labeled))
Picture is 3348x3545, but displays smaller, you may have to click on it or open it in another tab to view in full size
wanted to add an update for anyone viewing this. After discussing with someone offline I've amended this portion of the schematic. while not technically necessary as I could have used Input_Pullup I wanted to ensure that I had no issues in the future and added pullup resistors at 4k7ohm on each coloumn.
It appears OK but I am not familiar with that switch and the data sheet I found did not show that pinout. It is best to post a link to technical information on hardware devices and even place a diagram of 1 switch as a reference for the others.
It's ok to connect the encoder's pushbutton to the button matrix, but getting it to work correctly with it's A & B terminals as part of the matrix may result in erratic behaviour. I would recommend prototyping the circuit and thorough testing before you design a PCB. The prototype doesn't have to include all 38 buttons, just a few connected to different rows & columns of the matrix.
So I cannot remove the other topic and in that one I was using a multiplexer before switching to a button matrix as suggested in that thread. In the future I will add datasheets, thats my bad.
To clarify the RS16s are not Rotary encoders they are 8 position rotary switches, which, with the diodes should be okay. I did end up testing just the basics (two buttons and a rotary) prior to continuing. Someone DMed me and we worked ot out there and I hadnt noticed responses here sorry for lack of response by me!
Yes the pinout on mine is modified as two of the pins will be snipped off and I couldnt get it to remove the through holes(its very close to the edge and was causing issues) and only three of the 8 pins are being used anyways(minus the common pin) thats my bad, I should have clarified that! I will add links in the future to prevent confusion next time!
