Time countdown bug - arduino nano

[fcgfilho]

This is an automatic incubator code, with a countdown for egg rolling. It turns out that the count that should be from an hour (00:59:59) to hours, minutes and seconds. Returns a wrong count, like: 1999H: 555M: 2222S.

//EGG INCUBATOR Version 1.0

//|------------------------------------------------------------------------------------------------------|//
//|******************************************************************************************************|//
//|*                                     EGG INCUBATOR CONTROLLER                                       *|//
//|*                               with TEMPERATURE and HUMIDITY CONTROL                                *|//
//|*                                version 1.0 by: RACKS TheNoobTech                                   *|//
//|*                                        November 10, 2019                                           *|//
//|******************************************************************************************************|//
//|------------------------------------------------------------------------------------------------------|//

// libraries
#include <Wire.h>
#include "LiquidCrystal_I2C.h"
#include <EEPROM.h>
#include <dht.h>

#define DHTPIN A0                                // DHT data pin we're connected to A0
dht DHT;                                        // creates DHT object
LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7); // set the LCD address to 0x27 for 20 chars and 4 lines display (other I2C address is 0x3F)

uint8_t arrow[8] = {0x1F, 0x17, 0x1B, 0x1D, 0x17, 0x1F};                     // creates arrow char
byte degree[8] = {B01100, B10010, B10010, B01100, B00000, B00000, B00000};   // creates degress char

// define pins for relays or LEDs
#define temperaturepin A1
#define humiditypin A2
#define motorpin 5
#define errorpin 4
#define fan 9

// define global variables
float t1, tempset, tempdefference, errtemp;             // variables for time
float humidityset, humiditydefference, errhumid;         // variables for humidity

byte heat;     // value of 1 is for heater and value of 0 is for cooler
byte dry;      // value of 1 is for dryer and value of 0 is for wetter

// define buttons
#define BUT1 6  // decreament button
#define BUT2 7  // increament button
#define BUT3 8  // MENU button
#define BUT4 11 // limit switch for open door
#define BUT5 10 // egg rack posistion 0

// creates number of menus
byte menu = 10; // MENU = 0 ---> initial MENU
// MENU = 1 ---> set temp
// MENU = 2 ---> set temp defference
// MENU = 3 ---> humidity set
// MENU = 4 ---> humidity defference
// MENU = 5 ---> set time for egg turner interval (hours)
// MENU = 6 ---> set time for egg turner motor duration (seconds)
// MENU = 7 ---> set temp error
// MENU = 8 ---> set humidity error

// time variables
int is, im, ih, id, ida;                  // variables for time
float taim, sl, ml, hl, dl;               // set up variables to calculate time
int timebetweenspinsHour, motorspinduration, hatchdays, remainingdays, daysremains;
unsigned long rotationtime, durationB4spin, durationONspin, hatchduration, hatchtimeduration;
int hour, minutes, seconds;
float rest;
unsigned long repeatrotationtime;
byte rotate = 0;
byte spin = 0;
byte temperror = 0;
byte humidityerror = 0;

// these variables are for pushbuttons routine
int buttonstate = 0;           // flag to see if the button has been pressed, used internal on the subroutine only
int pushlenghtset = 4000;      // value for long press in Ms
int pushlenght = pushlenghtset; // set default pushlenght
int pushstart = 0;             // set default push value for the button going low
int pushstop = 0;              // set default value for the button goes back high
boolean buttonflag = false;    // default value for the button flag
unsigned long entrymenu;
unsigned long exitmenu = 60000;
byte cancel = 0;
byte error = 0;


void setup()
{

  // initialize the I2C 20x4 LCD
  lcd.begin(20, 4);
  lcd.setBacklightPin(3, POSITIVE);
  lcd.setBacklight(HIGH);

  // create custom symbol
  lcd.createChar(0, degree);
  lcd.createChar(1, arrow);

  // Turn on backlight
  lcd.backlight();


  //define outputs
  pinMode(temperaturepin, OUTPUT);
  pinMode(humiditypin, OUTPUT);
  pinMode(motorpin, OUTPUT);
  pinMode(errorpin, OUTPUT);
  pinMode(fan, OUTPUT);

  // set the default state for outputs
  digitalWrite(temperaturepin, HIGH);
  digitalWrite(humiditypin, HIGH);
  digitalWrite(motorpin, HIGH);
  digitalWrite(errorpin, HIGH);;

  //SET PUSH BUTTONS FOR MENU
  pinMode(BUT1, INPUT);
  pinMode(BUT2, INPUT);
  pinMode(BUT3, INPUT);
  pinMode(BUT4, INPUT);
  pinMode(BUT5, INPUT);
  digitalWrite(BUT1, HIGH);  // pull-ups on
  digitalWrite(BUT2, HIGH);
  digitalWrite(BUT3, HIGH);
  digitalWrite(BUT4, HIGH);
  digitalWrite(BUT5, HIGH);

  lcd.setCursor(0, 1);
  lcd.print("  Incubator with  ");

  lcd.setCursor(0, 2);
  lcd.print("  humidity control  ");

  delay(3000);
  lcd.clear();

  lcd.setCursor(0, 2);
  lcd.print("    by: R a c k s   ");

  lcd.setCursor(0, 1);
  lcd.print("   v e r s i o n 1  ");
  delay(3000);
  lcd.clear();

  heat = 1 ;  //  1 for heater and 0 for cooler (temp)
  dry = 1;    //  1 for dryer and 0 for wetter (humidity)

  //just first time uploading sketch... after must put comment (//)
  // save intitial setpoint to eepron
  /*       EEPROM.write(200,45);   // max hatching days
           EEPROM.write(201,1);    // tset1
           EEPROM.write(202,120);  // tset2
           EEPROM.write(203,5);   // dt x 10
           EEPROM.Write(204,45);  // humidity set
           EEPROM.Write(205,5);   // humidity defference
           EEPROM.Write(206,2);   // time in hour between apints
           EEPROM.Write(207,10);  // time in seconds for rotations
           EEPROM.Write(208,20);  // errtemp (error temperature) x10
           EEPROM.Write(209,3);   // errhumid (error humidity)

  */

  hatchdays = EEPROM.read(200);
  byte tset1 = EEPROM.read(201);
  byte tset2 = EEPROM.read(202);
  tempset = 256 * tset1 + tset2;  // recover the number
  tempset = tempset / 10;
  tempdefference = EEPROM.read(203);
  tempdefference = tempdefference / 10;
  humidityset = EEPROM.read(204);
  humiditydefference = EEPROM.read(205);
  timebetweenspinsHour = EEPROM.read(206);
  motorspinduration = EEPROM.read(207);
  errtemp = EEPROM.read(208);
  errtemp = errtemp / 10;
  errhumid = EEPROM.read(209);

  durationB4spin = timebetweenspinsHour * 3600000;  //  hour -> ms
  durationONspin = motorspinduration * 1000; // seconds -> ms
  rotationtime = millis();

}

void loop()
{
  if (menu >= 10)
  {
    lcd.clear();
    menu = 0;
  }
  if (menu == 0)
  {
    int doorstatus = digitalRead(BUT4);
    pushlenght = pushlenghtset;
    pushlenght = getpushlenght();
    delay(10);

    if (pushlenght > pushlenghtset)
    {
      menu = 1;

      lcd.clear();
      lcd.setCursor(0, 0);
      lcd.print("   please wait...   ");
      lcd.setCursor(0, 1);
      lcd.print("      Entering      ");
      lcd.setCursor(0, 2);
      lcd.print("   Settings MENU    ");
      delay(2000);
      pushlenght = pushlenghtset;
      delay(50);
      entrymenu = millis();    // store time when enter in setup menu
    }
    if (pushlenght < pushlenghtset)
    {
      lcd.clear();
      lcd.setCursor(0, 0);
      lcd.print("  Press SET Button  ");
      lcd.setCursor(0, 1);
      lcd.print("   for 5 seconds    ");
      lcd.setCursor(0, 2);
      lcd.print("   to Enter MENU    ");
      delay(3000);
      lcd.clear();
      pushlenght = pushlenghtset;
    }

    if (doorstatus == HIGH) {
      lcd.clear();
      lcd.setCursor(0, 2);
      lcd.print("    Door is Open    ");
      lcd.setCursor(0, 3);
      lcd.print("  centering rack... ");
      digitalWrite(motorpin, LOW);
      int pos0 = digitalRead(BUT5);
      if (pos0 == LOW) {
        digitalWrite(motorpin, HIGH);
        lcd.clear();
        lcd.setCursor(0, 2);
        lcd.print("    Door is Open  ");
        lcd.setCursor(0, 3);
        lcd.print(" Rack is Centered ");
      }
      delay(1000);
    }
    if (doorstatus == LOW) {
      digitalWrite(motorpin, HIGH);
    }

    // reading DHT sensor for Temperature and Humidity
    int readData = DHT.read22(DHTPIN);
    float humidityreading = DHT.humidity;        // read humidity
    float temperaturereading = DHT.temperature;  // read temperature

    //check DHT sensor if any reads failed or exit early ( to try read again)
    if ((humidityreading < 0 || humidityreading > 100) || (temperaturereading < -40 || temperaturereading > 80))
    {
      lcd.clear();
      lcd.setCursor(0, 1);
      lcd.print("   Failed to Read   ");
      lcd.setCursor(0, 2);
      lcd.print("     DHT SENSOR     ");
      digitalWrite(temperaturepin, HIGH);
      digitalWrite(humiditypin, HIGH);
      digitalWrite(fan, HIGH);
      digitalWrite(motorpin, HIGH);
      delay(5000);
      return;
    }
    digitalWrite(fan, LOW);

    //-------------------------------------------------//
    //start of MENU 0

    lcd.setCursor(0, 0);
    lcd.print("Temp= ");
    if (temperaturereading < 0)
    {
      t1 = -temperaturereading;
    }
    else t1 = temperaturereading;

    if (t1 < 10)
    {
      lcd.print(" ");
    }
    if (temperaturereading > 0) lcd.print("+");
    if (temperaturereading == 0) lcd.print(" ");
    if (temperaturereading < 0) lcd.print("-");
    lcd.print(t1, 1);
    lcd.write(byte(0));
    lcd.print("C  ");

    lcd.setCursor(0, 1);
    lcd.print("Humidity= ");
    lcd.print(humidityreading, 0);
    lcd.print("%RH  ");
    delay(790);

    if (temperaturereading >= tempset - 0.1)
    {
      if (heat == 1) digitalWrite(temperaturepin, HIGH);
      if (heat == 0) digitalWrite(temperaturepin, LOW);
    }
    if (tempset - tempdefference > temperaturereading)
    {
      if (heat == 0) digitalWrite(temperaturepin, HIGH);
      if (heat == 1) digitalWrite(temperaturepin, LOW);
    }
    if (humidityreading > humidityset)
    {
      if (dry == 1) digitalWrite(humiditypin, HIGH);
      if (dry == 0) digitalWrite(humiditypin, LOW);
    }
    if (humidityreading < humidityset - humiditydefference)
    {
      if (dry == 0) digitalWrite(humiditypin, HIGH);
      if (dry == 1) digitalWrite(humiditypin, LOW);
    }
    if ((temperaturereading > tempset + errtemp) or (temperaturereading < tempset - errtemp))
    {
      temperror = 1;
      lcd.setCursor(17, 0);
      lcd.print("err");
    }
    else
    {
      temperror = 0;
      lcd.setCursor(17, 0);
      lcd.print("   ");
    }
    if ((humidityreading < humidityset - errhumid) or (humidityreading > humidityset + errhumid))
    {
      humidityerror = 1;
      lcd.setCursor(17, 1);
      lcd.print("err");
    }
    else
    {
      humidityerror = 0;
      lcd.setCursor(17, 1);
      lcd.print("   ");
    }

    if ((temperror == 1) or (humidityerror == 1))
    {
      error = 1;
    }
    if (error == 1)
    {
      if (cancel == 0)
      {
        digitalWrite(errorpin, LOW);
        if ((digitalRead(BUT1) == LOW) or (digitalRead(BUT2) == LOW))
        {
          cancel = 1;
          delay(250);
        }
      }
      else
      {
        digitalWrite(errorpin, HIGH);
      }
    }
    else
    {
      digitalWrite(errorpin, HIGH);
    }
    if ((temperror == 0) and (humidityerror == 0))
    {
      error = 0;
      cancel = 0;
    }

    // part of remaining days
    taim = millis();                      // get time in milliseconds since the unit turns on
    sl = taim / 1000;                     // convert time to seconds, minutes, hours, days
    ml = sl / 60;
    hl = ml / 60;
    dl = hl / 24;
    id = int(dl);
    ih = int((dl - int(dl)) * 24);       // strip out remainder to leave Days:Hours:Minutes:Seconds
    im = int((hl - int(dl)) * 60);
    is = int((ml - int(ml)) * 60);


    // calculate approximate days till hatch (maximum hatch settings is 45 days)
    ida = hatchdays - id;

    repeatrotationtime = - millis() + durationB4spin - rotationtime;        // time to repeat egg turner
    repeatrotationtime = repeatrotationtime / 1000; // ms --> sec
    hour = repeatrotationtime / 3600;
    rest = repeatrotationtime - 3600 * hour;
    minutes = rest / 60;
    seconds = rest - 60 * minutes;

    lcd.setCursor(0, 2);
    lcd.print("Tspin= ");
    if (hour < 10) lcd.print("0");
    lcd.print(hour);
    lcd.print(":");
    if (minutes < 10) lcd.print("0");
    lcd.print(minutes);
    lcd.print(":");
    if (seconds < 10); lcd.print("0");
    lcd.print(seconds);
    lcd.print(" ");
    lcd.setCursor(0, 3);
    lcd.print("Hatch in: ");
    if ((ida >= 0) && (ida < 10)) lcd.print(" ");
    lcd.print(ida);
    lcd.print(" day/s");

    // spins part (egg turner)
    while (((millis() - rotationtime) > durationB4spin) && (rotate == 0))
    {
      lcd.clear();
      lcd.setCursor(0, 1);
      lcd.print(" Turning Egg's for: ");
      lcd.setCursor(6, 2);
      lcd.print(motorspinduration);
      lcd.print(" seconds      ");
      digitalWrite(motorpin, LOW);
      delay(durationONspin);
      digitalWrite(motorpin, HIGH);
      rotate = 1;
    }

    if (rotate == 1)
    {
      rotationtime = millis();
      rotate = 0;
      lcd.clear();
    }
  }
  // last line of menu 0
  //------------------------------------------//

  if (menu == 1) {
    lcd.clear();
    while (menu == 1) {
      if (millis() - entrymenu > exitmenu) menu = 0;
      lcd.setCursor(0, 0);
      lcd.print("  Set Temperature:  ");
      lcd.setCursor(5, 1);
      lcd.write(byte(1));
      lcd.setCursor(7, 1);
      lcd.print(tempset, 1);
      lcd.write(byte(0));
      lcd.print("C  ");

      lcd.setCursor(0, 2);
      lcd.print("  Temp Defference:  ");
      lcd.setCursor(7, 3);
      lcd.print(tempdefference, 1);
      lcd.write(byte(0));
      lcd.print("C  ");

      if (digitalRead(BUT1) == LOW)
      { tempset = tempset - 0.1;
        delay(250);
      }
      if (digitalRead(BUT2) == LOW)
      { tempset = tempset + 0.1;
        delay(250);
      }

      int tes2 = tempset * 10;
      byte tset1 = tes2 / 256;
      byte tset2 = tes2 - tset1 * 256;

      if (digitalRead(BUT3) == LOW)
      {
        EEPROM.write(201, tset1);        // save temp settings to eeprom
        EEPROM.write(202, tset2);        // save temp setpoint to eeprom
        menu = 2;
        delay(250);
        lcd.clear();
      }
    }
    delay(100);
  }
  // end of menu 1

  if (menu == 2) {
    while (menu == 2) {
      if (millis() - entrymenu > exitmenu) menu = 0;
      lcd.setCursor(0, 0);
      lcd.print("  Set Temperature:  ");
      lcd.setCursor(7, 1);
      lcd.print(tempset, 1);
      lcd.write(byte(0));
      lcd.print("C  ");

      lcd.setCursor(0, 2);
      lcd.print("  Temp Defference:  ");
      lcd.setCursor(5, 3);
      lcd.write(byte(1));
      lcd.setCursor(7, 3);
      lcd.print(tempdefference, 1);
      lcd.write(byte(0));
      lcd.print("C  ");

      if (digitalRead(BUT1) == LOW)
      { tempdefference = tempdefference - 0.1;
        delay(250);
      }
      if (digitalRead(BUT2) == LOW)
      { tempdefference = tempdefference + 0.1;
        delay(250);
      }
      if (tempdefference < 0.1) tempdefference = 0.1;

      if (digitalRead(BUT3) == LOW)
      {
        EEPROM.write(203, tempdefference * 10);      // save tempdefference settings to eeprom
        menu = 3;
        delay(250);
        lcd.clear();
      }
    }
    // end of menu 2
    //---------------------------------------------------//

    if (menu == 3) {
      while (menu == 3) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("   Set Humidity:    ");
        lcd.setCursor(5, 1);
        lcd.write(byte(1));
        lcd.setCursor(7, 1);
        lcd.print(humidityset, 1);
        lcd.print("%RH  ");

        lcd.setCursor(0, 2);
        lcd.print("Humidity Defference:");
        lcd.setCursor(7, 3);
        lcd.print(humiditydefference);
        lcd.print("%RH  ");

        if (digitalRead(BUT1) == LOW)
        { humidityset = humidityset - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { humidityset = humidityset + 1;
          delay(250);
        }
        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(204, humidityset);        // save humidity settings to eeprom
          menu = 4;
          delay(250);
          lcd.clear();
        }
      }
      delay(250);
    }
    // end of menu 3
    //---------------------------------------------------//

    if (menu == 4) {
      while (menu == 4) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("   Set Humidity:    ");
        lcd.setCursor(7, 1);
        lcd.print(humidityset);
        lcd.write(byte(0));
        lcd.print("%RH  ");

        lcd.setCursor(0, 2);
        lcd.print("Humidity Defference:");
        lcd.setCursor(5, 3);
        lcd.write(byte(1));
        lcd.setCursor(7, 3);
        lcd.print(humiditydefference);
        lcd.write(byte(0));
        lcd.print("%RH  ");

        if (digitalRead(BUT1) == LOW)
        { humiditydefference = humiditydefference - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { humiditydefference = humiditydefference + 1;
          delay(250);
        }
        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(205, humiditydefference);        // save humiditydefference settings to eeprom
          menu = 5;
          delay(250);
          lcd.clear();
        }
        if (humiditydefference < 1) humiditydefference = 1;
      }
    }
    // end of menu 4
    //---------------------------------------------//

    if (menu == 5) {
      while (menu == 5) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("Time Between Spins: ");

        if (digitalRead(BUT1) == LOW)
        { timebetweenspinsHour = timebetweenspinsHour - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { timebetweenspinsHour = timebetweenspinsHour + 1;
          delay(250);
        }
        if (timebetweenspinsHour < 1) timebetweenspinsHour = 24;
        if (timebetweenspinsHour > 1) timebetweenspinsHour = 1;

        lcd.setCursor(5, 2);
        lcd.write(byte(1));
        lcd.setCursor(6, 2);
        lcd.print(timebetweenspinsHour);
        lcd.print(" hour/s       ");

        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(206, timebetweenspinsHour);     // save time interval between spins settings to eeprom
          delay(250);
          lcd.clear();
          durationB4spin = timebetweenspinsHour * 3600000;    // hrs --> ms
          menu = 6;
        }
      }
    }
    // end of menu 5
    //-----------------------------------------------------------//

    if (menu == 6) {
      while (menu == 6) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("Running Duration of ");
        lcd.setCursor(0, 1);
        lcd.print(" egg's tilt Motor:  ");

        if (digitalRead(BUT1) == LOW)
        { motorspinduration = motorspinduration - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { motorspinduration = motorspinduration + 1;
          delay(250);
        }
        if (motorspinduration < 3) motorspinduration = 60;
        if (motorspinduration > 60) motorspinduration = 3;

        lcd.setCursor(4, 3);
        lcd.write(byte(1));
        lcd.setCursor(6, 3);
        lcd.print(motorspinduration);
        lcd.print(" seconds      ");

        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(207, motorspinduration);     // save time settings for running duration of tilt motor to eeprom
          delay(250);
          lcd.clear();
          durationONspin = motorspinduration * 1000;    // sec --> ms
          menu = 7;
        }
      }
    }
    // end of menu 6
    //-----------------------------------------------------------//

    if (menu == 7) {
      while (menu == 7) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("   Temp Tolerance   ");
        lcd.setCursor(0, 1);
        lcd.print("  (Define as Error) ");

        lcd.setCursor(4, 3);
        lcd.write(byte(1));
        lcd.setCursor(6, 3);
        lcd.print("+/- ");
        lcd.print(errtemp, 1);
        lcd.write(byte(0));
        lcd.print("C   ");

        if (digitalRead(BUT1) == LOW)
        { errtemp = errtemp - 0.1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { errtemp = errtemp + 0.1;
          delay(250);
        }
        if (errtemp < 0.1) errtemp = 0.1;
        if (errtemp > 3.0) errtemp = 3.0;


        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(208, errtemp * 10);     // save settings to eeprom for tolerance of error message to appear on lcd screen(temperature)
          menu = 8;
          delay(250);
          lcd.clear();
        }
      }
    }
    // end of menu 7
    //-----------------------------------------------------------//

    if (menu == 8) {
      while (menu == 8) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print(" Humidity Tolerance ");
        lcd.setCursor(0, 1);
        lcd.print("  (Define as Error) ");

        lcd.setCursor(4, 3);
        lcd.write(byte(1));
        lcd.setCursor(6, 3);
        lcd.print("+/- ");
        lcd.print(errhumid);
        lcd.write(byte(0));
        lcd.print("%RH   ");

        if (digitalRead(BUT1) == LOW)
        { errhumid = errhumid - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { errhumid = errhumid + 1;
          delay(250);
        }
        if (errhumid < 1) errhumid = 1;
        if (errhumid > 10) errhumid = 10;


        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(209, errhumid);     // save settings to eeprom for tolerance of error message to appear on lcd screen(humidity)
          menu = 9;
          delay(250);
          lcd.clear();
        }
      }
    }
    // end of menu 8
    //-----------------------------------------------------------//

    if (menu == 9) {
      while (menu == 9) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("  Set Egg's Hatch   ");
        lcd.setCursor(0, 1);
        lcd.print("     Duration       ");

        lcd.setCursor(4, 3);
        lcd.write(byte(1));
        lcd.setCursor(6, 3);
        lcd.print(hatchdays);
        lcd.print(" day/s  ");

        if (digitalRead(BUT1) == LOW)
        { hatchdays = hatchdays - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { hatchdays = hatchdays + 1;
          delay(250);
        }
        if (hatchdays < 1) hatchdays = 1;
        if (hatchdays > 45) hatchdays = 45;


        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(200, hatchdays);     // save hatch day settings to eeprom
          menu = 0;
          delay(250);
          lcd.clear();
        }
      }
    }
    // end of menu 9
    //-----------------------------------------------------------//

    if (menu == 10) {
      while (menu == 10) {
        lcd.clear();
        lcd.setCursor(0, 1);
        lcd.print("   Door is Open...  ");
        if (digitalRead(BUT4 == LOW)) {
          lcd.clear();
          menu = 0;
        }
      }
    }
  }
}
// last line of void loop
//-----------------------------------------------------//

// subroutine to return the lenght of the push button
int getpushlenght() {
  buttonstate = digitalRead(BUT3);
  if (buttonstate == LOW && buttonflag == false) {
    pushstart = millis();
    buttonflag = true;
  };
  if (buttonstate == HIGH && buttonflag == true) {
    pushstop = millis();
    pushlenght = pushstop - pushstart;
    buttonflag = false;
  };
  return pushlenght;
}
//--------------- END OF PROGRAM ---------------//

[b707]

@fcgfilho

 durationONspin = motorspinduration * 1000; 

This right part of the line may leads to overflow on AVR processors, if the value of motorspinduration will be more than 32

[xfpd]

Please, refrain from cross-posting:

Bug contagem regressiva de tempo - arduino nano

Estou tentando fazer um projeto de uma incubadora com rolagem automática de ovos. Esses devem rolar após uma contagem regressiva, porém quando termina a primeira contagem, esta reinicia com um número estranho como 1999h: 555m: 2222s. Que deveria ser 00h:59m:59s //EGG INCUBATOR Version 1.0 //|------------------------------------------------------------------------------------------------------|// //|***********************************************************************************************…

[b707]

@fcgfilho

It turns out that the count that should be from an hour (00:59:59) to hours, minutes and seconds. Returns a wrong count, like: 1999H: 555M: 2222S.

Is it the code where the time calculations should take place?

@fcgfilho

taim = millis();                      // get time in milliseconds since the unit turns on
    sl = taim / 1000;                     // convert time to seconds, minutes, hours, days
    ml = sl / 60;
    hl = ml / 60;
    dl = hl / 24;
    id = int(dl);
    ih = int((dl - int(dl)) * 24);       // strip out remainder to leave Days:Hours:Minutes:Seconds
    im = int((hl - int(dl)) * 60);
    is = int((ml - int(ml)) * 60);

As far I see the variables sl, ml, hl and dl has a float type. It is not a good idea. Use an integers only.
To calculate the days, hours, minutes and seconds from the raw millis() value, you could use something like this:

int seconds = ( millis() /1000) % 60;
int minutes = ( millis() /1000/60) % 60;
int hours  =  ( millis() /1000/60/60) % 24;

[kolaha]

//EGG INCUBATOR Version 1.0

//|------------------------------------------------------------------------------------------------------|//
//|******************************************************************************************************|//
//|*                                     EGG INCUBATOR CONTROLLER                                       *|//
//|*                               with TEMPERATURE and HUMIDITY CONTROL                                *|//
//|*                                version 1.0 by: RACKS TheNoobTech                                   *|//
//|*                                        November 10, 2019                                           *|//
//|******************************************************************************************************|//
//|------------------------------------------------------------------------------------------------------|//

// libraries
#include <Wire.h>
#include "LiquidCrystal_I2C.h"
#include <EEPROM.h>
#include <dht.h>

#define DHTPIN A0                                // DHT data pin we're connected to A0
dht DHT;                                        // creates DHT object
LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7); // set the LCD address to 0x27 for 20 chars and 4 lines display (other I2C address is 0x3F)

uint8_t arrow[8] = {0x1F, 0x17, 0x1B, 0x1D, 0x17, 0x1F};                     // creates arrow char
byte degree[8] = {B01100, B10010, B10010, B01100, B00000, B00000, B00000};   // creates degress char

// define pins for relays or LEDs
#define temperaturepin A1
#define humiditypin A2
#define motorpin 5
#define errorpin 4
#define fan 9

// define global variables
float t1, tempset, tempdefference, errtemp;             // variables for time
float humidityset, humiditydefference, errhumid;         // variables for humidity

byte heat;     // value of 1 is for heater and value of 0 is for cooler
byte dry;      // value of 1 is for dryer and value of 0 is for wetter

// define buttons
#define BUT1 6  // decreament button
#define BUT2 7  // increament button
#define BUT3 8  // MENU button
#define BUT4 11 // limit switch for open door
#define BUT5 10 // egg rack posistion 0

// creates number of menus
byte menu = 10; // MENU = 0 ---> initial MENU
// MENU = 1 ---> set temp
// MENU = 2 ---> set temp defference
// MENU = 3 ---> humidity set
// MENU = 4 ---> humidity defference
// MENU = 5 ---> set time for egg turner interval (hours)
// MENU = 6 ---> set time for egg turner motor duration (seconds)
// MENU = 7 ---> set temp error
// MENU = 8 ---> set humidity error

// time variables
int is, im, ih, id, ida;                  // variables for time
int timebetweenspinsHour, motorspinduration, hatchdays, remainingdays, daysremains;
unsigned long repeatrotationtime, rest, taim, rotationtime, durationB4spin, durationONspin, hatchduration, hatchtimeduration;
byte Hours, Minutes, Seconds;
byte rotate = 0;
byte spin = 0;
byte temperror = 0;
byte humidityerror = 0;

// these variables are for pushbuttons routine
int buttonstate = 0;           // flag to see if the button has been pressed, used internal on the subroutine only
int pushlenghtset = 4000;      // value for long press in Ms
int pushlenght = pushlenghtset; // set default pushlenght
int pushstart = 0;             // set default push value for the button going low
int pushstop = 0;              // set default value for the button goes back high
boolean buttonflag = false;    // default value for the button flag
unsigned long entrymenu;
unsigned long exitmenu = 60000;
byte cancel = 0;
byte error = 0;


void setup()
{

  // initialize the I2C 20x4 LCD
  lcd.begin(20, 4);
  lcd.setBacklightPin(3, POSITIVE);
  lcd.setBacklight(HIGH);

  // create custom symbol
  lcd.createChar(0, degree);
  lcd.createChar(1, arrow);

  // Turn on backlight
  lcd.backlight();


  //define outputs
  pinMode(temperaturepin, OUTPUT);
  pinMode(humiditypin, OUTPUT);
  pinMode(motorpin, OUTPUT);
  pinMode(errorpin, OUTPUT);
  pinMode(fan, OUTPUT);

  // set the default state for outputs
  digitalWrite(temperaturepin, HIGH);
  digitalWrite(humiditypin, HIGH);
  digitalWrite(motorpin, HIGH);
  digitalWrite(errorpin, HIGH);;

  //SET PUSH BUTTONS FOR MENU
  pinMode(BUT1, INPUT);
  pinMode(BUT2, INPUT);
  pinMode(BUT3, INPUT);
  pinMode(BUT4, INPUT);
  pinMode(BUT5, INPUT);
  digitalWrite(BUT1, HIGH);  // pull-ups on
  digitalWrite(BUT2, HIGH);
  digitalWrite(BUT3, HIGH);
  digitalWrite(BUT4, HIGH);
  digitalWrite(BUT5, HIGH);

  lcd.setCursor(0, 1);
  lcd.print("  Incubator with  ");

  lcd.setCursor(0, 2);
  lcd.print("  humidity control  ");

  delay(3000);
  lcd.clear();

  lcd.setCursor(0, 2);
  lcd.print("    by: R a c k s   ");

  lcd.setCursor(0, 1);
  lcd.print("   v e r s i o n 1  ");
  delay(3000);
  lcd.clear();

  heat = 1 ;  //  1 for heater and 0 for cooler (temp)
  dry = 1;    //  1 for dryer and 0 for wetter (humidity)

  //just first time uploading sketch... after must put comment (//)
  // save intitial setpoint to eepron
  /*       EEPROM.write(200,45);   // max hatching days
           EEPROM.write(201,1);    // tset1
           EEPROM.write(202,120);  // tset2
           EEPROM.write(203,5);   // dt x 10
           EEPROM.Write(204,45);  // humidity set
           EEPROM.Write(205,5);   // humidity defference
           EEPROM.Write(206,2);   // time in hour between apints
           EEPROM.Write(207,10);  // time in seconds for rotations
           EEPROM.Write(208,20);  // errtemp (error temperature) x10
           EEPROM.Write(209,3);   // errhumid (error humidity)

  */

  hatchdays = EEPROM.read(200);
  byte tset1 = EEPROM.read(201);
  byte tset2 = EEPROM.read(202);
  tempset = 256 * tset1 + tset2;  // recover the number
  tempset = tempset / 10;
  tempdefference = EEPROM.read(203);
  tempdefference = tempdefference / 10;
  humidityset = EEPROM.read(204);
  humiditydefference = EEPROM.read(205);
  timebetweenspinsHour = EEPROM.read(206);
  motorspinduration = EEPROM.read(207);
  errtemp = EEPROM.read(208);
  errtemp = errtemp / 10;
  errhumid = EEPROM.read(209);

  durationB4spin = timebetweenspinsHour * 3600000;  //  hour -> ms
  durationONspin = motorspinduration * 1000; // seconds -> ms
  rotationtime = millis();

}

void loop()
{
  if (menu >= 10)
  {
    lcd.clear();
    menu = 0;
  }
  if (menu == 0)
  {
    int doorstatus = digitalRead(BUT4);
    pushlenght = pushlenghtset;
    pushlenght = getpushlenght();
    delay(10);

    if (pushlenght > pushlenghtset)
    {
      menu = 1;

      lcd.clear();
      lcd.setCursor(0, 0);
      lcd.print("   please wait...   ");
      lcd.setCursor(0, 1);
      lcd.print("      Entering      ");
      lcd.setCursor(0, 2);
      lcd.print("   Settings MENU    ");
      delay(2000);
      pushlenght = pushlenghtset;
      delay(50);
      entrymenu = millis();    // store time when enter in setup menu
    }
    if (pushlenght < pushlenghtset)
    {
      lcd.clear();
      lcd.setCursor(0, 0);
      lcd.print("  Press SET Button  ");
      lcd.setCursor(0, 1);
      lcd.print("   for 5 seconds    ");
      lcd.setCursor(0, 2);
      lcd.print("   to Enter MENU    ");
      delay(3000);
      lcd.clear();
      pushlenght = pushlenghtset;
    }

    if (doorstatus == HIGH) {
      lcd.clear();
      lcd.setCursor(0, 2);
      lcd.print("    Door is Open    ");
      lcd.setCursor(0, 3);
      lcd.print("  centering rack... ");
      digitalWrite(motorpin, LOW);
      int pos0 = digitalRead(BUT5);
      if (pos0 == LOW) {
        digitalWrite(motorpin, HIGH);
        lcd.clear();
        lcd.setCursor(0, 2);
        lcd.print("    Door is Open  ");
        lcd.setCursor(0, 3);
        lcd.print(" Rack is Centered ");
      }
      delay(1000);
    }
    if (doorstatus == LOW) {
      digitalWrite(motorpin, HIGH);
    }

    // reading DHT sensor for Temperature and Humidity
    int readData = DHT.read22(DHTPIN);
    float humidityreading = DHT.humidity;        // read humidity
    float temperaturereading = DHT.temperature;  // read temperature

    //check DHT sensor if any reads failed or exit early ( to try read again)
    if ((humidityreading < 0 || humidityreading > 100) || (temperaturereading < -40 || temperaturereading > 80))
    {
      lcd.clear();
      lcd.setCursor(0, 1);
      lcd.print("   Failed to Read   ");
      lcd.setCursor(0, 2);
      lcd.print("     DHT SENSOR     ");
      digitalWrite(temperaturepin, HIGH);
      digitalWrite(humiditypin, HIGH);
      digitalWrite(fan, HIGH);
      digitalWrite(motorpin, HIGH);
      delay(5000);
      return;
    }
    digitalWrite(fan, LOW);

    //-------------------------------------------------//
    //start of MENU 0

    lcd.setCursor(0, 0);
    lcd.print("Temp= ");
    if (temperaturereading < 0)
    {
      t1 = -temperaturereading;
    }
    else t1 = temperaturereading;

    if (t1 < 10)
    {
      lcd.print(" ");
    }
    if (temperaturereading > 0) lcd.print("+");
    if (temperaturereading == 0) lcd.print(" ");
    if (temperaturereading < 0) lcd.print("-");
    lcd.print(t1, 1);
    lcd.write(byte(0));
    lcd.print("C  ");

    lcd.setCursor(0, 1);
    lcd.print("Humidity= ");
    lcd.print(humidityreading, 0);
    lcd.print("%RH  ");
    delay(790);

    if (temperaturereading >= tempset - 0.1)
    {
      if (heat == 1) digitalWrite(temperaturepin, HIGH);
      if (heat == 0) digitalWrite(temperaturepin, LOW);
    }
    if (tempset - tempdefference > temperaturereading)
    {
      if (heat == 0) digitalWrite(temperaturepin, HIGH);
      if (heat == 1) digitalWrite(temperaturepin, LOW);
    }
    if (humidityreading > humidityset)
    {
      if (dry == 1) digitalWrite(humiditypin, HIGH);
      if (dry == 0) digitalWrite(humiditypin, LOW);
    }
    if (humidityreading < humidityset - humiditydefference)
    {
      if (dry == 0) digitalWrite(humiditypin, HIGH);
      if (dry == 1) digitalWrite(humiditypin, LOW);
    }
    if ((temperaturereading > tempset + errtemp) or (temperaturereading < tempset - errtemp))
    {
      temperror = 1;
      lcd.setCursor(17, 0);
      lcd.print("err");
    }
    else
    {
      temperror = 0;
      lcd.setCursor(17, 0);
      lcd.print("   ");
    }
    if ((humidityreading < humidityset - errhumid) or (humidityreading > humidityset + errhumid))
    {
      humidityerror = 1;
      lcd.setCursor(17, 1);
      lcd.print("err");
    }
    else
    {
      humidityerror = 0;
      lcd.setCursor(17, 1);
      lcd.print("   ");
    }

    if ((temperror == 1) or (humidityerror == 1))
    {
      error = 1;
    }
    if (error == 1)
    {
      if (cancel == 0)
      {
        digitalWrite(errorpin, LOW);
        if ((digitalRead(BUT1) == LOW) or (digitalRead(BUT2) == LOW))
        {
          cancel = 1;
          delay(250);
        }
      }
      else digitalWrite(errorpin, HIGH);
    }
    else digitalWrite(errorpin, HIGH);

    if ((temperror == 0) and (humidityerror == 0))
    {
      error = 0;
      cancel = 0;
    }

    // part of remaining days
    taim = millis() / 1000;                    // get time in seconds since the unit turns on
    is = taim % 60;
    im = (taim / 60) % 60;
    ih = (taim / 3600) % 24;       // strip out remainder to leave Days:Hours:Minutes:Seconds
    id = taim / 86400;

    // calculate approximate days till hatch (maximum hatch settings is 45 days)
    ida = hatchdays - id;

    repeatrotationtime = - millis() + durationB4spin - rotationtime;        // time to repeat egg turner
    repeatrotationtime = repeatrotationtime / 1000; // ms --> sec
    Hours = repeatrotationtime / 3600;
    rest = repeatrotationtime - 3600 * Hours;
    Minutes = rest / 60;
    Seconds = rest % 60 ;

    char Text[17];
    sprintf(Text, "Tspin= %02u:%02u:%02u ", Hours, Minutes, Seconds);
    lcd.setCursor(0, 2);
    lcd.print(Text);

    sprintf(Text, "Hatch in: %2u day/s", ida);
    lcd.setCursor(0, 3);
    lcd.print(Text);

    // spins part (egg turner)
    while (((millis() - rotationtime) > durationB4spin) && (rotate == 0))
    {
      lcd.clear();
      lcd.setCursor(0, 1);
      lcd.print(" Turning Egg's for: ");
      lcd.setCursor(6, 2);
      lcd.print(motorspinduration);
      lcd.print(" seconds      ");
      digitalWrite(motorpin, LOW);
      delay(durationONspin);
      digitalWrite(motorpin, HIGH);
      rotate = 1;
    }

    if (rotate == 1)
    {
      rotationtime = millis();
      rotate = 0;
      lcd.clear();
    }
  }
  // last line of menu 0
  //------------------------------------------//

  if (menu == 1) {
    lcd.clear();
    while (menu == 1) {
      if (millis() - entrymenu > exitmenu) menu = 0;
      lcd.setCursor(0, 0);
      lcd.print("  Set Temperature:  ");
      lcd.setCursor(5, 1);
      lcd.write(byte(1));
      lcd.setCursor(7, 1);
      lcd.print(tempset, 1);
      lcd.write(byte(0));
      lcd.print("C  ");

      lcd.setCursor(0, 2);
      lcd.print("  Temp Defference:  ");
      lcd.setCursor(7, 3);
      lcd.print(tempdefference, 1);
      lcd.write(byte(0));
      lcd.print("C  ");

      if (digitalRead(BUT1) == LOW)
      { tempset = tempset - 0.1;
        delay(250);
      }
      if (digitalRead(BUT2) == LOW)
      { tempset = tempset + 0.1;
        delay(250);
      }

      int tes2 = tempset * 10;
      byte tset1 = tes2 / 256;
      byte tset2 = tes2 - tset1 * 256;

      if (digitalRead(BUT3) == LOW)
      {
        EEPROM.write(201, tset1);        // save temp settings to eeprom
        EEPROM.write(202, tset2);        // save temp setpoint to eeprom
        menu = 2;
        delay(250);
        lcd.clear();
      }
    }
    delay(100);
  }
  // end of menu 1

  if (menu == 2) {
    while (menu == 2) {
      if (millis() - entrymenu > exitmenu) menu = 0;
      lcd.setCursor(0, 0);
      lcd.print("  Set Temperature:  ");
      lcd.setCursor(7, 1);
      lcd.print(tempset, 1);
      lcd.write(byte(0));
      lcd.print("C  ");

      lcd.setCursor(0, 2);
      lcd.print("  Temp Defference:  ");
      lcd.setCursor(5, 3);
      lcd.write(byte(1));
      lcd.setCursor(7, 3);
      lcd.print(tempdefference, 1);
      lcd.write(byte(0));
      lcd.print("C  ");

      if (digitalRead(BUT1) == LOW)
      { tempdefference = tempdefference - 0.1;
        delay(250);
      }
      if (digitalRead(BUT2) == LOW)
      { tempdefference = tempdefference + 0.1;
        delay(250);
      }
      if (tempdefference < 0.1) tempdefference = 0.1;

      if (digitalRead(BUT3) == LOW)
      {
        EEPROM.write(203, tempdefference * 10);      // save tempdefference settings to eeprom
        menu = 3;
        delay(250);
        lcd.clear();
      }
    }
    // end of menu 2
    //---------------------------------------------------//

    if (menu == 3) {
      while (menu == 3) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("   Set Humidity:    ");
        lcd.setCursor(5, 1);
        lcd.write(byte(1));
        lcd.setCursor(7, 1);
        lcd.print(humidityset, 1);
        lcd.print("%RH  ");

        lcd.setCursor(0, 2);
        lcd.print("Humidity Defference:");
        lcd.setCursor(7, 3);
        lcd.print(humiditydefference);
        lcd.print("%RH  ");

        if (digitalRead(BUT1) == LOW)
        { humidityset = humidityset - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { humidityset = humidityset + 1;
          delay(250);
        }
        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(204, humidityset);        // save humidity settings to eeprom
          menu = 4;
          delay(250);
          lcd.clear();
        }
      }
      delay(250);
    }
    // end of menu 3
    //---------------------------------------------------//

    if (menu == 4) {
      while (menu == 4) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("   Set Humidity:    ");
        lcd.setCursor(7, 1);
        lcd.print(humidityset);
        lcd.write(byte(0));
        lcd.print("%RH  ");

        lcd.setCursor(0, 2);
        lcd.print("Humidity Defference:");
        lcd.setCursor(5, 3);
        lcd.write(byte(1));
        lcd.setCursor(7, 3);
        lcd.print(humiditydefference);
        lcd.write(byte(0));
        lcd.print("%RH  ");

        if (digitalRead(BUT1) == LOW)
        { humiditydefference = humiditydefference - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { humiditydefference = humiditydefference + 1;
          delay(250);
        }
        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(205, humiditydefference);        // save humiditydefference settings to eeprom
          menu = 5;
          delay(250);
          lcd.clear();
        }
        if (humiditydefference < 1) humiditydefference = 1;
      }
    }
    // end of menu 4
    //---------------------------------------------//

    if (menu == 5) {
      while (menu == 5) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("Time Between Spins: ");

        if (digitalRead(BUT1) == LOW)
        { timebetweenspinsHour = timebetweenspinsHour - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { timebetweenspinsHour = timebetweenspinsHour + 1;
          delay(250);
        }
        if (timebetweenspinsHour < 1) timebetweenspinsHour = 24;
        if (timebetweenspinsHour > 1) timebetweenspinsHour = 1;

        lcd.setCursor(5, 2);
        lcd.write(byte(1));
        lcd.setCursor(6, 2);
        lcd.print(timebetweenspinsHour);
        lcd.print(" hour/s       ");

        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(206, timebetweenspinsHour);     // save time interval between spins settings to eeprom
          delay(250);
          lcd.clear();
          durationB4spin = timebetweenspinsHour * 3600000;    // hrs --> ms
          menu = 6;
        }
      }
    }
    // end of menu 5
    //-----------------------------------------------------------//

    if (menu == 6) {
      while (menu == 6) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("Running Duration of ");
        lcd.setCursor(0, 1);
        lcd.print(" egg's tilt Motor:  ");

        if (digitalRead(BUT1) == LOW)
        { motorspinduration = motorspinduration - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { motorspinduration = motorspinduration + 1;
          delay(250);
        }
        if (motorspinduration < 3) motorspinduration = 60;
        if (motorspinduration > 60) motorspinduration = 3;

        lcd.setCursor(4, 3);
        lcd.write(byte(1));
        lcd.setCursor(6, 3);
        lcd.print(motorspinduration);
        lcd.print(" seconds      ");

        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(207, motorspinduration);     // save time settings for running duration of tilt motor to eeprom
          delay(250);
          lcd.clear();
          durationONspin = motorspinduration * 1000;    // sec --> ms
          menu = 7;
        }
      }
    }
    // end of menu 6
    //-----------------------------------------------------------//

    if (menu == 7) {
      while (menu == 7) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("   Temp Tolerance   ");
        lcd.setCursor(0, 1);
        lcd.print("  (Define as Error) ");

        lcd.setCursor(4, 3);
        lcd.write(byte(1));
        lcd.setCursor(6, 3);
        lcd.print("+/- ");
        lcd.print(errtemp, 1);
        lcd.write(byte(0));
        lcd.print("C   ");

        if (digitalRead(BUT1) == LOW)
        { errtemp = errtemp - 0.1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { errtemp = errtemp + 0.1;
          delay(250);
        }
        if (errtemp < 0.1) errtemp = 0.1;
        if (errtemp > 3.0) errtemp = 3.0;


        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(208, errtemp * 10);     // save settings to eeprom for tolerance of error message to appear on lcd screen(temperature)
          menu = 8;
          delay(250);
          lcd.clear();
        }
      }
    }
    // end of menu 7
    //-----------------------------------------------------------//

    if (menu == 8) {
      while (menu == 8) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print(" Humidity Tolerance ");
        lcd.setCursor(0, 1);
        lcd.print("  (Define as Error) ");

        lcd.setCursor(4, 3);
        lcd.write(byte(1));
        lcd.setCursor(6, 3);
        lcd.print("+/- ");
        lcd.print(errhumid);
        lcd.write(byte(0));
        lcd.print("%RH   ");

        if (digitalRead(BUT1) == LOW)
        { errhumid = errhumid - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { errhumid = errhumid + 1;
          delay(250);
        }
        if (errhumid < 1) errhumid = 1;
        if (errhumid > 10) errhumid = 10;


        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(209, errhumid);     // save settings to eeprom for tolerance of error message to appear on lcd screen(humidity)
          menu = 9;
          delay(250);
          lcd.clear();
        }
      }
    }
    // end of menu 8
    //-----------------------------------------------------------//

    if (menu == 9) {
      while (menu == 9) {
        if (millis() - entrymenu > exitmenu) menu = 0;
        lcd.setCursor(0, 0);
        lcd.print("  Set Egg's Hatch   ");
        lcd.setCursor(0, 1);
        lcd.print("     Duration       ");

        lcd.setCursor(4, 3);
        lcd.write(byte(1));
        lcd.setCursor(6, 3);
        lcd.print(hatchdays);
        lcd.print(" day/s  ");

        if (digitalRead(BUT1) == LOW)
        { hatchdays = hatchdays - 1;
          delay(250);
        }
        if (digitalRead(BUT2) == LOW)
        { hatchdays = hatchdays + 1;
          delay(250);
        }
        if (hatchdays < 1) hatchdays = 1;
        if (hatchdays > 45) hatchdays = 45;


        if (digitalRead(BUT3) == LOW)
        {
          EEPROM.write(200, hatchdays);     // save hatch day settings to eeprom
          menu = 0;
          delay(250);
          lcd.clear();
        }
      }
    }
    // end of menu 9
    //-----------------------------------------------------------//

    if (menu == 10) {
      while (menu == 10) {
        lcd.clear();
        lcd.setCursor(0, 1);
        lcd.print("   Door is Open...  ");
        if (digitalRead(BUT4 == LOW)) {
          lcd.clear();
          menu = 0;
        }
      }
    }
  }
}
// last line of void loop
//-----------------------------------------------------//

// subroutine to return the lenght of the push button
int getpushlenght() {
  buttonstate = digitalRead(BUT3);
  if (buttonstate == LOW && buttonflag == false) {
    pushstart = millis();
    buttonflag = true;
  };
  if (buttonstate == HIGH && buttonflag == true) {
    pushstop = millis();
    pushlenght = pushstop - pushstart;
    buttonflag = false;
  };
  return pushlenght;
}
//--------------- END OF PROGRAM ---------------//

[GoForSmoke]

Without using an RTC module to tell time, we can get very close using millis() or micros() to time intervals in code. With a Nano, would +/- 18 seconds per hour (depends on temperture) be close enough interval?

Why? It will simplify the code and you won't need a clock module!

interval becomes only 1 number. No hours, minutes and seconds. Just milliseconds that source code can be

unsigned long hour = ( 60 * 60 * 1000 );

Inside of void loop() we count up from a saved start
unsigned long startMillis; // declares variable to save time in
... some code
startMillis = millis(); // saving the "now" time at that line
... more code

if ( millis() - startMillis >= hour )
{
...an hour since startMillis was saved has passed
...so do what was waited for or stop doing something
startMillis = millis(); // saving the time for the next interval
}

Just saying that working with intervals is possible. We use it to run auto,aton code here.

[alto777]

@GoForSmoke

No hours, minutes and seconds.

Yes, that simplifies lotsa things.

@GoForSmoke

unsigned long hour = ( 60 * 60 * 1000 );

Yes, but

unsigned long hour = 60UL * 60 * 1000;

a7

[fcgfilho]

A compilação retornou essa mensagem de erro

erro.txt (7.63 KB)

[kolaha]

corrected

[mancera1979]

Is this correct?

repeatrotationtime = - millis() + durationB4spin - rotationtime;`

[GoForSmoke]

@mancera1979

`repeatrotationtime = - millis() + durationB4spin - rotationtime;``

I have never tried that. It is something to check, I see -millis() as always beginning at zero and the +desired interval-rotation could be a countdown back to zero but I'm not sure how you get rotation time without another calculation.

What we do only requires a save start time, a desired wait interval and the always-moving-forward now of millis or micros.

Simple example is a 12 hour clock with hour hand and 12 is 0, the dreaded rollover. Time adds by moving right and subtracts by moving left on our unsigned round base-12 clock.

If the start of wait is 9 and the desired wait is 5.. from 9, 5 to the right is 2. But in between, 10 and 11 are > 2 while 0 and 1 are < 2.

So here is trick. When now is 11, move left start of 9 gets 2 which is less than interval 5 so time is not up, when now is 1, 9 left is 4 and when now is 2, 5 have elapsed. With signed values it won't work but unsigned does same way every "now".

Now - Start = elapsed time to compare to desired interval.
I think that rotationtime is elapsed time and durationB4spin is the desired interval? Now is millis, millis is now.

Now - Now = zero + interval - elapsed, a countdown to zero.
What you get when elapsed is > interval? Trouble for checking late, the countdown resets!

We use now - start >= interval. The >= means late check still works which when the time unit is milli or micro may be easy to be late checking.

Alto777 is right, unsigned long constants should have UL to tell the compiler the number is not an int! Compiler can be brilliant and stupid at the same time!

These posts I make are sign posts only. Travel is further discussion to get all the details, like check/debug code!

[fcgfilho]

Após 60 minutos, a incubadora fez a rolagem dos ovos, porém retornou uma contagem diferente: 168:104:46

[fcgfilho]

A rolagem continua sendo em uma hora, porém o display mostra número estranho:

[mancera1979]

Try changing this

@fcgfilho

repeatrotationtime = - millis() + durationB4spin - rotationtime

to

repeaterotationtime = rotationtime + durationB4spin

[kolaha]

it is not from me

[fcgfilho]

Não inicia a contagem regressiva. Fica parado 01:00:06

[kolaha]

#include "LiquidCrystal_I2C.h"
LiquidCrystal_I2C lcd(0x27, 20, 4); // set the LCD address to 0x27 for 20 chars and 4 lines display (other I2C address is 0x3F)
int timebetweenspinsHour, motorspinduration, hatchdays;
unsigned long repeatrotationtime, rotationtime, durationB4spin, durationONspin;
long hatchtimeduration;

void setup(){
  lcd.init();
  //lcd.createChar(0, degree);
  //lcd.createChar(1, arrow);
  lcd.backlight();

  hatchdays = 1; // days; entire period for hatching of eggs; better not bigger 51 days
  timebetweenspinsHour = 1; // hours; how long delay before next egg turn
  motorspinduration = 10; // seconds;  how long egg turn
  durationB4spin =  3600000UL * timebetweenspinsHour;  //  hour -> ms; how long delay before next egg turn
  durationONspin = motorspinduration * 1000; // seconds -> ms; how long egg turn
  rotationtime = millis(); //  store time after earlier egg turn
  hatchtimeduration = 86400UL * hatchdays;// seconds
}

void loop() {
  static byte menu=10;
  static byte Hours, Minutes, Seconds = 0;
  if (menu >= 10)  {
    lcd.clear();
    menu = 0;
  }
  if (menu == 0)  {
    if ((millis() - rotationtime) > durationB4spin) rotationtime = millis();
    repeatrotationtime =  (durationB4spin - (millis() - rotationtime)) / 1000;    // time to repeat egg turner
    Hours = repeatrotationtime / 3600;
    Minutes = (repeatrotationtime / 60) % 60;
    Seconds = repeatrotationtime % 60 ;

    char Text[17];
    sprintf(Text, "Tspin= %02u:%02u:%02u ", Hours, Minutes, Seconds);
    lcd.setCursor(0, 2);
    lcd.print(Text);

    sprintf(Text, "Hatch %lu day/s ", hatchtimeduration/86400UL);
    lcd.setCursor(0, 3);
    lcd.print(Text);

    if ((Hours + Minutes + Seconds) == 0)
    {
      hatchtimeduration = hatchtimeduration - (durationB4spin + durationONspin) / 1000;
      lcd.clear();
        lcd.print("Turning Egg's for:");
    lcd.setCursor(0, 1);
      lcd.print(motorspinduration);
      lcd.print(" seconds");
      delay(durationONspin);
      lcd.clear();
    }
  }
  if (hatchtimeduration<0){lcd.clear();lcd.print("Hatched out");while(1);}
}

[fcgfilho]

kolaha, como fazer para recomeçar a contagem para fazer outro período de espera de 60 minutos para outra rolagem?

[kolaha]

corrected