I would like to recommend you follow the below debugging process to find out the source of issue:
Connect your pump directly to the power source to check if the problem is on the pump or not.
If the pump works, connect your pump to the relay, and test if the relay can control the pump or not.
If the relay works, connect the pump to Arduino via relay and try the simplest code in the Arduino control pump tutorial to make sure that your wiring is correct.
Sounds like the relay contacts are sticking. Do you have a kickback suppression diode across the pump leads? If the indicator LED on the relay module goes OFF, but the pump still runs, tap the top of the relay with a small screwdriver handle and see if it releases.
hey guys now my relay module is sending turning green always and it keeps the pump on but my soil moisture sensor is high enough that it should turn off the pump but it stays on
Does the green LED indicate the the relay module is powered or that the relay is activated? Please post the relay's datasheet or it's brand name and exact part number or the web page of the place where you bought it.
Can you please post some images of your project?
So we can see your component layout.
Can you please post a copy of your circuit, a picture of a hand drawn circuit in jpg, png?
Hand drawn and photographed is perfectly acceptable.
Please include ALL hardware, power supplies, component names and pin labels.
What are you using as a power supply for the pump?