Help with my first arduino code

loik-kun · April 14, 2021, 4:09am

my code:

int buttonPin = 5;`
int GREEN = 2;
int YELLOW = 3;
int RED = 4;
int DELAY_GREEN = 1000;
int DELAY_YELLOW = 1000;
int DELAY_RED = 1000;


// basic functions
void setup()
{
  pinMode(GREEN, OUTPUT);
  pinMode(YELLOW, OUTPUT);
  pinMode(RED, OUTPUT);
}

void loop()
{
 int green_light();
  delay(DELAY_GREEN);
 int yellow_light();
  delay(DELAY_YELLOW);
 int red_light();
  delay(DELAY_RED);
}

void green_light()
{
  digitalWrite(GREEN, HIGH);
  digitalWrite(YELLOW, LOW);
  digitalWrite(RED, LOW);
}

void yellow_light()
{
  digitalWrite(GREEN, LOW);
  digitalWrite(YELLOW, HIGH);
  digitalWrite(RED, LOW);
}

void red_light()
{
  digitalWrite(GREEN, LOW);
  digitalWrite(YELLOW, LOW);
  digitalWrite(RED, HIGH);
}

void loop()
{
  if(digitalRead(buttonPin) == LOW)
  {
    
    void green_light()
    {
      digitalWrite(GREEN, HIGH);
      digitalWrite(YELLOW, LOW);
      digitalWrite(RED, LOW);
      }

    void yellow_light()
    {
      digitalWrite(GREEN, LOW);
      digitalWrite(YELLOW, HIGH);
      digitalWrite(RED, LOW);         
      }

      void red_light()
      {
      digitalWrite(GREEN, LOW);
      digitalWrite(YELLOW, LOW);
      digitalWrite(RED, HIGH);
       }
    
    
    
    
    
    
    
    
    }
  }

The error i am getting:

Arduino: 1.8.13 (Windows 10), Board: "Arduino Uno"

nuclear_thing_idk:51:3: error: expected unqualified-id before 'if'

if(digitalRead(buttonPin) == LOW)

^~

nuclear_thing_idk:75:3: error: expected declaration before '}' token

}

^

exit status 1

expected unqualified-id before 'if'

This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

I'm sorry if this post isnt really well put together its 1AM i have school and my english is very bad.

anon57585045 · April 14, 2021, 4:33am

You already defined the function, remove the void keyword from where you use them inside loop().

TomGeorge · April 14, 2021, 5:03am

Hi,
Welcome to the forum.

What do you want your code to do?
Apart from what @anon57585045 has said you may need to read up on the format of functions and how to call them?

Tom...

jimLee · April 14, 2021, 5:06am

Looks to me like you are trying to write something like this..

int buttonPin = 5;
int GREEN = 2;
int YELLOW = 3;
int RED = 4;
int DELAY_GREEN = 1000;
int DELAY_YELLOW = 1000;
int DELAY_RED = 1000;


// basic functions
void setup() {
  pinMode(GREEN, OUTPUT);
  pinMode(YELLOW, OUTPUT);
  pinMode(RED, OUTPUT);
}

void loop() {
   
   green_light();
   delay(DELAY_GREEN);
   yellow_light();
   delay(DELAY_YELLOW);
   red_light();
   delay(DELAY_RED);
}


void green_light() {
  
  digitalWrite(GREEN, HIGH);
  digitalWrite(YELLOW, LOW);
  digitalWrite(RED, LOW);
}

void yellow_light() {
   
  digitalWrite(GREEN, LOW);
  digitalWrite(YELLOW, HIGH);
  digitalWrite(RED, LOW);
}

void red_light() {
   
  digitalWrite(GREEN, LOW);
  digitalWrite(YELLOW, LOW);
  digitalWrite(RED, HIGH);
}

/*
// TROUBLE HERE, YOU CAN ONLY HAVE ONE loop().
void loop() {
  
  if(digitalRead(buttonPin) == LOW) {
      green_light();
      yellow_light();
      red_light();
   }
}
*/

But I may be wrong. Also you can only have one loop() function. You tried to write two of them.

Looks like code tags are different here.. I guess at some point the'll sort that one out.

-jim lee

loik-kun · April 14, 2021, 5:33am

thanks for your help but it is not exactly what im trying to do.

I want to, whenever i press the button, it will start the green, yellow, red thing.

sorry if i'm asking for to much

TomGeorge · April 14, 2021, 5:42am

Hi,

Can you post your circuit?
A hand drawn and posted image will be fine.
How have you got your button wired?

Did you try @jimLee 's code without the last void loop?

Tom....

jimLee · April 14, 2021, 5:57am

Oh! Like this?

int buttonPin = 5;
int GREEN = 2;
int YELLOW = 3;
int RED = 4;
int DELAY_GREEN = 1000;
int DELAY_YELLOW = 1000;
int DELAY_RED = 1000;


// basic functions
void setup() {
  pinMode(GREEN, OUTPUT);
  pinMode(YELLOW, OUTPUT);
  pinMode(RED, OUTPUT);
}

void loop() {

   if(digitalRead(buttonPin) == LOW) {
      green_light();
      delay(DELAY_GREEN);
      yellow_light();
      delay(DELAY_YELLOW);
      red_light();
      delay(DELAY_RED);
   }
}


void green_light() {
  
  digitalWrite(GREEN, HIGH);
  digitalWrite(YELLOW, LOW);
  digitalWrite(RED, LOW);
}

void yellow_light() {
   
  digitalWrite(GREEN, LOW);
  digitalWrite(YELLOW, HIGH);
  digitalWrite(RED, LOW);
}

void red_light() {
   
  digitalWrite(GREEN, LOW);
  digitalWrite(YELLOW, LOW);
  digitalWrite(RED, HIGH);
}

-jim lee

loik-kun · April 14, 2021, 2:57pm

im writing it but it might be long cuz im bad a this.

thanks for helping me!

StefanL38 · April 14, 2021, 7:06pm

Hi loik,

Take a look into this tutorial:

Arduino Programming Course

It is easy to understand and has a good mixture between explaining important concepts and example-codes to get you going. So give it a try and report your opinion about this tutorial.

best regards Stefan

StefanL38 · April 14, 2021, 7:36pm

Hi loik,

here is a version of your code that compiles.
I added some comments to explain what the different parts of the code do.
Though my comments do not explain all details.

int buttonPin = 5;
int GREEN = 2;
int YELLOW = 3;
int RED = 4;
int DELAY_GREEN = 1000;
int DELAY_YELLOW = 1000;
int DELAY_RED = 1000;

// define function named green_light
void green_light() {
  digitalWrite(GREEN, HIGH);
  digitalWrite(YELLOW, LOW);
  digitalWrite(RED, LOW);
}

// define function named yellow_light
void yellow_light() {
  digitalWrite(GREEN, LOW);
  digitalWrite(YELLOW, HIGH);
  digitalWrite(RED, LOW);
}

// define function named red_light
void red_light() {
  digitalWrite(GREEN, LOW);
  digitalWrite(YELLOW, LOW);
  digitalWrite(RED, HIGH);
}

// basic functions
void setup() {
  pinMode(GREEN, OUTPUT);
  pinMode(YELLOW, OUTPUT);
  pinMode(RED, OUTPUT);
}

void loop() {
  if (digitalRead(buttonPin) == LOW) {
    green_light();  // execute commands of function green_light
    delay(DELAY_GREEN);

    yellow_light(); // execute commands of function yellow_light
    delay(DELAY_YELLOW);

    red_light();    // execute commands of function red_light
    delay(DELAY_RED);
  }
}

best regards Stefan

jimLee · April 14, 2021, 8:36pm

@StefanL38 You missed the button bit.

-jim lee

TomGeorge · April 14, 2021, 9:38pm

Hi,
You don't have to copy it by writing the code you want to try.
Just select the icon in the top right corner of the code block then paste into the IDE.

Tom...

StefanL38 · April 15, 2021, 6:24am

YOu are right. I added the if-condition for the button.
best regards Stefan

StefanL38 · April 15, 2021, 6:33am

system · August 13, 2021, 6:34am

This topic was automatically closed 120 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
First ARDUINO project. General Guidance	20	4525	May 5, 2021
Newbie trying to write code for first time Programming	22	3935	May 5, 2021
First sketch by total n00b Syntax & Programs	10	1802	May 6, 2021
Problem with REALLY simple code!! please help Programming	9	1116	May 5, 2021
PLS HELP!? Programming	7	1216	May 5, 2021

Help with my first arduino code

Related topics