mqtt = new Adafruit_MQTT_Client(&client ...) not connecting

Projects Programming
1

I have an issue with declaring mqtt and then configure in setup.

#include <WiFiManager.h> // https://github.com/tzapu/WiFiManager
#include <ArduinoJson.h>
//for LED status
#include <Ticker.h>
Ticker ticker;
#include <DNSServer.h>
#include <ESP8266WebServer.h>
#include <WiFiManager.h>
#include <ArduinoJson.h> 

#include "Adafruit_MQTT.h"
#include "Adafruit_MQTT_Client.h"
.
.
.
WiFiClient client;

Adafruit_MQTT_Client *mqtt;
Adafruit_MQTT_Subscribe *OP1;
Adafruit_MQTT_Subscribe *OP2;
.
.
void setup() {

.
.
.
  char *strings1= "behmadi";
  char *strings2 = "aio_hitc98ZL.........iZAoikz9";
  char* MQTT_NAME = strings1;
  char* MQTT_PASS = strings2;
  char* feed1 = "/f/op1"; 
  char MQTT_NAME_FEED1[30] = "behmadi/f/op1"; 
  char MQTT_NAME_FEED2[30] = "behmadi/f/op2";
  
  
  Serial.println("adafruit config BEFOR loading");
  Serial.println(MQTT_SERV);
  Serial.println(MQTT_PORT);
  Serial.println(MQTT_NAME);
  Serial.println(MQTT_PASS);
  Serial.println("feeds");
  Serial.println(MQTT_NAME_FEED1);
  Serial.println(MQTT_NAME_FEED2);
   // load json, etc
  mqtt = new Adafruit_MQTT_Client(&client, MQTT_SERV, MQTT_PORT, MQTT_NAME, MQTT_PASS);

  //Set up the feed you're subscribing to
  OP1 = new Adafruit_MQTT_Subscribe(mqtt, MQTT_NAME_FEED1);
  OP2 = new Adafruit_MQTT_Subscribe(mqtt, MQTT_NAME_FEED2);

If I use the same values ay start up and use
Adafruit_MQTT_Client mqtt(&client, MQTT_SERV, MQTT_PORT, MQTT_NAME, MQTT_PASS);

it works fine and connect

char mqtt_server[40]="io.adafruit.com";
char mqtt_port[6] = "1883";
char blynk_token[70] = "behmadi,aio_hitc98ZLeJQLX5hX0SO1iZAoikz9";
//---------------------------
 unsigned int MQTT_PORT = atoi (mqtt_port);
  char* MQTT_SERV = mqtt_server;
  
  char *strings1= "behmadi";
  char *strings2 = "aio_hitc98Z...............ZAoikz9";
  
  
  char* MQTT_NAME = strings1;
  char* MQTT_PASS = strings2;
  //feed 1 string
  //char* feed1 = "/f/op1";  
  char MQTT_NAME_FEED1[30] = "behmadi/f/op1";

  //feed 2 string
  //char* feed2 = "/f/op2";
  char MQTT_NAME_FEED2[30] = "behmadi/f/op2";
  //strcpy(MQTT_NAME_FEED2, MQTT_NAME);
  ///strcat(MQTT_NAME_FEED2, feed2);
  //puts(MQTT_NAME_FEED2);
//----------------------------
const char* WIFI_SSID =  "WiFi-F4B0"; 
const char* WIFI_PASS = "4..."; 
int ledPin = 12;
int ledPin1 = 14;
//Set up MQTT and WiFi clients
WiFiClient client;
Adafruit_MQTT_Client mqtt(&client, MQTT_SERV, MQTT_PORT, MQTT_NAME, MQTT_PASS);

//Set up the feed you're subscribing to
Adafruit_MQTT_Subscribe op1 = Adafruit_MQTT_Subscribe(&mqtt, MQTT_NAME_FEED1);
Adafruit_MQTT_Subscribe op2 = Adafruit_MQTT_Subscribe(&mqtt, MQTT_NAME_FEED2);

void setup()

{
.
.
2

I have narrowed down the issue with

OP1 = new Adafruit_MQTT_Subscribe(mqtt, MQTT_FEED1);

if I use

const char* feed1 =  "MyUSERNAME/f/op1";

OP1 = new Adafruit_MQTT_Subscribe(mqtt, feed1);

It works fine

if I try to create the feed string it breaks and Adafruit IO return bad command

   const char* MQTT_NAME  = strings[0]; //MyUserName  from config file// 
  const char* feed1 =  "/f/op1";
  const char* feed2 =   "/f/op2";
  char* MQTT_PASS = strings[1];//"aio_hitc98ZL..........ZAoikz9"; //;
  //feed 1 string

  char MQTT_NAME_FEED1[20] = "\0";
  strcat(MQTT_NAME_FEED1,MQTT_NAME);
  strcat(MQTT_NAME_FEED1,feed1);
  delay(200);
  
  String s1((const __FlashStringHelper*) MQTT_NAME_FEED1);
  const char* MQTT_FEED1 = s1.c_str();
.
.


OP1 = new Adafruit_MQTT_Subscribe(mqtt, MQTT_FEED1);

Please help

3

Try

const char* MQTT_NAME_FEED1 = "behmadi/f/op1";
4

I know that will work

The problem is "behmadi" is the account name and gets entered at configuration time ie WiFi config.

I need to read account name from config file and combine it with feed ie /f/op1