Range Sensor to Analog

As part of a project, I'm building a range sensor module that outputs the distance to an analog output via a DAC. It all works as expected and I've added a potentiometer to set the max range for the sensor and a spst switch to set the mode of closer vs farther.

Below is the code with more details @ GitHub - shaiss/LittleBitsUltrasonicRangeSensor: code for littlebits ultrasonic range sensor module including the code and fritzing diagram.

I'm hoping for some feedback on the code below. While it works, I know it can be better, including better debugging and not using floats (any guidance there would be appreciated). Please feel free to comment or question any of the code. As I update it, I'll commit to github and share the latest.

Thank you!

/* Ping))) Sensor

   This sketch reads a PING))) ultrasonic rangefinder and returns the
   distance to the closest object in range. To do this, it sends a pulse
   to the sensor to initiate a reading, then listens for a pulse
   to return.  The length of the returning pulse is proportional to
   the distance of the object from the sensor.

   The circuit:
  * +V connection of the PING))) attached to +5V
  * GND connection of the PING))) attached to ground
  * SIG connection of the PING))) attached to digital pin 2

   http://www.arduino.cc/en/Tutorial/Ping

   created 3 Nov 2008
   by David A. Mellis
   modified 06 Aug 2011
   by Tom Igoe
   modified 22 Jun 2015
   by Shai Perednik shaiss@gmail.com

   This example code is in the public domain.

 */

#include <Wire.h>
#define PCF8591 (0x90 >> 1) // I2C bus address

// this constant won't change.  It's the pin number
// of the sensor's output:
const int trimpot = A0;
const int slidebtn = 7;
const int pingPin = 2; //Sig pin of the Ping))) Sensor
const int ledPin = 6; //The pin the LED is attached to

//define some vars
float brightness = 0; //set the initial value to null
int analogVolts = 0; //set initial value to null for voltage out
float trimpotval = 0; //potentiometer on trimpot pin's current position
float maxrange = 0; //max range sensor is set to

void setup() {
  // initialize serial communication:
  Serial.begin(9600);
  pinMode(ledPin, OUTPUT);  //declare ledPin as an output
  pinMode(slidebtn, INPUT); //declare the slidebtn as an input

  Wire.begin();
}

void loop()
{
  //read trimpot's value
  trimpotval = analogRead(trimpot);

  maxrange = (trimpotval/1023)*300;
  
  // establish variables for duration of the ping,
  // and the distance result in inches and centimeters:
  long duration, inches, cm;

  // The PING))) is triggered by a HIGH pulse of 2 or more microseconds.
  // Give a short LOW pulse beforehand to ensure a clean HIGH pulse:
  pinMode(pingPin, OUTPUT);
  digitalWrite(pingPin, LOW);
  delayMicroseconds(2);
  digitalWrite(pingPin, HIGH);
  delayMicroseconds(5);
  digitalWrite(pingPin, LOW);

  // The same pin is used to read the signal from the PING))): a HIGH  
  // pulse whose duration is the time (in microseconds) from the sending
  // of the ping to the reception of its echo off of an object.
  pinMode(pingPin, INPUT);
  duration = pulseIn(pingPin, HIGH);

  // convert the time into a distance
  inches = microsecondsToInches(duration);
  cm = microsecondsToCentimeters(duration);

  //convert distance of object to brightness.  
  //Ping))) range is 2cm - 3M/.78in - 118.11in
  if (digitalRead(slidebtn) == HIGH) {
    //if slide btn is HIGH or on, then sensor is in close mode
    brightness = ((((cm/maxrange)*255)-255)*-1);  //closer == brighter.  If cm =0 returns 255.
  }
  else {
    //if slide btn is LOW or off, then sensor is in far mode
    brightness = ((cm/maxrange))*255; //farther == brighter.  If cm = 300 returns 255
  }

  if (brightness > 255){brightness = 255;}
  if (brightness < 0) {brightness = 0;}
    
  //Serial.println(brightness);
  
  //write distance to LED
  analogWrite(ledPin, brightness);

  analogVolts = (int) brightness; //convert (aka cast) the brightness value from float to int
  
  //start write values to dac
  Wire.beginTransmission(PCF8591); // wake up PCF8591
  Wire.write(0x40); // control byte - turn on DAC (binary 1000000)
  Wire.write(analogVolts); // value to send to DAC
  Wire.endTransmission(); // end tranmission
  //end write values to dac

  //Serial.print(inches);
  //Serial.print("in, ");
  Serial.print(cm);
  Serial.print("cm  | ");
  Serial.print("brightness: ");
  Serial.print(brightness);
  Serial.print("  aout: ");
  Serial.print(analogVolts);
  Serial.print("  | maxrange: ");
  Serial.print(maxrange);
  Serial.print("  | trimpot: ");
  Serial.print(analogRead(trimpot));
  Serial.print("  | trimpotval: ");
  Serial.print(trimpotval);
  Serial.print("  | slidebtn: ");
  Serial.print(digitalRead(slidebtn));
  Serial.println();
  
  delay(100);
}

long microsecondsToInches(long microseconds)
{
  // According to Parallax's datasheet for the PING))), there are
  // 73.746 microseconds per inch (i.e. sound travels at 1130 feet per
  // second).  This gives the distance travelled by the ping, outbound
  // and return, so we divide by 2 to get the distance of the obstacle.
  // See: http://www.parallax.com/dl/docs/prod/acc/28015-PING-v1.3.pdf
  return microseconds / 74 / 2;
}

long microsecondsToCentimeters(long microseconds)
{
  // The speed of sound is 340 m/s or 29 microseconds per centimeter.
  // The ping travels out and back, so to find the distance of the
  // object we take half of the distance travelled.
  return microseconds / 29 / 2;
}
  trimpotval = analogRead(trimpot);

analogRead returns an "int", so why bother assigning it to a float?

maxrange = (trimpotval/1023)*300;

This statement seems very unlikely to work. Isn't trimpotval/1023 going to be almost always zero ?

Isn't trimpotval/1023 going to be almost always zero ?

No, because trimpotval is a float. So, floating point arithmetic will be performed. Using 1023.0 would still be a good idea, to make it clear that OP knows that there is a difference between floating point arithmetic and integer arithmetic.

That way, when OP heeds AWOL's advice, no surprises will happen (as you observed).