IT'S ME
^>just ignore this<^
So, I decided to make a synthesizer using 5 buttons (That's all I have T_T), and the problem I am having is the first button (SW1) doesn't activate the buzzer, the buzzer just plays the note until I unplug it. I prolly did somethin' wrong on line 130.
Synthesizer.ino (2.63 KB)
Yes, you did.
You also didn't post your code in code tags even though you seem to have mastered a couple of other forum features.
Pete
el_supremo:
Yes, you did.
What's wrong with it?
You also didn't post your code in code tags even though you seem to have mastered a couple of other forum features.
like "
//this?
Yeah, like that.
kk
// NB: ALL NOTES DEFINED WITH STANDARD ENGLISH NAMES, EXCEPT FROM "A"
//THAT IS CALLED WITH THE ITALIAN NAME "LA" BECAUSE A0,A1...ARE THE ANALOG PINS ON ARDUINO.
// (Ab IS CALLED Ab AND NOT LAb)
//Defining notes
#define C0 16.35
#define Db0 17.32
#define D0 18.35
#define Eb0 19.45
#define E0 20.60
#define F0 21.83
#define Gb0 23.12
#define G0 24.50
#define Ab0 25.96
#define LA0 27.50
#define Bb0 29.14
#define B0 30.87
#define C1 32.70
#define Db1 34.65
#define D1 36.71
#define Eb1 38.89
#define E1 41.20
#define F1 43.65
#define Gb1 46.25
#define G1 49.00
#define Ab1 51.91
#define LA1 55.00
#define Bb1 58.27
#define B1 61.74
#define C2 65.41
#define Db2 69.30
#define D2 73.42
#define Eb2 77.78
#define E2 82.41
#define F2 87.31
#define Gb2 92.50
#define G2 98.00
#define Ab2 103.83
#define LA2 110.00
#define Bb2 116.54
#define B2 123.47
#define C3 130.81
#define Db3 138.59
#define D3 146.83
#define Eb3 155.56
#define E3 164.81
#define F3 174.61
#define Gb3 185.00
#define G3 196.00
#define Ab3 207.65
#define LA3 220.00
#define Bb3 233.08
#define B3 246.94
#define C4 261.63
#define Db4 277.18
#define D4 293.66
#define Eb4 311.13
#define E4 329.63
#define F4 349.23
#define Gb4 369.99
#define G4 392.00
#define Ab4 415.30
#define LA4 440.00
#define Bb4 466.16
#define B4 493.88
#define C5 523.25
#define Db5 554.37
#define D5 587.33
#define Eb5 622.25
#define E5 659.26
#define F5 698.46
#define Gb5 739.99
#define G5 783.99
#define Ab5 830.61
#define LA5 880.00
#define Bb5 932.33
#define B5 987.77
#define C6 1046.50
#define Db6 1108.73
#define D6 1174.66
#define Eb6 1244.51
#define E6 1318.51
#define F6 1396.91
#define Gb6 1479.98
#define G6 1567.98
#define Ab6 1661.22
#define LA6 1760.00
#define Bb6 1864.66
#define B6 1975.53
#define C7 2093.00
#define Db7 2217.46
#define D7 2349.32
#define Eb7 2489.02
#define E7 2637.02
#define F7 2793.83
#define Gb7 2959.96
#define G7 3135.96
#define Ab7 3322.44
#define LA7 3520.01
#define Bb7 3729.31
#define B7 3951.07
#define C8 4186.01
#define Db8 4434.92
#define D8 4698.64
#define Eb8 4978.03
// DURATION OF THE NOTES
#define BPM 140 // you can change this value changing all the others
#define H 2*Q //half 2/4
#define Q 60000/BPM //quarter 1/4
#define E Q/2 //eighth 1/8
#define S Q/4 // sixteenth 1/16
#define W 4*Q // whole 4/4
//Defining buttons
#define SW1 2
#define SW2 3
#define SW3 4
#define SW4 5
#define SW5 6
#define BUZ 7
void setup() {
pinMode(2, INPUT);
pinMode(3, INPUT);
pinMode(4, INPUT);
pinMode(5, INPUT);
pinMode(6, INPUT);
pinMode(7, OUTPUT);
digitalWrite(7, LOW);
}
void loop() {
if (SW1 == LOW); {
tone(7, LA3, Q);
}
}
How can SW1 ever be LOW? You defined it to be 2, and (2 == LOW) is always false.
Take a look at the digitalRead function. Google 'Arduino internal pull-up resistor' as well.
Check the syntax for the if statement as well. The semicolon after the if causes the if clause to be just an empty statement.
Edit: el_supremo beat me to it.
Pieter
That's better.
if (SW1 == LOW); {
That semicolon shouldn't be there (and what @Pieter said).
Pete
@Petier: oooooohhhhh, I see! "2" means the pin voltage(Prolly explained dat wrong, gg me)! And what's wrong with the digitalWrite?
I removed the ";", but now the buzzer won't play the tone.
Post your code again.
Pete
No. Post it in code tags like you did before.
Pete
// NB: ALL NOTES DEFINED WITH STANDARD ENGLISH NAMES, EXCEPT FROM "A"
//THAT IS CALLED WITH THE ITALIAN NAME "LA" BECAUSE A0,A1...ARE THE ANALOG PINS ON ARDUINO.
// (Ab IS CALLED Ab AND NOT LAb)
//Defining notes
#define C0 16.35
#define Db0 17.32
#define D0 18.35
#define Eb0 19.45
#define E0 20.60
#define F0 21.83
#define Gb0 23.12
#define G0 24.50
#define Ab0 25.96
#define LA0 27.50
#define Bb0 29.14
#define B0 30.87
#define C1 32.70
#define Db1 34.65
#define D1 36.71
#define Eb1 38.89
#define E1 41.20
#define F1 43.65
#define Gb1 46.25
#define G1 49.00
#define Ab1 51.91
#define LA1 55.00
#define Bb1 58.27
#define B1 61.74
#define C2 65.41
#define Db2 69.30
#define D2 73.42
#define Eb2 77.78
#define E2 82.41
#define F2 87.31
#define Gb2 92.50
#define G2 98.00
#define Ab2 103.83
#define LA2 110.00
#define Bb2 116.54
#define B2 123.47
#define C3 130.81
#define Db3 138.59
#define D3 146.83
#define Eb3 155.56
#define E3 164.81
#define F3 174.61
#define Gb3 185.00
#define G3 196.00
#define Ab3 207.65
#define LA3 220.00
#define Bb3 233.08
#define B3 246.94
#define C4 261.63
#define Db4 277.18
#define D4 293.66
#define Eb4 311.13
#define E4 329.63
#define F4 349.23
#define Gb4 369.99
#define G4 392.00
#define Ab4 415.30
#define LA4 440.00
#define Bb4 466.16
#define B4 493.88
#define C5 523.25
#define Db5 554.37
#define D5 587.33
#define Eb5 622.25
#define E5 659.26
#define F5 698.46
#define Gb5 739.99
#define G5 783.99
#define Ab5 830.61
#define LA5 880.00
#define Bb5 932.33
#define B5 987.77
#define C6 1046.50
#define Db6 1108.73
#define D6 1174.66
#define Eb6 1244.51
#define E6 1318.51
#define F6 1396.91
#define Gb6 1479.98
#define G6 1567.98
#define Ab6 1661.22
#define LA6 1760.00
#define Bb6 1864.66
#define B6 1975.53
#define C7 2093.00
#define Db7 2217.46
#define D7 2349.32
#define Eb7 2489.02
#define E7 2637.02
#define F7 2793.83
#define Gb7 2959.96
#define G7 3135.96
#define Ab7 3322.44
#define LA7 3520.01
#define Bb7 3729.31
#define B7 3951.07
#define C8 4186.01
#define Db8 4434.92
#define D8 4698.64
#define Eb8 4978.03
// DURATION OF THE NOTES
#define BPM 140 // you can change this value changing all the others
#define H 2*Q //half 2/4
#define Q 60000/BPM //quarter 1/4
#define E Q/2 //eighth 1/8
#define S Q/4 // sixteenth 1/16
#define W 4*Q // whole 4/4
//Defining buttons
#define SW1 2
#define SW2 3
#define SW3 4
#define SW4 5
#define SW5 6
#define BUZ 7
//added stuff while waiting fer reply
int buttonValue1;
int buttonState1;
//END added stuff
void setup() {
pinMode(2, INPUT);
pinMode(3, INPUT);
pinMode(4, INPUT);
pinMode(5, INPUT);
pinMode(6, INPUT);
pinMode(7, OUTPUT);
digitalWrite(7, LOW);
}
void loop() {
buttonValue1 == digitalRead(SW1); //Modded
if (buttonValue1 != buttonState1); {//This too!
tone(7, F3, Q);
}
buttonValue1 == buttonState1;//Added
}
buttonValue1 == buttonState1;//Added
As written, this statement does nothing useful because you have == instead of =. Once that's fixed, you have the variables the wrong way round. Not much point changing buttonValue1 here, you're going to change it almost immediately with the new state of the button.
buttonState1 = buttonValue1;//Added
Pete
el_supremo:
buttonValue1 == buttonState1;//AddedAs written, this statement does nothing useful because you have == instead of =. Once that's fixed, you have the variables the wrong way round. Not much point changing buttonValue1 here, you're going to change it almost immediately with the new state of the button.
buttonState1 = buttonValue1;//AddedPete
so put it like this?
int buttonState;
int buttonValue;
and I'm used to "==", maybe from JS or Swift (I stopped learning JS, and Swift is on hiatus)
Is this what you're trying to say?
void loop() {
buttonValue1 = digitalRead(SW1); //Modded
if (buttonValue1 != buttonState1); {//This too!
tone(7, F3, Q);
buttonState1 = buttonValue1;//Added
}
}
Sure, that may work!
But do any of yall know what's wrong with the if? I think we went sorta off topic
Yes. As was pointed out before, you need to remove the ;
void loop() {
buttonValue1 = digitalRead(SW1);
if (buttonValue1 != buttonState1) {
tone(7, F3, Q);
buttonState1 = buttonValue1;
}
}
removed
if (buttonValue1 != buttonState1) { //This too!
tone(7, F3, Q);
buttonValue1 = buttonState1; //Added
I uploaded the Button example, and that worked fine. but when I tried to integrate the 'if' into my synth code, it reverts to playing the buzzer.