Two Buttons, Two LEDs

GoBraves21 · March 4, 2016, 12:32am

I finally received my Arduino today, and have been trying to do a project. I want to control each led separately with two separate buttons on my remote. It works with led 1 and button 1, but not with led 2 and button 2. Can anyone help me please? Thank you. Here is my code:

// constants won't change. They're used here to
// set pin numbers:
const int buttonPin1 = 2; // the number of the pushbutton pin
const int buttonPin2 = 3;
const int ledPin2 = 12;
const int ledPin1 = 13; // the number of the LED pin

// variables will change:
int buttonState = 0; // variable for reading the pushbutton status

void setup() {
// initialize the LED pin as an output:
pinMode(ledPin1, OUTPUT);
// initialize the pushbutton pin as an input:
pinMode(buttonPin1, INPUT);
pinMode(ledPin2, OUTPUT);
pinMode(buttonPin2, INPUT);
}

void loop() {
// read the state of the pushbutton value:
buttonState = digitalRead(buttonPin1);

// check if the pushbutton is pressed.
// if it is, the buttonState is HIGH:
if (buttonState == HIGH) {
digitalWrite(ledPin1, LOW);
delay(1000);
digitalWrite(ledPin1, HIGH);
delay(1000);
digitalWrite(ledPin1, LOW);

// read the state of the pushbutton value:
buttonState = digitalRead(buttonPin2);

// check if the pushbutton is pressed.
// if it is, the buttonState is HIGH:
if (buttonState == HIGH) {
digitalWrite(ledPin2, LOW);
delay(1000);
digitalWrite(ledPin2, HIGH);
delay(1000);
digitalWrite(ledPin2, LOW);
}
}}

LarryD · March 4, 2016, 12:45am

Maybe you mean this:

// constants won't change. They're used here to
// set pin numbers:
const int buttonPin1 = 2;     // the number of the pushbutton pin
const int buttonPin2 = 3;
const int ledPin2 =  12;
const int ledPin1 =  13;      // the number of the LED pin

// variables will change:
int buttonState = 0;         // variable for reading the pushbutton status

void setup() {
  // initialize the LED pin as an output:
  pinMode(ledPin1, OUTPUT);
  // initialize the pushbutton pin as an input:
  pinMode(buttonPin1, INPUT_PULLUP);
  pinMode(ledPin2, OUTPUT);
  pinMode(buttonPin2, INPUT_PULLUP);
}

void loop() {
  // read the state of the pushbutton value:
  buttonState = digitalRead(buttonPin1);

  // check if the pushbutton is pressed.
  // if it is, the buttonState is HIGH:
  if (buttonState == HIGH) {
    digitalWrite(ledPin1, LOW);
    delay(1000);
    digitalWrite(ledPin1, HIGH);
    delay(1000);
    digitalWrite(ledPin1, LOW);
  }

  // read the state of the pushbutton value:
  buttonState = digitalRead(buttonPin2);

  // check if the pushbutton is pressed.
  // if it is, the buttonState is HIGH:
  if (buttonState == HIGH) {
    digitalWrite(ledPin2, LOW);
    delay(1000);
    digitalWrite(ledPin2, HIGH);
    delay(1000);
    digitalWrite(ledPin2, LOW);
  }
}

Using delay() is bad.
Read this, Demonstration code for several things at the same time:
http://forum.arduino.cc/index.php?topic=223286.0

GoBraves21 · March 4, 2016, 12:55am

Thank you so much! It works now! I read that a little bit, but I mean I'm a total noob at this. Basically I'd like to use this kind of code as a timer for a table hockey game I have. We usually play three minute periods, so I'd want to press the one button for that, and press another button for when a goal is scored. What advice would you have for changing the code since using delay isn't good? Thanks again!

anon57585045 · March 4, 2016, 12:59am

GoBraves21:
Thank you so much! It works now! I read that a little bit, but I mean I'm a total noob at this. Basically I'd like to use this kind of code as a timer for a table hockey game I have. We usually play three minute periods, so I'd want to press the one button for that, and press another button for when a goal is scored. What advice would you have for changing the code since using delay isn't good? Thanks again!

Try to understand how it works. Then changing it to do what you want will be easy. Post any specific questions that we can answer.

For the buttons, the only specification you gave for how they operate, is "for that". You need to begin by developing concise, exact language for what is supposed to happen (and when).

For example, what is supposed to happen when a goal is scored?

GoBraves21 · March 4, 2016, 1:13am

Ok, thanks. I tried to grasp some of it, and I mean I get kind of what it is saying, but I'm still pretty lost on it. Basically I want to press a button, have a green light be off 180 seconds, and then turn on to signal the end of the period for 10 seconds then back off. Then I'd want to press that button to start the next period, unless it was the end of the game of course. For a goal, I'd want to press another button and have the light come on right then and stay on for 5 seconds, then back off, and do the same for whenever a goal is scored.

GoBraves21 · March 4, 2016, 1:22am

The major drawback with how I started the code I see now is that the second button does not switch on the LED if I have pressed the other button.

anon57585045 · March 4, 2016, 1:44am

GoBraves21:
The major drawback with how I started the code I see now is that the second button does not switch on the LED if I have pressed the other button.

That major drawback, to put it in a more general way, is that you have used the delay() function. Nothing can happen while it's running.

LarryD · March 4, 2016, 1:56am

Let us ask a few questions.

What would happen here?

if(millis() - Millis12 >= 180*1000)
  {
    digitalWrite(12, !digitalRead(12));
  }

GoBraves21 · March 4, 2016, 2:03am

Yeah, I figured out why using delay is bad. Thanks aarg, and let me see if I can get this right Larry. If the current milliseconds subtracted by Millis12 (which I assume is 0 because that is when I would push it right?) is equal to or greater than 180,000 milliseconds, then the light would turn on?

anon57585045 · March 4, 2016, 2:06am

180*1000 would overflow an int, thus comparing with -16608?

LarryD · March 4, 2016, 2:12am

Yes, good!

It will actually toggle the led every 180000ms since it uses the not current read of 12 to write to 12.

This does not pause your code as would: delay(180000ul);
Does this make sense?

And yes Millis12 would have to be unsigned long and 180*1000ul would be needed.
.

GoBraves21 · March 4, 2016, 2:40am

Ok, thanks! So, for the one LED that I would want off for 180 seconds and then on for 10 seconds and back off again, how exactly would I change that code you put up for me earlier without using delay?

GoBraves21 · March 4, 2016, 9:17pm

I tried to get this code working without delay, but I haven't been able to get it to work like I want. Can anyone help me out? I know this isn't the actual time I would want to use for my game, but I'm trying to get both LEDs to work independently of one another. Here is my code:

// constants won't change. They're used here to
// set pin numbers:
const int buttonPin1 = 2;     // the number of the pushbutton pin
const int buttonPin2 = 3;
const int ledPin2 =  12;
const int ledPin1 =  13;      // the number of the LED pin

// variables will change:
int buttonState = 0;         // variable for reading the pushbutton status

void setup() {
  // initialize the LED pin as an output:
  pinMode(ledPin1, OUTPUT);
  // initialize the pushbutton pin as an input:
  pinMode(buttonPin1, INPUT_PULLUP);
  pinMode(ledPin2, OUTPUT);
  pinMode(buttonPin2, INPUT_PULLUP);
}

void loop() {
  // read the state of the pushbutton value:
  buttonState = digitalRead(buttonPin1);

  // check if the pushbutton is pressed.
  // if it is, the buttonState is HIGH:
  if (buttonState == HIGH) {
    digitalWrite(ledPin1, HIGH);
    if (millis() >= 5000UL
  ) digitalWrite(ledPin1, LOW)

  // read the state of the pushbutton value:
  ;buttonState = digitalRead(buttonPin2);

  // check if the pushbutton is pressed.
  // if it is, the buttonState is HIGH:
  if (buttonState == HIGH) {
    digitalWrite(ledPin2, HIGH);
  if (millis() >=5000UL
  ) digitalWrite(ledPin2, LOW);
  }  }  }

LarryD · March 4, 2016, 9:36pm

Can you follow this?

const byte ledPin12 = 12;
const byte buttonPin2 = 2;
const unsigned long MyTime = 5000ul;

unsigned long Millis12;
boolean flag12 = false;
byte myCount = 0;
int buttonState = 0;         // variable for reading the pushbutton status

void setup() 
{
  // initialize the LED pin as an output:
  pinMode(ledPin12, OUTPUT);
  //LED off
  digitalWrite(ledPin12, LOW);
  // initialize the push button pin as an input:
  pinMode(buttonPin2, INPUT_PULLUP);
}

void loop() 
{
  // read the state of the push button value:
  buttonState = digitalRead(buttonPin2);

  //if button pressed start timing LED
  if (flag12 == false && buttonState == HIGH) 
  {
    //enable timing
    flag12 = true;
    Millis12 = millis();
    //LED on
    digitalWrite(ledPin12, HIGH);
  }

  //Time to toggle LED?
  if(flag12 == true && millis() - Millis12 >= MyTime)
  {
    //get ready for next iteration
    Millis12 += MyTime;
    //toggle ledPin1
    digitalWrite(ledPin12, !digitalRead(ledPin12));

    if(myCount++ >= 1) //EDIT: was change from > to >=
    {
      //finished with this button press, get ready for the next
      myCount = 0;
      flag12 = false;
      //LED off
      digitalWrite(ledPin12, LOW);
    }
  }

} //END of loop()

LarryD · March 4, 2016, 9:42pm

Oops

if(myCount++ > 1)

change to:

if(myCount++ >= 1)

Paul_B · March 4, 2016, 10:30pm

LarryD:
if(myCount++ >= 1)

I don't think that is a recommended syntax.

LarryD · March 4, 2016, 10:46pm

I just tried, it works, but your are right this should be:

if(myCount >= 1) // may want to change this to >= (another number) if OP was several toggles
{
. . .
}
myCount++;

.

GoBraves21 · March 5, 2016, 2:14am

Thanks a lot for all your help! Ok, so I get a little bit of it. Still not 100% sure on a lot of even after reading about a lot of the terms. The website is great for explanations of many of these terms. Without much programming knowledge, it just hasn't clicked it yet.

I copied and pasted the code so I could get them to work with both LEDs. Now I've mulled over trying to have one of the lights stay off for three minutes, then turn on for 10 seconds, then back off, and have the cycle repeat when I push the button to start the next period. Just to make things easier to test, MyTime2 I would actually want to be 180000ul for the 3 minute period length and MyTime3 I would actually want to be 10000ul for 10 seconds on at the end of the period. It still just hasn't totally clicked. The only difference in the LEDs with how my code is now is that LED13 turns on instantly for 2 seconds after I push my remote button instead of 5. Anymore help would be really appreciated! Thanks!

const byte ledPin12 = 12;
const byte buttonPin2 = 2;
const unsigned long MyTime = 5000ul;
const unsigned long MyTime2 = 2000ul;
const unsigned long MyTime3 = 10000ul;
const byte ledPin13 = 13;
const byte buttonPin3 = 3;

unsigned long Millis12;
unsigned long Millis13;
boolean flag12 = false;
boolean flag13 = false;
byte myCount = 0;
byte myCount2 = 0;
int buttonState = 0;         // variable for reading the pushbutton status

void setup()
{
  // initialize the LED pin as an output:
  pinMode(ledPin12, OUTPUT);
  //LED off
  digitalWrite(ledPin12, LOW);
  // initialize the push button pin as an input:
  pinMode(buttonPin2, INPUT_PULLUP);

  {
  // initialize the LED pin as an output:
  pinMode(ledPin13, OUTPUT);
  //LED off
  digitalWrite(ledPin13, LOW);
  // initialize the push button pin as an input:
  pinMode(buttonPin3, INPUT_PULLUP);
}
}

void loop()
{
  // read the state of the push button value:
  buttonState = digitalRead(buttonPin2);

  //if button pressed start timing LED
  if (flag12 == false && buttonState == HIGH)
  {
    //enable timing
    flag12 = true;
    Millis12 = millis();
    //LED on
    digitalWrite(ledPin12, HIGH);
  }

  //Time to toggle LED?
  if(flag12 == true && millis() - Millis12 >= MyTime)
  {
    //get ready for next iteration
    Millis12 += MyTime;
    //toggle ledPin1
    digitalWrite(ledPin12, !digitalRead(ledPin12));

    if(myCount++ >= 1) //EDIT: was change from > to >=
    {
      //finished with this button press, get ready for the next
      myCount = 0;
      flag12 = false;
      //LED off
      digitalWrite(ledPin12, LOW);
    }
  }
    // read the state of the push button value:
  buttonState = digitalRead(buttonPin3);

  //if button pressed start timing LED
  if (flag13 == false && buttonState == HIGH)
  {
    //enable timing
    flag13 = true;
    Millis13 = millis();
    //LED on
    digitalWrite(ledPin13, HIGH);
  }

  //Time to toggle LED?
  if(flag13 == true && millis() - Millis13 >= MyTime2)
  {
    //get ready for next iteration
    Millis13 += MyTime2;
    //toggle ledPin1
    digitalWrite(ledPin13, !digitalRead(ledPin13));

    if(myCount++ >= 1) //EDIT: was change from > to >=
    {
      //finished with this button press, get ready for the next
      myCount = 0;
      flag13 = false;
      //LED off
      digitalWrite(ledPin13, LOW);
    }
  }

} //END of loop()

LarryD · March 5, 2016, 2:37am

You are using myCount in the code for both buttons, I think you want to use two different counts

1st button
if(myCount++ >= 1)

2nd button
if(myCount++ >= 1)

You should have:
1st button
if(myCount12++ >= 1)

2nd button
if(myCount13++ >= 1)

======================
Your description is confusing to me.
Write what you want in a sequence similar to this:

Button12 is pressed at any time then released
led12 comes on for 1 minute then off for 10 sec then on for 3min off for 12 sec and repeats

Button13 is pressed at any time then released
led13 comes on for 5 minute then off for 50 sec then on for 1min off for 40 sec and repeats

GoBraves21 · March 5, 2016, 3:26am

Ok, thanks for letting me know that. I edited that code with that info.

Here's what I'd like to do with each buttons totally separate of each other. ButtonPin2 goes only with ledPin12, ButtonPin3 goes only with ledPin13.

For Button2, Pin12, I want to press that button, have the light come on instantly for 5 seconds and then go back off, and do the same thing every time I push that button.

For Button3, Pin13, I'd like to press that button, have the light stay off for 180 seconds, turn on for 10 seconds, and then turn back off, and do the same thing every time I press that button.

Here is that slightly updated code by the way as well. Thanks again!

const byte ledPin12 = 12;
const byte buttonPin2 = 2;
const unsigned long MyTime = 5000ul;
const unsigned long MyTime2 = 2000ul;
const unsigned long MyTime3 = 10000ul;
const byte ledPin13 = 13;
const byte buttonPin3 = 3;

unsigned long Millis12;
unsigned long Millis13;
boolean flag12 = false;
boolean flag13 = false;
byte myCount12 = 0;
byte myCount13 = 0;
int buttonState = 0;         // variable for reading the pushbutton status

void setup()
{
  // initialize the LED pin as an output:
  pinMode(ledPin12, OUTPUT);
  //LED off
  digitalWrite(ledPin12, LOW);
  // initialize the push button pin as an input:
  pinMode(buttonPin2, INPUT_PULLUP);

  {
  // initialize the LED pin as an output:
  pinMode(ledPin13, OUTPUT);
  //LED off
  digitalWrite(ledPin13, LOW);
  // initialize the push button pin as an input:
  pinMode(buttonPin3, INPUT_PULLUP);
}
}

void loop()
{
  // read the state of the push button value:
  buttonState = digitalRead(buttonPin2);

  //if button pressed start timing LED
  if (flag12 == false && buttonState == HIGH)
  {
    //enable timing
    flag12 = true;
    Millis12 = millis();
    //LED on
    digitalWrite(ledPin12, HIGH);
  }

  //Time to toggle LED?
  if(flag12 == true && millis() - Millis12 >= MyTime)
  {
    //get ready for next iteration
    Millis12 += MyTime;
    //toggle ledPin1
    digitalWrite(ledPin12, !digitalRead(ledPin12));

    if(myCount12++ >= 1) //EDIT: was change from > to >=
    {
      //finished with this button press, get ready for the next
      myCount12 = 0;
      flag12 = false;
      //LED off
      digitalWrite(ledPin12, LOW);
    }
  }
    // read the state of the push button value:
  buttonState = digitalRead(buttonPin3);

  //if button pressed start timing LED
  if (flag13 == false && buttonState == HIGH)
  {
    //enable timing
    flag13 = true;
    Millis13 = millis();
    //LED on
    digitalWrite(ledPin13, HIGH);
  }

  //Time to toggle LED?
  if(flag13 == true && millis() - Millis13 >= MyTime2)
  {
    //get ready for next iteration
    Millis13 += MyTime2;
    //toggle ledPin1
    digitalWrite(ledPin13, !digitalRead(ledPin13));

    if(myCount13++ >= 1) //EDIT: was change from > to >=
    {
      //finished with this button press, get ready for the next
      myCount13 = 0;
      flag13 = false;
      //LED off
      digitalWrite(ledPin13, LOW);
    }
  }

} //END of loop()

Topic		Replies	Views
3 LEDs controlled by 3 Separate Buttons (not working) LEDs and Multiplexing	31	3174	June 15, 2022
Two leds with one button and "delay" LEDs and Multiplexing	9	1828	August 18, 2021
3 buttons, 2 LEDS assignment Programming Questions	14	8855	May 5, 2021
RGB LED Program Programming Questions	8	3458	May 5, 2021
1 Button 2 LEDS Programming Questions	4	8838	May 5, 2021

Two Buttons, Two LEDs

2nd button if(myCount++ >= 1)

Related Topics

2nd button
if(myCount++ >= 1)