Attiny84 Circuit & Programming

Can anyone please shed some light on why this does not work.

The code and circuit works with an ATTiny85 board I simply wish to add extra i/o to switch on and off leds. RHS of the circuit board is unconnected to the ATTiny84 circuit

The circuit supplies 5v to the board and an optocoupler sends a dcc signal to pin PA2.

I have successfully programmed a Blink program which turns on 6 leds in turn into the ATTiny84 using the Tiny AVR programmer (ATTiny Core) so I am fairly confident that the code is being correctly received. The code is based on code supplied by Geoff Bunza, but despite his and my best efforts I cannot get the circuit to work. Can anyone please see anything obvious either in the code or the circuit. I am running out of hair to tear out! Thanks for looking.

#include <ATTinyCore.h>

// Production 17 Function DCC Decoder   Dec_17LED_1Ftn.ino
// Version 6.01  Geoff Bunza 2014,2015,2016,2017,2018
// Now works with both short and long DCC Addesses

// ******** UNLESS YOU WANT ALL CV'S RESET UPON EVERY POWER UP
// ******** AFTER THE INITIAL DECODER LOAD REMOVE THE "//" IN THE FOOLOWING LINE!!
//#define DECODER_LOADED

#include <NmraDcc.h>

int tim_delay = 500;
#define numleds  7
byte ledpins [] = {PA0,PA1,PA3,PA4,PA5,PA6,PA7};

const int FunctionPin0 = PA0;
const int FunctionPin1 = PA1;
const int FunctionPin2 = PA3;
const int FunctionPin3 = PA4;
const int FunctionPin4 = PA5;

const int FunctionPin5 = PA6;
const int FunctionPin6 = PA7;
//const int FunctionPin7 = 8;
//const int FunctionPin8 = 9;

//const int FunctionPin9 = 5;
//const int FunctionPin10 = 6;
//const int FunctionPin11 = 7;     //A0
//const int FunctionPin12 = 8;     //A1
//const int FunctionPin13 = 9;     //A2
//const int FunctionPin14 = 17;     //A3
//const int FunctionPin15 = 18;     //A4
//const int FunctionPin16 = 19;     //A5
NmraDcc  Dcc ;
DCC_MSG  Packet ;
uint8_t CV_DECODER_MASTER_RESET = 120;

struct CVPair
{
  uint16_t  CV;
  uint8_t   Value;
};
CVPair FactoryDefaultCVs [] =

#define This_Decoder_Address 462

{
  {CV_MULTIFUNCTION_PRIMARY_ADDRESS, This_Decoder_Address&0x7F },
  
  // These two CVs define the Long DCC Address
  {CV_MULTIFUNCTION_EXTENDED_ADDRESS_MSB, ((This_Decoder_Address>>8)&0x7F)+192 },
  {CV_MULTIFUNCTION_EXTENDED_ADDRESS_LSB, This_Decoder_Address&0xFF },
  
  // ONLY uncomment 1 CV_29_CONFIG line below as approprate DEFAULT IS SHORT ADDRESS
//  {CV_29_CONFIG,          0},                                           // Short Address 14 Speed Steps
 // {CV_29_CONFIG, CV29_F0_LOCATION}, // Short Address 28/128 Speed Steps
 {CV_29_CONFIG, CV29_EXT_ADDRESSING | CV29_F0_LOCATION},   // Long  Address 28/128 Speed Steps  

  {CV_DECODER_MASTER_RESET, 0},
};

uint8_t FactoryDefaultCVIndex = sizeof(FactoryDefaultCVs)/sizeof(CVPair);
void notifyCVResetFactoryDefault()
{
  // Make FactoryDefaultCVIndex non-zero and equal to num CV's to be reset 
  // to flag to the loop() function that a reset to Factory Defaults needs to be done
  FactoryDefaultCVIndex = sizeof(FactoryDefaultCVs)/sizeof(CVPair);
};
void setup()
{
  // initialize the digital pins as an outputs
pinMode (PA2, INPUT);
   
     for (int i=1; i<= numleds; i++) {
      pinMode(ledpins[i], OUTPUT);
      digitalWrite(ledpins[i], LOW);
     }
  for (int i=1; i<= numleds; i++) {
     digitalWrite(ledpins[i], HIGH);
     delay (tim_delay/10);
  }
  delay( tim_delay);
  for (int i=1; i<= numleds; i++) {
     digitalWrite(ledpins[i], LOW);
     delay (tim_delay/10);
  }
  delay( tim_delay);
 
  // Setup which External Interrupt, the Pin it's associated with that we're using and enable the Pull-Up
   Dcc.pin(digitalPinToInterrupt(PB3), PB3, 0);
  // Call the main DCC Init function to enable the DCC Receiver
  Dcc.init( MAN_ID_DIY, 61, FLAGS_MY_ADDRESS_ONLY, 0 );

  delay(800);
#if defined(DECODER_LOADED)
  if ( Dcc.getCV(CV_DECODER_MASTER_RESET)== CV_DECODER_MASTER_RESET ) 
#endif 
     {
       for (int j=0; j < FactoryDefaultCVIndex; j++ )
         Dcc.setCV( FactoryDefaultCVs[j].CV, FactoryDefaultCVs[j].Value);
         digitalWrite(13, 1);  //Blink the on board LED
         delay (1000);
         digitalWrite(13, 0);
     }
}
void loop()
{
  // You MUST call the NmraDcc.process() method frequently from the Arduino loop() function for correct library operation
  Dcc.process();
  if( FactoryDefaultCVIndex && Dcc.isSetCVReady())
  {
    FactoryDefaultCVIndex--; // Decrement first as initially it is the size of the array 
    Dcc.setCV( FactoryDefaultCVs[FactoryDefaultCVIndex].CV, FactoryDefaultCVs[FactoryDefaultCVIndex].Value);
  }
}

void notifyDccFunc( uint16_t Addr, DCC_ADDR_TYPE AddrType, FN_GROUP FuncGrp, uint8_t FuncState)
{
  switch(FuncGrp)
  {
    case FN_0_4:
       digitalWrite( FunctionPin0, (FuncState & FN_BIT_00)>>4 );
      digitalWrite( FunctionPin1, (FuncState & FN_BIT_01) );
      digitalWrite( FunctionPin2, (FuncState & FN_BIT_02)>>1 );
      digitalWrite( FunctionPin3, (FuncState & FN_BIT_03)>>2 );
      digitalWrite( FunctionPin4, (FuncState & FN_BIT_03)>>3 );
      break;
      
    case FN_5_8:
      digitalWrite( FunctionPin5, (FuncState & FN_BIT_05) );
      digitalWrite( FunctionPin6, (FuncState & FN_BIT_06)>>1 );
     // digitalWrite( FunctionPin7, (FuncState & FN_BIT_07)>>2 );
    //  digitalWrite( FunctionPin8, (FuncState & FN_BIT_08)>>3 );
      break;
      
    case FN_9_12:
   //   digitalWrite( FunctionPin9,  (FuncState & FN_BIT_09) );
   //   digitalWrite( FunctionPin10, (FuncState & FN_BIT_10)>>1 );
   //   digitalWrite( FunctionPin11, (FuncState & FN_BIT_11)>>2 );
   //   digitalWrite( FunctionPin12, (FuncState & FN_BIT_12)>>3 );
      break;

    case FN_13_20:
   //   digitalWrite( FunctionPin13, (FuncState & FN_BIT_13) );
   //   digitalWrite( FunctionPin14, (FuncState & FN_BIT_14)>>1 );
   //   digitalWrite( FunctionPin15, (FuncState & FN_BIT_15)>>2 );
   //   digitalWrite( FunctionPin16, (FuncState & FN_BIT_16)>>3 );
      break;
      
    case FN_21_28:
      break;
  }
}

These loops never touch the first element in the array, as your indices are 1…n, whereas your array’s contents should be indexed 0…(n-1).

Start there.