A little over a day, not so bad! I see he also fixed the tutorial.
It took a little effort on your part but that will benefit probably tens or hundreds of thousands of people in the years to come. Helping people on the forum is great but I always feel like the effort ends up being limited in effectiveness. There aren't enough of us to help out every beginner on a one to one basis. Sure maybe some others will find that thread on google and be helped by it but that doesn't seem to happen as much as it should. Fixing or improving the documentation/IDE/example sketches has the potential to make so much more of a difference. We don't even need to invest a lot of time doing it, if everyone just pitches in a little it really does add up.
It seems like a hassle to sign up for GitHub but it's really a cool website. Once you learn how to make pull requests it's so easy to contribute to projects. I'll be browsing some random library, maybe something I'll never use, and spot a small issue. If I had to learn SVN or send an email to some tech support person that probably would just be ignored I'd just forget about it and move on but if it's on GitHub I spend a few minutes submitting a pull request and the world is a better place. That led me into using git for version control on my own projects which has allowed me to work more efficiently and even made me a better programmer.
pert:
A little over a day, not so bad! I see he also fixed the tutorial.
It took a little effort on your part but that will benefit probably tens or hundreds of thousands of people in the years to come. Helping people on the forum is great but I always feel like the effort ends up being limited in effectiveness. There aren't enough of us to help out every beginner on a one to one basis. Sure maybe some others will find that thread on google and be helped by it but that doesn't seem to happen as much as it should. Fixing or improving the documentation/IDE/example sketches has the potential to make so much more of a difference. We don't even need to invest a lot of time doing it, if everyone just pitches in a little it really does add up.
It seems like a hassle to sign up for GitHub but it's really a cool website. Once you learn how to make pull requests it's so easy to contribute to projects. I'll be browsing some random library, maybe something I'll never use, and spot a small issue. If I had to learn SVN or send an email to some tech support person that probably would just be ignored I'd just forget about it and move on but if it's on GitHub I spend a few minutes submitting a pull request and the world is a better place. That led me into using git for version control on my own projects which has allowed me to work more efficiently and even made me a better programmer.
I agree that getting this fixed sure beats doing battle with heaps of people who have picked up the habit, explaining to them that 'long' is not the right way to do it. Especially since if they use 'long' in a program that doesn't run for an extended period, the problem won't show itself. But then they'll write one that has to run forever, and won't know what's causing the hassles.
I'm new to GitHub, only joined especially for this, so aren't yet familiar with all of the terms like "pull request", "commit" etc, but I'll soon get the hang of it all. (I found the GitHub "Hello World" introduction. I'll read through it tomorrow, when I'm wide awake.)
A little over a day was fantastic. Better than I could have hoped for.
Another user and myself get a failed compile but the one from the IDE examples works perfectly.
Both instances using MKR's
The error seems to be lines 54/55 (snippets below)
This one compiles.
// Create open network. Change this line if you want to create an WEP network:
if (WiFi.beginAP(ssid) != WL_CONNECTED) {
Serial.println("Creating access point failed");
// don't continue
while (true);
}
This one from the reference page doesn't
// Create open network. Change this line if you want to create an WEP network:
status = WiFi.beginAP(ssid);
if (status != WL_AP_LISTENING) {
Serial.println("Creating access point failed");
// don't continue
while (true);
}
Ballscrewbob:
Could somebody open an issue to fix the code on .....
Bob, that "somebody" could be you.
There's no need to ask someone else to do it for you.
Edit: Just try to ensure that it's definitely a bug in the code, and that it hasn't already been reported.
You should probably also include the actual error message, IDE version, OS, and any other relevant information.
Hi Steve thought this section was to report bugs so I guess i already did
Unless there is another more special place to report em ??
Oh its a bug fer sure as it fails in 3 IDE's if copied directy from the web page and compiles just fine if called as an example from WiFi101.
I tested it here after a user had an issue then tried it from the examples. Hopefully the user gets it going from the examples to confirm it at his end.
Ballscrewbob:
Hi Steve thought this section was to report bugs so I guess i already did
Unless there is another more special place to report em ??
Oh its a bug fer sure as it fails in 3 IDE's if copied directy from the web page and compiles just fine if called as an example from WiFi101.
I tested it here after a user had an issue then tried it from the examples. Hopefully the user gets it going from the examples to confirm it at his end.
To get the "Debounce" matter fixed, (an IDE example and also in the "Tutorials" section), I had to make an issue report on GitHub. (That's what I started this thread for - to find out how it should be done.)
I thought this was in the same category, since it's a part of the "Reference". Maybe I'm wrong, in which case I spoke out-of-turn. Perhaps all you have to do is mention it here.
Hopefully someone will clarify, because I'm new to this bug-reporting/fixing thing.
Edit: The keywords "open an issue" made me immediately think of a GitHub issue report.
