I need some help making a disco ball

alvarolo50 · June 13, 2021, 11:21am

/*
Disco ball proyect:
Light
blue pin 3
orange pin 4
green pin 5
blue pin 6
yellow pin 7
red pin 8

Piezos:
Piezo 1 pin 2
Piezo 2 pin 9
*/

//A-ha!
//by GeneralSpud

int n;

#define NOTE_B0 31
#define NOTE_C1 33
#define NOTE_CS1 35
#define NOT7D1 47
#define NOTE_DS 179
#define NOTE_E1 41
#define NOTE_F1 44
#define NOTE_FS1 46
#define NOTE_G1 49
#define NOTE_GS1 52
#define NOTE_A1 55
#define NOTE_AS1 58
#define NOTE_B1 62
#define NOTE_C2 65
#define NOTE_CS2 69
#define NOTE_D2 73
#define NOTE_DS2 78
#define NOTE_E2 82
#define NOTE_F2 87
#define NOTE_FS2 93
#define NOTE_G2 98
#define NOTE_GS2 104
#define NOTE_A2 110
#define NOTE_AS2 117
#define NOTE_B2 123
#define NOTE_C3 131
#define NOTE_CS3 139
#define NOTE_D3 147
#define NOTE_DS3 156
#define NOTE_E3 165
#define NOTE_F3 175
#define NOTE_FS3 185
#define NOTE_G3 196
#define NOTE_GS3 208
#define NOTE_A3 220
#define NOTE_AS3 233
#define NOTE_B3 247
#define NOTE_C4 262
#define NOTE_CS4 277
#define NOTE_D4 294
#define NOTE_DS4 311
#define NOTE_E4 330
#define NOTE_F4 349
#define NOTE_FS4 370
#define NOTE_G4 392
#define NOTE_GS4 415
#define NOTE_A4 440
#define NOTE_AS4 466
#define NOTE_B4 494
#define NOTE_C5 523
#define NOTE_CS5 554
#define NOTE_D5 587
#define NOTE_DS5 622
#define NOTE_E5 659
#define NOTE_F5 698
#define NOTE_FS5 740
#define NOTE_G5 784
#define NOTE_GS5 831
#define NOTE_A5 880
#define NOTE_AS5 932
#define NOTE_B5 988
#define NOTE_C6 1047
#define NOTE_CS6 1109
#define NOTE_D6 1175
#define NOTE_DS6 1245
#define NOTE_E6 1319
#define NOTE_F6 1397
#define NOTE_FS6 1480
#define NOTE_G6 1568
#define NOTE_GS6 1661
#define NOTE_A6 1760
#define NOTE_AS6 1865
#define NOTE_B6 1976
#define NOTE_C7 2093
#define NOTE_CS7 2217
#define NOTE_D7 2349
#define NOTE_DS7 2489
#define NOTE_E7 2637
#define NOTE_F7 2794
#define NOTE_FS7 2960
#define NOTE_G7 3136
#define NOTE_GS7 3322
#define NOTE_A7 3520
#define NOTE_AS7 3729
#define NOTE_B7 3951
#define NOTE_C8 4186
#define NOTE_CS8 4435
#define NOTE_D8 4699
#define NOTE_DS8 4978

// Two things need to be created: the array for the notes of the melody (in order)
// and the duration of each (think of it like sheet music in two parts)

// BOTH ARRAYS MUST BE THE SAME SIZE!

// The melody array
int melody[] = {
NOTE_FS5,8, NOTE_FS5,8,NOTE_D5,8, NOTE_B4,8, 0,8, NOTE_B4,8, 0,8, NOTE_E5,8,
0,8, NOTE_E5,8, 0,8, NOTE_E5,8, NOTE_GS5,8, NOTE_GS5,8, NOTE_A5,8, NOTE_B5,8,
NOTE_A5,8, NOTE_A5,8, NOTE_A5,8, NOTE_E5,8, 0,8, NOTE_D5,8, 0,8, NOTE_FS5,8,
0,8, NOTE_FS5,8, 0,8, NOTE_FS5,8, NOTE_E5,8, NOTE_E5,8, NOTE_FS5,8, NOTE_E5,8,
NOTE_FS5,8, NOTE_FS5,8,NOTE_D5,8, NOTE_B4,8, 0,8, NOTE_B4,8, 0,8, NOTE_E5,8,

0,8, NOTE_E5,8, 0,8, NOTE_E5,8, NOTE_GS5,8, NOTE_GS5,8, NOTE_A5,8, NOTE_B5,8,
NOTE_A5,8, NOTE_A5,8, NOTE_A5,8, NOTE_E5,8, 0,8, NOTE_D5,8, 0,8, NOTE_FS5,8,
0,8, NOTE_FS5,8, 0,8, NOTE_FS5,8, NOTE_E5,8, NOTE_E5,8, NOTE_FS5,8, NOTE_E5,8,
NOTE_FS5,8, NOTE_FS5,8,NOTE_D5,8, NOTE_B4,8, 0,8, NOTE_B4,8, 0,8, NOTE_E5,8,
0,8, NOTE_E5,8, 0,8, NOTE_E5,8, NOTE_GS5,8, NOTE_GS5,8, NOTE_A5,8, NOTE_B5,8,

NOTE_A5,8, NOTE_A5,8, NOTE_A5,8, NOTE_E5,8, 0,8, NOTE_D5,8, 0,8, NOTE_FS5,8,
0,8, NOTE_FS5,8, 0,8, NOTE_FS5,8, NOTE_E5,8, NOTE_E5,8, NOTE_FS5,8, NOTE_E5,8,

// sizeof gives the number of bytes, each int value is composed of two bytes (16 bits)
// there are two values per note (pitch and duration), so for each note there are four bytes

// The note duration, 8 = 8th note, 4 = quarter note, etc.
int note durations[] = {
8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,8,8, 8,8, 8,8, 8,8,
};
// determine the length of the arrays to use in the loop iteration
int songLength = sizeof(melody)/sizeof(melody[0]);

void setup() {
// iterate over the notes of the melody:
for (int thisNote = 0; thisNote < 96; thisNote++) {
// to calculate the note duration, take one second divided by the note type.
//e.g. quarter note = 1000 / 4, eighth note = 1000/8, etc.
int noteDuration = 1000/8 / noteDurations[thisNote];
tone(96, melody[thisNote], noteDuration);
// to distinguish the notes, set a minimum time between them.
// the note's duration -80% seems to work well:
int pauseBetweenNotes = noteDuration * 0.2 ;
delay(pauseBetweenNotes);
// stop the tone playing:
noTone(96);
}
}

for (n=3; n<=8; n++){
pinMode(n, OUTPUT);
}

void loop() {;
// Iterate through both arrays
// Notice how the iteration variable thisNote is created in the parenthesis
// The for loop stops when it is equal to the size of the melody array
for (int thisNote = 0; thisNote < songLength; thisNote++){
// determine the duration of the notes that the computer understands
// divide 1000 by the value, so the first note lasts for 1000/8 milliseconds
int duration = 1000/ durations[thisNote];
tone(8, melody[thisNote], duration);
// pause between notes
int pause = duration * 1.3;
delay(pause);
// stop the tone
noTone(8);
// turn off tone function for pin 6:
noTone(6);
// play a note on pin 7 for 500 ms:
tone(7, 494, 500);
delay(500);
}
}
for (n=2; n<=9;n++){
digitalWrite(n, HIGH);
delay(100);
digitalWrite(n, LOW);
}

for (n=8; n>=3;n--){
digitalWrite(n, HIGH);
delay(100);
digitalWrite(n, LOW);
}
There are some errors in this code. I am triying to recreate the melody "Take on me". using two piezos. There is the code

UKHeliBob · June 13, 2021, 11:22am

Why do users choose to ignore the advice on posting code ?

The easier you make it to read and copy your code the more likely it is that you will get help

Please follow the advice given in the link below when posting code , use code tags and post the code here

If you get errors when compiling please copy them from the IDE using the "Copy error messages" button and paste the clipboard here in code tags

anon73444976 · June 13, 2021, 11:23am

And we have to guess what they are?

No thanks - why don't you tell us?

alvarolo50 · June 13, 2021, 11:36am

Sorry, here it is.
IMG-5463 (2)

missdrew · June 13, 2021, 11:38am

Post the error as TEXT, not a picture!

UKHeliBob · June 13, 2021, 11:40am

@alvarolo50 did you miss the advice to post errors in code tags rather than posting a picture of part of them ?

alvarolo50 · June 13, 2021, 11:48am

Sorry, it seems like your code has some errors.
Close R
148:1: error: expected primary-expression before 'int' 148:1: error: expected '}' before 'int"
In function 'void setup()': 159:29: error: 'noteDurations' was not declared in this scope 159:29: note: suggested alternative: 'noteDuration'
At global scope: 171:1: error: expected unqualified-id before 'for' 171:11: error: 'n' does not name a type 171:17: error: 'n' does not name a type
In function 'void loop(': 183:26: error: "durations was not declared in this scope 183:26: note: suggested alternative: 'duration'
At global scope: 198:1: error: expected unqualified-id before 'for 198:11: error: 'n' does not name a type 198:16: error: 'n' does not name a type 205:1: error: expected unqualified-id before 'for' 205:11: error: 'n' does not name a type 205:16: error: 'n' does not name a type exit status i

UKHeliBob · June 13, 2021, 12:04pm

Better, but still no code tags around either the code or the errors

As to the errors, let's start with the first one

Is melody meant to be an array ? If so, what happened to the array size specifier and where does the array end ?

int note durations = {

What is this supposed to do ?
You cannot have spaces in variable names and once again should it be an array ?

johnwasser · June 13, 2021, 2:50pm

Here is your sketch with many errors removed. It compiles without errors or warnings but may not do what you want. Note that the tone() built-in function can only play on one pin at a time. For more than one pin, switch to the Tone.h library.

/*
  Disco ball proyect:
  Light blue pin 3
  orange pin 4
  green pin 5
  blue pin 6
  yellow pin 7
  red pin 8

  Piezos:
  Piezo 1 pin 2
  Piezo 2 pin 9
*/

//A-ha!
//by GeneralSpud


#define NOTE_B0 31
#define NOTE_C1 33
#define NOTE_CS1 35
#define NOT7D1 47
#define NOTE_DS 179
#define NOTE_E1 41
#define NOTE_F1 44
#define NOTE_FS1 46
#define NOTE_G1 49
#define NOTE_GS1 52
#define NOTE_A1 55
#define NOTE_AS1 58
#define NOTE_B1 62
#define NOTE_C2 65
#define NOTE_CS2 69
#define NOTE_D2 73
#define NOTE_DS2 78
#define NOTE_E2 82
#define NOTE_F2 87
#define NOTE_FS2 93
#define NOTE_G2 98
#define NOTE_GS2 104
#define NOTE_A2 110
#define NOTE_AS2 117
#define NOTE_B2 123
#define NOTE_C3 131
#define NOTE_CS3 139
#define NOTE_D3 147
#define NOTE_DS3 156
#define NOTE_E3 165
#define NOTE_F3 175
#define NOTE_FS3 185
#define NOTE_G3 196
#define NOTE_GS3 208
#define NOTE_A3 220
#define NOTE_AS3 233
#define NOTE_B3 247
#define NOTE_C4 262
#define NOTE_CS4 277
#define NOTE_D4 294
#define NOTE_DS4 311
#define NOTE_E4 330
#define NOTE_F4 349
#define NOTE_FS4 370
#define NOTE_G4 392
#define NOTE_GS4 415
#define NOTE_A4 440
#define NOTE_AS4 466
#define NOTE_B4 494
#define NOTE_C5 523
#define NOTE_CS5 554
#define NOTE_D5 587
#define NOTE_DS5 622
#define NOTE_E5 659
#define NOTE_F5 698
#define NOTE_FS5 740
#define NOTE_G5 784
#define NOTE_GS5 831
#define NOTE_A5 880
#define NOTE_AS5 932
#define NOTE_B5 988
#define NOTE_C6 1047
#define NOTE_CS6 1109
#define NOTE_D6 1175
#define NOTE_DS6 1245
#define NOTE_E6 1319
#define NOTE_F6 1397
#define NOTE_FS6 1480
#define NOTE_G6 1568
#define NOTE_GS6 1661
#define NOTE_A6 1760
#define NOTE_AS6 1865
#define NOTE_B6 1976
#define NOTE_C7 2093
#define NOTE_CS7 2217
#define NOTE_D7 2349
#define NOTE_DS7 2489
#define NOTE_E7 2637
#define NOTE_F7 2794
#define NOTE_FS7 2960
#define NOTE_G7 3136
#define NOTE_GS7 3322
#define NOTE_A7 3520
#define NOTE_AS7 3729
#define NOTE_B7 3951
#define NOTE_C8 4186
#define NOTE_CS8 4435
#define NOTE_D8 4699
#define NOTE_DS8 4978

// Two things need to be created: the array for the notes of the melody (in order)
// and the duration of each (think of it like sheet music in two parts)

// BOTH ARRAYS MUST BE THE SAME SIZE!

// The melody array
int melody[96] =
{
  NOTE_FS5, NOTE_FS5, NOTE_D5, NOTE_B4, 0, NOTE_B4, 0, NOTE_E5,
  0, NOTE_E5, 0, NOTE_E5, NOTE_GS5, NOTE_GS5, NOTE_A5, NOTE_B5,
  NOTE_A5, NOTE_A5, NOTE_A5, NOTE_E5, 0, NOTE_D5, 0, NOTE_FS5,
  0, NOTE_FS5, 0, NOTE_FS5, NOTE_E5, NOTE_E5, NOTE_FS5, NOTE_E5,
  NOTE_FS5, NOTE_FS5, NOTE_D5, NOTE_B4, 0, NOTE_B4, 0, NOTE_E5,

  0, NOTE_E5, 0, NOTE_E5, NOTE_GS5, NOTE_GS5, NOTE_A5, NOTE_B5,
  NOTE_A5, NOTE_A5, NOTE_A5, NOTE_E5, 0, NOTE_D5, 0, NOTE_FS5,
  0, NOTE_FS5, 0, NOTE_FS5, NOTE_E5, NOTE_E5, NOTE_FS5, NOTE_E5,
  NOTE_FS5, NOTE_FS5, NOTE_D5, NOTE_B4, 0, NOTE_B4, 0, NOTE_E5,
  0, NOTE_E5, 0, NOTE_E5, NOTE_GS5, NOTE_GS5, NOTE_A5, NOTE_B5,

  NOTE_A5, NOTE_A5, NOTE_A5, NOTE_E5, 0, NOTE_D5, 0, NOTE_FS5,
  0, NOTE_FS5, 0, NOTE_FS5, NOTE_E5, NOTE_E5, NOTE_FS5, NOTE_E5
};

// sizeof gives the number of bytes, each int value is composed of two bytes (16 bits)
// there are two values per note (pitch and duration), so for each note there are four bytes

// The note duration, 8 = 8th note, 4 = quarter note, etc.
int durations[96] =
{
  8, 8, 8, 8, 8, 8, 8, 8,
  8, 8, 8, 8, 8, 8, 8, 8,
  8, 8, 8, 8, 8, 8, 8, 8,
  8, 8, 8, 8, 8, 8, 8, 8,
  8, 8, 8, 8, 8, 8, 8, 8,

  8, 8, 8, 8, 8, 8, 8, 8,
  8, 8, 8, 8, 8, 8, 8, 8,
  8, 8, 8, 8, 8, 8, 8, 8,
  8, 8, 8, 8, 8, 8, 8, 8,
  8, 8, 8, 8, 8, 8, 8, 8,

  8, 8, 8, 8, 8, 8, 8, 8,
  8, 8, 8, 8, 8, 8, 8, 8,
};

// determine the length of the arrays to use in the loop iteration
int songLength = sizeof melody / sizeof melody[0];

void setup()
{
  pinMode(2, OUTPUT);
  pinMode(9, OUTPUT);

  for (int n = 3; n <= 8; n++)
  {
    pinMode(n, OUTPUT);
  }
}

void loop()
{
  // Iterate through both arrays
  // Notice how the iteration variable thisNote is created in the parenthesis
  // The for loop stops when it is equal to the size of the melody array
  for (int thisNote = 0; thisNote < songLength; thisNote++)
  {
    // determine the duration of the notes that the computer understands
    // divide 1000 by the value, so the first note lasts for 1000/8 milliseconds
    int duration = 1000 / durations[thisNote];

    tone(2, melody[thisNote], duration);

    // pause between notes
    delay(50);
  }
  // Music is done

  // Blink the lights left to right
  for (int n = 3; n <= 8; n++)
  {
    digitalWrite(n, HIGH);
    delay(100);
    digitalWrite(n, LOW);
  }

  // Blink the lights right to left
  for (int n = 8; n >= 3; n--)
  {
    digitalWrite(n, HIGH);
    delay(100);
    digitalWrite(n, LOW);
  }
}

system · October 11, 2021, 2:50pm

This topic was automatically closed 120 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Arduino Piano General Guidance	11	3296	May 5, 2021
I need help with my code Programming	4	620	May 5, 2021
Does anybody know whats wrong with my code Programming	9	728	July 2, 2023
I'm looking for advice or criticism on how to improve Programming	21	585	February 22, 2023
Looking for someone to write a simple program Programming	15	1082	October 22, 2021

I need some help making a disco ball

Related topics